* [PATCH] workqueue: Make workqueue_init*() return void
@ 2020-02-23 7:28 Yu Chen
2020-03-04 16:21 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Yu Chen @ 2020-02-23 7:28 UTC (permalink / raw)
To: tj; +Cc: linux-kernel, 33988979, Yu Chen
The return values of workqueue_init() and workqueue_early_int() are
always 0, and there is no usage of their return value. So just make
them return void.
Signed-off-by: Yu Chen <chen.yu@easystack.cn>
---
include/linux/workqueue.h | 4 ++--
kernel/workqueue.c | 8 ++------
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h
index 4261d1c6e..c86a7691e 100644
--- a/include/linux/workqueue.h
+++ b/include/linux/workqueue.h
@@ -649,7 +649,7 @@ int workqueue_online_cpu(unsigned int cpu);
int workqueue_offline_cpu(unsigned int cpu);
#endif
-int __init workqueue_init_early(void);
-int __init workqueue_init(void);
+void __init workqueue_init_early(void);
+void __init workqueue_init(void);
#endif
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index cfc923558..12f491e9c 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -5896,7 +5896,7 @@ static void __init wq_numa_init(void)
* items. Actual work item execution starts only after kthreads can be
* created and scheduled right before early initcalls.
*/
-int __init workqueue_init_early(void)
+void __init workqueue_init_early(void)
{
int std_nice[NR_STD_WORKER_POOLS] = { 0, HIGHPRI_NICE_LEVEL };
int hk_flags = HK_FLAG_DOMAIN | HK_FLAG_WQ;
@@ -5963,8 +5963,6 @@ int __init workqueue_init_early(void)
!system_unbound_wq || !system_freezable_wq ||
!system_power_efficient_wq ||
!system_freezable_power_efficient_wq);
-
- return 0;
}
/**
@@ -5976,7 +5974,7 @@ int __init workqueue_init_early(void)
* are no kworkers executing the work items yet. Populate the worker pools
* with the initial workers and enable future kworker creations.
*/
-int __init workqueue_init(void)
+void __init workqueue_init(void)
{
struct workqueue_struct *wq;
struct worker_pool *pool;
@@ -6023,6 +6021,4 @@ int __init workqueue_init(void)
wq_online = true;
wq_watchdog_init();
-
- return 0;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] workqueue: Make workqueue_init*() return void
2020-02-23 7:28 [PATCH] workqueue: Make workqueue_init*() return void Yu Chen
@ 2020-03-04 16:21 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2020-03-04 16:21 UTC (permalink / raw)
To: Yu Chen; +Cc: linux-kernel, 33988979
On Sun, Feb 23, 2020 at 03:28:52PM +0800, Yu Chen wrote:
> The return values of workqueue_init() and workqueue_early_int() are
> always 0, and there is no usage of their return value. So just make
> them return void.
>
> Signed-off-by: Yu Chen <chen.yu@easystack.cn>
Applied to wq/for-5.7.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-04 16:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-23 7:28 [PATCH] workqueue: Make workqueue_init*() return void Yu Chen
2020-03-04 16:21 ` Tejun Heo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.