* [PATCH v2 net] ionic: fix vf op lock usage
@ 2020-03-04 17:42 Shannon Nelson
2020-03-07 6:03 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Shannon Nelson @ 2020-03-04 17:42 UTC (permalink / raw)
To: davem, netdev; +Cc: parav, Shannon Nelson
These are a couple of read locks that should be write locks.
Fixes: fbb39807e9ae ("ionic: support sr-iov operations")
Signed-off-by: Shannon Nelson <snelson@pensando.io>
Reviewed-by: Parav Pandit <parav@mellanox.com>
---
v2 - fixed the Fixes line
drivers/net/ethernet/pensando/ionic/ionic_lif.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
index 191271f6260d..c2f5b691e0fa 100644
--- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c
+++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
@@ -1688,7 +1688,7 @@ static int ionic_set_vf_mac(struct net_device *netdev, int vf, u8 *mac)
if (!(is_zero_ether_addr(mac) || is_valid_ether_addr(mac)))
return -EINVAL;
- down_read(&ionic->vf_op_lock);
+ down_write(&ionic->vf_op_lock);
if (vf >= pci_num_vf(ionic->pdev) || !ionic->vfs) {
ret = -EINVAL;
@@ -1698,7 +1698,7 @@ static int ionic_set_vf_mac(struct net_device *netdev, int vf, u8 *mac)
ether_addr_copy(ionic->vfs[vf].macaddr, mac);
}
- up_read(&ionic->vf_op_lock);
+ up_write(&ionic->vf_op_lock);
return ret;
}
@@ -1719,7 +1719,7 @@ static int ionic_set_vf_vlan(struct net_device *netdev, int vf, u16 vlan,
if (proto != htons(ETH_P_8021Q))
return -EPROTONOSUPPORT;
- down_read(&ionic->vf_op_lock);
+ down_write(&ionic->vf_op_lock);
if (vf >= pci_num_vf(ionic->pdev) || !ionic->vfs) {
ret = -EINVAL;
@@ -1730,7 +1730,7 @@ static int ionic_set_vf_vlan(struct net_device *netdev, int vf, u16 vlan,
ionic->vfs[vf].vlanid = vlan;
}
- up_read(&ionic->vf_op_lock);
+ up_write(&ionic->vf_op_lock);
return ret;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 net] ionic: fix vf op lock usage
2020-03-04 17:42 [PATCH v2 net] ionic: fix vf op lock usage Shannon Nelson
@ 2020-03-07 6:03 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-03-07 6:03 UTC (permalink / raw)
To: snelson; +Cc: netdev, parav
From: Shannon Nelson <snelson@pensando.io>
Date: Wed, 4 Mar 2020 09:42:10 -0800
> These are a couple of read locks that should be write locks.
>
> Fixes: fbb39807e9ae ("ionic: support sr-iov operations")
> Signed-off-by: Shannon Nelson <snelson@pensando.io>
> Reviewed-by: Parav Pandit <parav@mellanox.com>
> ---
> v2 - fixed the Fixes line
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-07 6:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-04 17:42 [PATCH v2 net] ionic: fix vf op lock usage Shannon Nelson
2020-03-07 6:03 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.