From: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
To: Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org
Cc: l.stach@pengutronix.de, lukas@mntmn.com, agx@sigxcpu.org,
linux-kernel@vger.kernel.org, laurentiu.palcu@oss.nxp.com
Subject: [PATCH v4 0/4] Add support for iMX8MQ Display Controller Subsystem
Date: Fri, 6 Mar 2020 14:49:24 +0200 [thread overview]
Message-ID: <20200306124930.20978-1-laurentiu.palcu@oss.nxp.com> (raw)
From: Laurentiu Palcu <laurentiu.palcu@nxp.com>
Hi,
This patchset adds initial DCSS support for iMX8MQ chip. Initial support
includes only graphics plane support (no video planes), no HDR10 capabilities,
no graphics decompression (only linear, tiled and super-tiled buffers allowed).
Support for the rest of the features will be added incrementally, in subsequent
patches.
The patchset was tested with both HDP driver (not yet upstreamed) and MIPI-DSI
(drivers already on the dri-devel ML).
Thanks,
Laurentiu
Changes in v4:
* Addressed Lucas and Philipp's comments:
* Added DRM_KMS_CMA_HELPER dependency in Kconfig;
* Removed usage of devm_ functions since I'm already doing all the
clean-up in the submodules_deinit();
* Moved the drm_crtc_arm_vblank_event() in dcss_crtc_atomic_flush();
* Removed en_completion variable from dcss_crtc since this was
introduced mainly to avoid vblank timeout warnings which were fixed
by arming the vblank event in flush() instead of begin();
* Removed clks_on and irq_enabled flags since all the calls to
enabling/disabling clocks and interrupts were balanced;
* Removed the custom atomic_commit callback and used the DRM core
helper and, in the process, got rid of a workqueue that wasn't
necessary anymore;
* Fixed some minor DT binding issues flagged by Philipp;
* Some other minor changes suggested by Lucas;
* Removed YUV formats from the supported formats as these cannot work
without the HDR10 module CSCs and LUTs. Will add them back when I
will add support for video planes;
Changes in v3:
* rebased to latest linux-next and made it compile as drmP.h was
removed;
* removed the patch adding the VIDEO2_PLL clock. It's already applied;
* removed an unnecessary 50ms sleep in the dcss_dtg_sync_set();
* fixed a a spurious hang reported by Lukas Hartmann and encountered
by me several times;
* mask DPR and DTG interrupts by default, as they may come enabled from
U-boot;
Changes in v2:
* Removed '0x' in node's unit-address both in DT and yaml;
* Made the address region size lowercase, to be consistent;
* Removed some left-over references to P010;
* Added a Kconfig dependency of DRM && ARCH_MXC. This will also silence compilation
issues reported by kbuild for other architectures;
Laurentiu Palcu (4):
drm/imx: compile imx directory by default
drm/imx: Add initial support for DCSS on iMX8MQ
dt-bindings: display: imx: add bindings for DCSS
arm64: dts: imx8mq: add DCSS node
.../bindings/display/imx/nxp,imx8mq-dcss.yaml | 85 ++
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 23 +
drivers/gpu/drm/Makefile | 2 +-
drivers/gpu/drm/imx/Kconfig | 2 +
drivers/gpu/drm/imx/Makefile | 1 +
drivers/gpu/drm/imx/dcss/Kconfig | 9 +
drivers/gpu/drm/imx/dcss/Makefile | 6 +
drivers/gpu/drm/imx/dcss/dcss-blkctl.c | 73 ++
drivers/gpu/drm/imx/dcss/dcss-crtc.c | 206 +++++
drivers/gpu/drm/imx/dcss/dcss-ctxld.c | 431 +++++++++
drivers/gpu/drm/imx/dcss/dcss-dev.c | 277 ++++++
drivers/gpu/drm/imx/dcss/dcss-dev.h | 172 ++++
drivers/gpu/drm/imx/dcss/dcss-dpr.c | 562 ++++++++++++
drivers/gpu/drm/imx/dcss/dcss-drv.c | 183 ++++
drivers/gpu/drm/imx/dcss/dcss-dtg.c | 413 +++++++++
drivers/gpu/drm/imx/dcss/dcss-kms.c | 188 ++++
drivers/gpu/drm/imx/dcss/dcss-kms.h | 43 +
drivers/gpu/drm/imx/dcss/dcss-plane.c | 405 +++++++++
drivers/gpu/drm/imx/dcss/dcss-scaler.c | 826 ++++++++++++++++++
drivers/gpu/drm/imx/dcss/dcss-ss.c | 180 ++++
20 files changed, 4086 insertions(+), 1 deletion(-)
create mode 100644 Documentation/devicetree/bindings/display/imx/nxp,imx8mq-dcss.yaml
create mode 100644 drivers/gpu/drm/imx/dcss/Kconfig
create mode 100644 drivers/gpu/drm/imx/dcss/Makefile
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-blkctl.c
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-crtc.c
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-ctxld.c
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-dev.c
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-dev.h
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-dpr.c
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-drv.c
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-dtg.c
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-kms.c
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-kms.h
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-plane.c
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-scaler.c
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-ss.c
--
2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
To: Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org
Cc: agx@sigxcpu.org, laurentiu.palcu@oss.nxp.com, lukas@mntmn.com,
linux-kernel@vger.kernel.org, l.stach@pengutronix.de
Subject: [PATCH v4 0/4] Add support for iMX8MQ Display Controller Subsystem
Date: Fri, 6 Mar 2020 14:49:24 +0200 [thread overview]
Message-ID: <20200306124930.20978-1-laurentiu.palcu@oss.nxp.com> (raw)
From: Laurentiu Palcu <laurentiu.palcu@nxp.com>
Hi,
This patchset adds initial DCSS support for iMX8MQ chip. Initial support
includes only graphics plane support (no video planes), no HDR10 capabilities,
no graphics decompression (only linear, tiled and super-tiled buffers allowed).
Support for the rest of the features will be added incrementally, in subsequent
patches.
The patchset was tested with both HDP driver (not yet upstreamed) and MIPI-DSI
(drivers already on the dri-devel ML).
Thanks,
Laurentiu
Changes in v4:
* Addressed Lucas and Philipp's comments:
* Added DRM_KMS_CMA_HELPER dependency in Kconfig;
* Removed usage of devm_ functions since I'm already doing all the
clean-up in the submodules_deinit();
* Moved the drm_crtc_arm_vblank_event() in dcss_crtc_atomic_flush();
* Removed en_completion variable from dcss_crtc since this was
introduced mainly to avoid vblank timeout warnings which were fixed
by arming the vblank event in flush() instead of begin();
* Removed clks_on and irq_enabled flags since all the calls to
enabling/disabling clocks and interrupts were balanced;
* Removed the custom atomic_commit callback and used the DRM core
helper and, in the process, got rid of a workqueue that wasn't
necessary anymore;
* Fixed some minor DT binding issues flagged by Philipp;
* Some other minor changes suggested by Lucas;
* Removed YUV formats from the supported formats as these cannot work
without the HDR10 module CSCs and LUTs. Will add them back when I
will add support for video planes;
Changes in v3:
* rebased to latest linux-next and made it compile as drmP.h was
removed;
* removed the patch adding the VIDEO2_PLL clock. It's already applied;
* removed an unnecessary 50ms sleep in the dcss_dtg_sync_set();
* fixed a a spurious hang reported by Lukas Hartmann and encountered
by me several times;
* mask DPR and DTG interrupts by default, as they may come enabled from
U-boot;
Changes in v2:
* Removed '0x' in node's unit-address both in DT and yaml;
* Made the address region size lowercase, to be consistent;
* Removed some left-over references to P010;
* Added a Kconfig dependency of DRM && ARCH_MXC. This will also silence compilation
issues reported by kbuild for other architectures;
Laurentiu Palcu (4):
drm/imx: compile imx directory by default
drm/imx: Add initial support for DCSS on iMX8MQ
dt-bindings: display: imx: add bindings for DCSS
arm64: dts: imx8mq: add DCSS node
.../bindings/display/imx/nxp,imx8mq-dcss.yaml | 85 ++
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 23 +
drivers/gpu/drm/Makefile | 2 +-
drivers/gpu/drm/imx/Kconfig | 2 +
drivers/gpu/drm/imx/Makefile | 1 +
drivers/gpu/drm/imx/dcss/Kconfig | 9 +
drivers/gpu/drm/imx/dcss/Makefile | 6 +
drivers/gpu/drm/imx/dcss/dcss-blkctl.c | 73 ++
drivers/gpu/drm/imx/dcss/dcss-crtc.c | 206 +++++
drivers/gpu/drm/imx/dcss/dcss-ctxld.c | 431 +++++++++
drivers/gpu/drm/imx/dcss/dcss-dev.c | 277 ++++++
drivers/gpu/drm/imx/dcss/dcss-dev.h | 172 ++++
drivers/gpu/drm/imx/dcss/dcss-dpr.c | 562 ++++++++++++
drivers/gpu/drm/imx/dcss/dcss-drv.c | 183 ++++
drivers/gpu/drm/imx/dcss/dcss-dtg.c | 413 +++++++++
drivers/gpu/drm/imx/dcss/dcss-kms.c | 188 ++++
drivers/gpu/drm/imx/dcss/dcss-kms.h | 43 +
drivers/gpu/drm/imx/dcss/dcss-plane.c | 405 +++++++++
drivers/gpu/drm/imx/dcss/dcss-scaler.c | 826 ++++++++++++++++++
drivers/gpu/drm/imx/dcss/dcss-ss.c | 180 ++++
20 files changed, 4086 insertions(+), 1 deletion(-)
create mode 100644 Documentation/devicetree/bindings/display/imx/nxp,imx8mq-dcss.yaml
create mode 100644 drivers/gpu/drm/imx/dcss/Kconfig
create mode 100644 drivers/gpu/drm/imx/dcss/Makefile
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-blkctl.c
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-crtc.c
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-ctxld.c
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-dev.c
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-dev.h
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-dpr.c
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-drv.c
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-dtg.c
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-kms.c
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-kms.h
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-plane.c
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-scaler.c
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-ss.c
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
To: Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org
Cc: agx@sigxcpu.org, laurentiu.palcu@oss.nxp.com, lukas@mntmn.com,
linux-kernel@vger.kernel.org
Subject: [PATCH v4 0/4] Add support for iMX8MQ Display Controller Subsystem
Date: Fri, 6 Mar 2020 14:49:24 +0200 [thread overview]
Message-ID: <20200306124930.20978-1-laurentiu.palcu@oss.nxp.com> (raw)
From: Laurentiu Palcu <laurentiu.palcu@nxp.com>
Hi,
This patchset adds initial DCSS support for iMX8MQ chip. Initial support
includes only graphics plane support (no video planes), no HDR10 capabilities,
no graphics decompression (only linear, tiled and super-tiled buffers allowed).
Support for the rest of the features will be added incrementally, in subsequent
patches.
The patchset was tested with both HDP driver (not yet upstreamed) and MIPI-DSI
(drivers already on the dri-devel ML).
Thanks,
Laurentiu
Changes in v4:
* Addressed Lucas and Philipp's comments:
* Added DRM_KMS_CMA_HELPER dependency in Kconfig;
* Removed usage of devm_ functions since I'm already doing all the
clean-up in the submodules_deinit();
* Moved the drm_crtc_arm_vblank_event() in dcss_crtc_atomic_flush();
* Removed en_completion variable from dcss_crtc since this was
introduced mainly to avoid vblank timeout warnings which were fixed
by arming the vblank event in flush() instead of begin();
* Removed clks_on and irq_enabled flags since all the calls to
enabling/disabling clocks and interrupts were balanced;
* Removed the custom atomic_commit callback and used the DRM core
helper and, in the process, got rid of a workqueue that wasn't
necessary anymore;
* Fixed some minor DT binding issues flagged by Philipp;
* Some other minor changes suggested by Lucas;
* Removed YUV formats from the supported formats as these cannot work
without the HDR10 module CSCs and LUTs. Will add them back when I
will add support for video planes;
Changes in v3:
* rebased to latest linux-next and made it compile as drmP.h was
removed;
* removed the patch adding the VIDEO2_PLL clock. It's already applied;
* removed an unnecessary 50ms sleep in the dcss_dtg_sync_set();
* fixed a a spurious hang reported by Lukas Hartmann and encountered
by me several times;
* mask DPR and DTG interrupts by default, as they may come enabled from
U-boot;
Changes in v2:
* Removed '0x' in node's unit-address both in DT and yaml;
* Made the address region size lowercase, to be consistent;
* Removed some left-over references to P010;
* Added a Kconfig dependency of DRM && ARCH_MXC. This will also silence compilation
issues reported by kbuild for other architectures;
Laurentiu Palcu (4):
drm/imx: compile imx directory by default
drm/imx: Add initial support for DCSS on iMX8MQ
dt-bindings: display: imx: add bindings for DCSS
arm64: dts: imx8mq: add DCSS node
.../bindings/display/imx/nxp,imx8mq-dcss.yaml | 85 ++
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 23 +
drivers/gpu/drm/Makefile | 2 +-
drivers/gpu/drm/imx/Kconfig | 2 +
drivers/gpu/drm/imx/Makefile | 1 +
drivers/gpu/drm/imx/dcss/Kconfig | 9 +
drivers/gpu/drm/imx/dcss/Makefile | 6 +
drivers/gpu/drm/imx/dcss/dcss-blkctl.c | 73 ++
drivers/gpu/drm/imx/dcss/dcss-crtc.c | 206 +++++
drivers/gpu/drm/imx/dcss/dcss-ctxld.c | 431 +++++++++
drivers/gpu/drm/imx/dcss/dcss-dev.c | 277 ++++++
drivers/gpu/drm/imx/dcss/dcss-dev.h | 172 ++++
drivers/gpu/drm/imx/dcss/dcss-dpr.c | 562 ++++++++++++
drivers/gpu/drm/imx/dcss/dcss-drv.c | 183 ++++
drivers/gpu/drm/imx/dcss/dcss-dtg.c | 413 +++++++++
drivers/gpu/drm/imx/dcss/dcss-kms.c | 188 ++++
drivers/gpu/drm/imx/dcss/dcss-kms.h | 43 +
drivers/gpu/drm/imx/dcss/dcss-plane.c | 405 +++++++++
drivers/gpu/drm/imx/dcss/dcss-scaler.c | 826 ++++++++++++++++++
drivers/gpu/drm/imx/dcss/dcss-ss.c | 180 ++++
20 files changed, 4086 insertions(+), 1 deletion(-)
create mode 100644 Documentation/devicetree/bindings/display/imx/nxp,imx8mq-dcss.yaml
create mode 100644 drivers/gpu/drm/imx/dcss/Kconfig
create mode 100644 drivers/gpu/drm/imx/dcss/Makefile
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-blkctl.c
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-crtc.c
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-ctxld.c
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-dev.c
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-dev.h
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-dpr.c
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-drv.c
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-dtg.c
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-kms.c
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-kms.h
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-plane.c
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-scaler.c
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-ss.c
--
2.17.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2020-03-06 12:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 12:49 Laurentiu Palcu [this message]
2020-03-06 12:49 ` [PATCH v4 0/4] Add support for iMX8MQ Display Controller Subsystem Laurentiu Palcu
2020-03-06 12:49 ` Laurentiu Palcu
2020-03-06 12:49 ` [PATCH v4 1/4] drm/imx: compile imx directory by default Laurentiu Palcu
2020-03-06 12:49 ` Laurentiu Palcu
2020-03-06 12:49 ` [PATCH v4 2/4] drm/imx: Add initial support for DCSS on iMX8MQ Laurentiu Palcu
2020-03-06 12:49 ` Laurentiu Palcu
2020-05-15 9:27 ` Guido Günther
2020-05-15 9:27 ` Guido Günther
2020-05-15 11:10 ` Laurentiu Palcu
2020-05-15 11:10 ` Laurentiu Palcu
2020-05-15 11:23 ` Guido Günther
2020-05-15 11:23 ` Guido Günther
2020-03-06 12:49 ` [PATCH v4 3/4] dt-bindings: display: imx: add bindings for DCSS Laurentiu Palcu
2020-03-12 17:20 ` Laurentiu Palcu
2020-03-12 17:20 ` Laurentiu Palcu
2020-03-06 12:49 ` Laurentiu Palcu
2020-03-12 17:25 ` Rob Herring
2020-03-12 17:25 ` Rob Herring
2020-03-06 12:49 ` [PATCH v4 4/4] arm64: dts: imx8mq: add DCSS node Laurentiu Palcu
2020-03-06 12:49 ` Laurentiu Palcu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200306124930.20978-1-laurentiu.palcu@oss.nxp.com \
--to=laurentiu.palcu@oss.nxp.com \
--cc=agx@sigxcpu.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@mntmn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.