From: Daniel Vetter <daniel@ffwll.ch> To: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com> Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Subject: Re: [RESEND PATCH v2 0/7] drm: drm_fb_helper cleanup. Date: Fri, 6 Mar 2020 14:46:53 +0100 [thread overview] Message-ID: <20200306134653.GA2363188@phenom.ffwll.local> (raw) In-Reply-To: <20200305120434.111091-1-pankaj.laxminarayan.bharadiya@intel.com> On Thu, Mar 05, 2020 at 05:34:27PM +0530, Pankaj Bharadiya wrote: > This series addresses below drm_fb_helper tasks from > Documentation/gpu/todo.rst. > > - The max connector argument for drm_fb_helper_init() isn't used > anymore and can be removed. > > - The helper doesn't keep an array of connectors anymore so these can > be removed: drm_fb_helper_single_add_all_connectors(), > drm_fb_helper_add_one_connector() and > drm_fb_helper_remove_one_connector(). Entire series applied, thanks for doing this cleanup. -Daniel > > Changes since v1: > - Accumulated all review tags into individual commits (Emil, Daniel) > - Squashed warning fixes into the patch that introduced the > warnings (into 5/7) (Laurent, Emil, Lyude) > - Remove entire drm_fb_helper tasks from todo list. Daniel's > "64914da24ea9 drm/fbdev-helper: don't force restores" fixes first > one (Daniel) > > Pankaj Bharadiya (7): > drm: Remove unused arg from drm_fb_helper_init > drm/radeon: remove radeon_fb_{add,remove}_connector functions > drm/amdgpu: Remove drm_fb_helper_{add,remove}_one_connector calls > drm/i915/display: Remove drm_fb_helper_{add,remove}_one_connector calls > drm: Remove drm_fb_helper add, add all and remove connector calls > drm/fb-helper: Remove drm_fb_helper add, add_all and remove connector functions > drm/todo: Update drm_fb_helper tasks > > Documentation/gpu/todo.rst | 17 ------------ > drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 5 +--- > .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 13 --------- > drivers/gpu/drm/armada/armada_fbdev.c | 8 +----- > drivers/gpu/drm/bridge/tc358764.c | 3 --- > drivers/gpu/drm/drm_fb_helper.c | 6 ++--- > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 1 - > drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 10 +------ > drivers/gpu/drm/gma500/framebuffer.c | 6 +---- > drivers/gpu/drm/i915/display/intel_dp_mst.c | 12 --------- > drivers/gpu/drm/i915/display/intel_fbdev.c | 4 +-- > drivers/gpu/drm/msm/msm_fbdev.c | 6 +---- > drivers/gpu/drm/nouveau/dispnv50/disp.c | 7 ----- > drivers/gpu/drm/nouveau/nouveau_fbcon.c | 6 +---- > drivers/gpu/drm/omapdrm/omap_fbdev.c | 6 +---- > drivers/gpu/drm/radeon/radeon_dp_mst.c | 10 ------- > drivers/gpu/drm/radeon/radeon_fb.c | 19 +------------ > drivers/gpu/drm/radeon/radeon_mode.h | 3 --- > drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 9 +------ > drivers/gpu/drm/tegra/fb.c | 8 +----- > include/drm/drm_fb_helper.h | 27 ++----------------- > 21 files changed, 15 insertions(+), 171 deletions(-) > > -- > 2.20.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch> To: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com> Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [RESEND PATCH v2 0/7] drm: drm_fb_helper cleanup. Date: Fri, 6 Mar 2020 14:46:53 +0100 [thread overview] Message-ID: <20200306134653.GA2363188@phenom.ffwll.local> (raw) In-Reply-To: <20200305120434.111091-1-pankaj.laxminarayan.bharadiya@intel.com> On Thu, Mar 05, 2020 at 05:34:27PM +0530, Pankaj Bharadiya wrote: > This series addresses below drm_fb_helper tasks from > Documentation/gpu/todo.rst. > > - The max connector argument for drm_fb_helper_init() isn't used > anymore and can be removed. > > - The helper doesn't keep an array of connectors anymore so these can > be removed: drm_fb_helper_single_add_all_connectors(), > drm_fb_helper_add_one_connector() and > drm_fb_helper_remove_one_connector(). Entire series applied, thanks for doing this cleanup. -Daniel > > Changes since v1: > - Accumulated all review tags into individual commits (Emil, Daniel) > - Squashed warning fixes into the patch that introduced the > warnings (into 5/7) (Laurent, Emil, Lyude) > - Remove entire drm_fb_helper tasks from todo list. Daniel's > "64914da24ea9 drm/fbdev-helper: don't force restores" fixes first > one (Daniel) > > Pankaj Bharadiya (7): > drm: Remove unused arg from drm_fb_helper_init > drm/radeon: remove radeon_fb_{add,remove}_connector functions > drm/amdgpu: Remove drm_fb_helper_{add,remove}_one_connector calls > drm/i915/display: Remove drm_fb_helper_{add,remove}_one_connector calls > drm: Remove drm_fb_helper add, add all and remove connector calls > drm/fb-helper: Remove drm_fb_helper add, add_all and remove connector functions > drm/todo: Update drm_fb_helper tasks > > Documentation/gpu/todo.rst | 17 ------------ > drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 5 +--- > .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 13 --------- > drivers/gpu/drm/armada/armada_fbdev.c | 8 +----- > drivers/gpu/drm/bridge/tc358764.c | 3 --- > drivers/gpu/drm/drm_fb_helper.c | 6 ++--- > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 1 - > drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 10 +------ > drivers/gpu/drm/gma500/framebuffer.c | 6 +---- > drivers/gpu/drm/i915/display/intel_dp_mst.c | 12 --------- > drivers/gpu/drm/i915/display/intel_fbdev.c | 4 +-- > drivers/gpu/drm/msm/msm_fbdev.c | 6 +---- > drivers/gpu/drm/nouveau/dispnv50/disp.c | 7 ----- > drivers/gpu/drm/nouveau/nouveau_fbcon.c | 6 +---- > drivers/gpu/drm/omapdrm/omap_fbdev.c | 6 +---- > drivers/gpu/drm/radeon/radeon_dp_mst.c | 10 ------- > drivers/gpu/drm/radeon/radeon_fb.c | 19 +------------ > drivers/gpu/drm/radeon/radeon_mode.h | 3 --- > drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 9 +------ > drivers/gpu/drm/tegra/fb.c | 8 +----- > include/drm/drm_fb_helper.h | 27 ++----------------- > 21 files changed, 15 insertions(+), 171 deletions(-) > > -- > 2.20.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-03-06 13:47 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-05 12:04 [RESEND PATCH v2 0/7] drm: drm_fb_helper cleanup Pankaj Bharadiya 2020-03-05 12:04 ` [Intel-gfx] " Pankaj Bharadiya 2020-03-05 12:04 ` [RESEND PATCH v2 1/7] drm: Remove unused arg from drm_fb_helper_init Pankaj Bharadiya 2020-03-05 12:04 ` [Intel-gfx] " Pankaj Bharadiya 2020-03-05 12:04 ` [RESEND PATCH v2 2/7] drm/radeon: remove radeon_fb_{add, remove}_connector functions Pankaj Bharadiya 2020-03-05 12:04 ` [Intel-gfx] " Pankaj Bharadiya 2020-03-05 12:04 ` [RESEND PATCH v2 3/7] drm/amdgpu: Remove drm_fb_helper_{add, remove}_one_connector calls Pankaj Bharadiya 2020-03-05 12:04 ` [Intel-gfx] " Pankaj Bharadiya 2020-03-05 12:04 ` [RESEND PATCH v2 4/7] drm/i915/display: " Pankaj Bharadiya 2020-03-05 12:04 ` [Intel-gfx] " Pankaj Bharadiya 2020-03-05 12:04 ` [RESEND PATCH v2 5/7] drm: Remove drm_fb_helper add, add all and remove connector calls Pankaj Bharadiya 2020-03-05 12:04 ` [Intel-gfx] " Pankaj Bharadiya 2020-03-05 12:04 ` [RESEND PATCH v2 6/7] drm/fb-helper: Remove drm_fb_helper add, add_all and remove connector functions Pankaj Bharadiya 2020-03-05 12:04 ` [Intel-gfx] " Pankaj Bharadiya 2020-03-05 12:04 ` [RESEND PATCH v2 7/7] drm/todo: Update drm_fb_helper tasks Pankaj Bharadiya 2020-03-05 12:04 ` [Intel-gfx] " Pankaj Bharadiya 2020-03-05 22:13 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm: drm_fb_helper cleanup. (rev3) Patchwork 2020-03-05 22:19 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2020-03-06 13:46 ` Daniel Vetter [this message] 2020-03-06 13:46 ` [Intel-gfx] [RESEND PATCH v2 0/7] drm: drm_fb_helper cleanup Daniel Vetter 2020-03-06 13:54 ` [Intel-gfx] ✓ Fi.CI.IGT: success for drm: drm_fb_helper cleanup. (rev3) Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200306134653.GA2363188@phenom.ffwll.local \ --to=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=pankaj.laxminarayan.bharadiya@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.