* [PATCH v2] pinctrl: qcom: ssbi-gpio: Fix fwspec parsing bug
@ 2020-03-06 14:34 Linus Walleij
2020-03-06 15:26 ` Brian Masney
2020-03-10 6:49 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Linus Walleij @ 2020-03-06 14:34 UTC (permalink / raw)
To: linux-gpio; +Cc: Linus Walleij, Brian Masney, Bjorn Andersson, stable
We are parsing SSBI gpios as fourcell fwspecs but they are
twocell. Probably a simple copy-and-paste bug.
Tested on the APQ8060 DragonBoard and after this ethernet
and MMC card detection works again.
Cc: Brian Masney <masneyb@onstation.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: stable@vger.kernel.org
Fixes: ae436fe81053 ("pinctrl: ssbi-gpio: convert to hierarchical IRQ helpers in gpio core")
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
ChangeLog v1->v2:
- Renamed function pointer field to .populate_parent_alloc_arg
as it is named upstream.
---
drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c b/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c
index fba1d41d20ec..338a15d08629 100644
--- a/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c
@@ -794,7 +794,7 @@ static int pm8xxx_gpio_probe(struct platform_device *pdev)
girq->fwnode = of_node_to_fwnode(pctrl->dev->of_node);
girq->parent_domain = parent_domain;
girq->child_to_parent_hwirq = pm8xxx_child_to_parent_hwirq;
- girq->populate_parent_alloc_arg = gpiochip_populate_parent_fwspec_fourcell;
+ girq->populate_parent_alloc_arg = gpiochip_populate_parent_fwspec_twocell;
girq->child_offset_to_irq = pm8xxx_child_offset_to_irq;
girq->child_irq_domain_ops.translate = pm8xxx_domain_translate;
--
2.24.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] pinctrl: qcom: ssbi-gpio: Fix fwspec parsing bug
2020-03-06 14:34 [PATCH v2] pinctrl: qcom: ssbi-gpio: Fix fwspec parsing bug Linus Walleij
@ 2020-03-06 15:26 ` Brian Masney
2020-03-10 6:49 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Brian Masney @ 2020-03-06 15:26 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-gpio, Bjorn Andersson, stable
On Fri, Mar 06, 2020 at 03:34:15PM +0100, Linus Walleij wrote:
> We are parsing SSBI gpios as fourcell fwspecs but they are
> twocell. Probably a simple copy-and-paste bug.
>
> Tested on the APQ8060 DragonBoard and after this ethernet
> and MMC card detection works again.
>
> Cc: Brian Masney <masneyb@onstation.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: stable@vger.kernel.org
> Fixes: ae436fe81053 ("pinctrl: ssbi-gpio: convert to hierarchical IRQ helpers in gpio core")
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Brian Masney <masneyb@onstation.org>
That was a copy and paste error on my part that originated from
spmi-gpio.
Brian
> ---
> ChangeLog v1->v2:
> - Renamed function pointer field to .populate_parent_alloc_arg
> as it is named upstream.
> ---
> drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c b/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c
> index fba1d41d20ec..338a15d08629 100644
> --- a/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c
> +++ b/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c
> @@ -794,7 +794,7 @@ static int pm8xxx_gpio_probe(struct platform_device *pdev)
> girq->fwnode = of_node_to_fwnode(pctrl->dev->of_node);
> girq->parent_domain = parent_domain;
> girq->child_to_parent_hwirq = pm8xxx_child_to_parent_hwirq;
> - girq->populate_parent_alloc_arg = gpiochip_populate_parent_fwspec_fourcell;
> + girq->populate_parent_alloc_arg = gpiochip_populate_parent_fwspec_twocell;
> girq->child_offset_to_irq = pm8xxx_child_offset_to_irq;
> girq->child_irq_domain_ops.translate = pm8xxx_domain_translate;
>
> --
> 2.24.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] pinctrl: qcom: ssbi-gpio: Fix fwspec parsing bug
2020-03-06 14:34 [PATCH v2] pinctrl: qcom: ssbi-gpio: Fix fwspec parsing bug Linus Walleij
2020-03-06 15:26 ` Brian Masney
@ 2020-03-10 6:49 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2020-03-10 6:49 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-gpio, Brian Masney, stable
On Fri 06 Mar 06:34 PST 2020, Linus Walleij wrote:
> We are parsing SSBI gpios as fourcell fwspecs but they are
> twocell. Probably a simple copy-and-paste bug.
>
> Tested on the APQ8060 DragonBoard and after this ethernet
> and MMC card detection works again.
>
> Cc: Brian Masney <masneyb@onstation.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: stable@vger.kernel.org
> Fixes: ae436fe81053 ("pinctrl: ssbi-gpio: convert to hierarchical IRQ helpers in gpio core")
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ChangeLog v1->v2:
> - Renamed function pointer field to .populate_parent_alloc_arg
> as it is named upstream.
Okay, let's try again then :)
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c b/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c
> index fba1d41d20ec..338a15d08629 100644
> --- a/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c
> +++ b/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c
> @@ -794,7 +794,7 @@ static int pm8xxx_gpio_probe(struct platform_device *pdev)
> girq->fwnode = of_node_to_fwnode(pctrl->dev->of_node);
> girq->parent_domain = parent_domain;
> girq->child_to_parent_hwirq = pm8xxx_child_to_parent_hwirq;
> - girq->populate_parent_alloc_arg = gpiochip_populate_parent_fwspec_fourcell;
> + girq->populate_parent_alloc_arg = gpiochip_populate_parent_fwspec_twocell;
> girq->child_offset_to_irq = pm8xxx_child_offset_to_irq;
> girq->child_irq_domain_ops.translate = pm8xxx_domain_translate;
>
> --
> 2.24.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-10 6:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-06 14:34 [PATCH v2] pinctrl: qcom: ssbi-gpio: Fix fwspec parsing bug Linus Walleij
2020-03-06 15:26 ` Brian Masney
2020-03-10 6:49 ` Bjorn Andersson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.