All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Price <steven.price@arm.com>
To: Rob Herring <robh@kernel.org>
Cc: Nick Fan <nick.fan@mediatek.com>,
	Nicolas Boichat <drinkcat@chromium.org>,
	Sj Huang <sj.huang@mediatek.com>, David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Mark Rutland <Mark.Rutland@arm.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Tomeu Vizoso <tomeu.vizoso@collabora.com>,
	Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Devicetree List <devicetree@vger.kernel.org>,
	lkml <linux-kernel@vger.kernel.org>,
	linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
	"moderated list:ARM/Mediatek SoC support" 
	<linux-mediatek@lists.infradead.org>,
	Hsin-Yi Wang <hsinyi@chromium.org>,
	Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH v4 1/7] dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183
Date: Fri, 6 Mar 2020 14:43:36 +0000	[thread overview]
Message-ID: <20200306144336.GA9234@arm.com> (raw)
In-Reply-To: <CAL_JsqLoUnxfrJh0WCs0jgro1KHAjWaYMsaKkKfAKA2KJ252_g@mail.gmail.com>

On Fri, Mar 06, 2020 at 02:13:08PM +0000, Rob Herring wrote:
> On Thu, Mar 5, 2020 at 8:34 PM Nick Fan <nick.fan@mediatek.com> wrote:
> >
> > Sorry for my late reply.
> > I have checked internally.
> > The MT8183_POWER_DOMAIN_MFG_2D is just a legacy name, not really 2D
> > domain.
> >
> > If the naming too confusing, we can change this name to
> > MT8183_POWER_DOMAIN_MFG_CORE2 for consistency.
> 
> Can you clarify what's in each domain? Are there actually 3 shader
> cores (IIRC, that should be discoverable)?

The cover letter from Nicolas includes:

> [  501.321752] panfrost 13040000.gpu: shader_present=0x7 l2_present=0x1

0x7 is three bits set, so it certainly looks like there are 3 shader
cores. Of course I wouldn't guarantee that it is as simple as each power
domain has a shader core in. The job manager and tiler also need to be
powered somehow, so they are either sharing with a shader core or
there's something more complex going on.

Steve


WARNING: multiple messages have this Message-ID (diff)
From: Steven Price <steven.price@arm.com>
To: Rob Herring <robh@kernel.org>
Cc: Mark Rutland <Mark.Rutland@arm.com>,
	Devicetree List <devicetree@vger.kernel.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Nicolas Boichat <drinkcat@chromium.org>,
	Tomeu Vizoso <tomeu.vizoso@collabora.com>,
	David Airlie <airlied@linux.ie>,
	Liam Girdwood <lgirdwood@gmail.com>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	lkml <linux-kernel@vger.kernel.org>,
	Sj Huang <sj.huang@mediatek.com>, Mark Brown <broonie@kernel.org>,
	"moderated list:ARM/Mediatek SoC support"
	<linux-mediatek@lists.infradead.org>,
	Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
	Daniel Vetter <daniel@ffwll.ch>,
	Hsin-Yi Wang <hsinyi@chromium.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Nick Fan <nick.fan@mediatek.com>,
	linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 1/7] dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183
Date: Fri, 6 Mar 2020 14:43:36 +0000	[thread overview]
Message-ID: <20200306144336.GA9234@arm.com> (raw)
In-Reply-To: <CAL_JsqLoUnxfrJh0WCs0jgro1KHAjWaYMsaKkKfAKA2KJ252_g@mail.gmail.com>

On Fri, Mar 06, 2020 at 02:13:08PM +0000, Rob Herring wrote:
> On Thu, Mar 5, 2020 at 8:34 PM Nick Fan <nick.fan@mediatek.com> wrote:
> >
> > Sorry for my late reply.
> > I have checked internally.
> > The MT8183_POWER_DOMAIN_MFG_2D is just a legacy name, not really 2D
> > domain.
> >
> > If the naming too confusing, we can change this name to
> > MT8183_POWER_DOMAIN_MFG_CORE2 for consistency.
> 
> Can you clarify what's in each domain? Are there actually 3 shader
> cores (IIRC, that should be discoverable)?

The cover letter from Nicolas includes:

> [  501.321752] panfrost 13040000.gpu: shader_present=0x7 l2_present=0x1

0x7 is three bits set, so it certainly looks like there are 3 shader
cores. Of course I wouldn't guarantee that it is as simple as each power
domain has a shader core in. The job manager and tiler also need to be
powered somehow, so they are either sharing with a shader core or
there's something more complex going on.

Steve


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Steven Price <steven.price@arm.com>
To: Rob Herring <robh@kernel.org>
Cc: Mark Rutland <Mark.Rutland@arm.com>,
	Devicetree List <devicetree@vger.kernel.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Nicolas Boichat <drinkcat@chromium.org>,
	Tomeu Vizoso <tomeu.vizoso@collabora.com>,
	David Airlie <airlied@linux.ie>,
	Liam Girdwood <lgirdwood@gmail.com>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	lkml <linux-kernel@vger.kernel.org>,
	Sj Huang <sj.huang@mediatek.com>, Mark Brown <broonie@kernel.org>,
	"moderated list:ARM/Mediatek SoC support"
	<linux-mediatek@lists.infradead.org>,
	Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
	Daniel Vetter <daniel@ffwll.ch>,
	Hsin-Yi Wang <hsinyi@chromium.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Nick Fan <nick.fan@mediatek.com>,
	linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 1/7] dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183
Date: Fri, 6 Mar 2020 14:43:36 +0000	[thread overview]
Message-ID: <20200306144336.GA9234@arm.com> (raw)
In-Reply-To: <CAL_JsqLoUnxfrJh0WCs0jgro1KHAjWaYMsaKkKfAKA2KJ252_g@mail.gmail.com>

On Fri, Mar 06, 2020 at 02:13:08PM +0000, Rob Herring wrote:
> On Thu, Mar 5, 2020 at 8:34 PM Nick Fan <nick.fan@mediatek.com> wrote:
> >
> > Sorry for my late reply.
> > I have checked internally.
> > The MT8183_POWER_DOMAIN_MFG_2D is just a legacy name, not really 2D
> > domain.
> >
> > If the naming too confusing, we can change this name to
> > MT8183_POWER_DOMAIN_MFG_CORE2 for consistency.
> 
> Can you clarify what's in each domain? Are there actually 3 shader
> cores (IIRC, that should be discoverable)?

The cover letter from Nicolas includes:

> [  501.321752] panfrost 13040000.gpu: shader_present=0x7 l2_present=0x1

0x7 is three bits set, so it certainly looks like there are 3 shader
cores. Of course I wouldn't guarantee that it is as simple as each power
domain has a shader core in. The job manager and tiler also need to be
powered somehow, so they are either sharing with a shader core or
there's something more complex going on.

Steve


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Steven Price <steven.price@arm.com>
To: Rob Herring <robh@kernel.org>
Cc: Mark Rutland <Mark.Rutland@arm.com>,
	Devicetree List <devicetree@vger.kernel.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Nicolas Boichat <drinkcat@chromium.org>,
	Tomeu Vizoso <tomeu.vizoso@collabora.com>,
	David Airlie <airlied@linux.ie>,
	Liam Girdwood <lgirdwood@gmail.com>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	lkml <linux-kernel@vger.kernel.org>,
	Sj Huang <sj.huang@mediatek.com>, Mark Brown <broonie@kernel.org>,
	"moderated list:ARM/Mediatek SoC support"
	<linux-mediatek@lists.infradead.org>,
	Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
	Hsin-Yi Wang <hsinyi@chromium.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Nick Fan <nick.fan@mediatek.com>,
	linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 1/7] dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183
Date: Fri, 6 Mar 2020 14:43:36 +0000	[thread overview]
Message-ID: <20200306144336.GA9234@arm.com> (raw)
In-Reply-To: <CAL_JsqLoUnxfrJh0WCs0jgro1KHAjWaYMsaKkKfAKA2KJ252_g@mail.gmail.com>

On Fri, Mar 06, 2020 at 02:13:08PM +0000, Rob Herring wrote:
> On Thu, Mar 5, 2020 at 8:34 PM Nick Fan <nick.fan@mediatek.com> wrote:
> >
> > Sorry for my late reply.
> > I have checked internally.
> > The MT8183_POWER_DOMAIN_MFG_2D is just a legacy name, not really 2D
> > domain.
> >
> > If the naming too confusing, we can change this name to
> > MT8183_POWER_DOMAIN_MFG_CORE2 for consistency.
> 
> Can you clarify what's in each domain? Are there actually 3 shader
> cores (IIRC, that should be discoverable)?

The cover letter from Nicolas includes:

> [  501.321752] panfrost 13040000.gpu: shader_present=0x7 l2_present=0x1

0x7 is three bits set, so it certainly looks like there are 3 shader
cores. Of course I wouldn't guarantee that it is as simple as each power
domain has a shader core in. The job manager and tiler also need to be
powered somehow, so they are either sharing with a shader core or
there's something more complex going on.

Steve

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-03-06 14:43 UTC|newest]

Thread overview: 166+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-07  5:26 [PATCH v4 0/7] Add dts for mt8183 GPU (and misc panfrost patches) Nicolas Boichat
2020-02-07  5:26 ` Nicolas Boichat
2020-02-07  5:26 ` Nicolas Boichat
2020-02-07  5:26 ` Nicolas Boichat
2020-02-07  5:26 ` [PATCH v4 1/7] dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183 Nicolas Boichat
2020-02-07  5:26   ` Nicolas Boichat
2020-02-07  5:26   ` Nicolas Boichat
2020-02-07  5:26   ` Nicolas Boichat
2020-02-25 17:16   ` Rob Herring
2020-02-25 17:16     ` Rob Herring
2020-02-25 17:16     ` Rob Herring
2020-02-25 17:16     ` Rob Herring
2020-02-26  0:55     ` Nicolas Boichat
2020-02-26  0:55       ` Nicolas Boichat
2020-02-26  0:55       ` Nicolas Boichat
2020-02-26  0:55       ` Nicolas Boichat
2020-03-06  2:34       ` Nick Fan
2020-03-06  2:34         ` Nick Fan
2020-03-06  2:34         ` Nick Fan
2020-03-06  2:34         ` Nick Fan
2020-03-06  2:43         ` Nicolas Boichat
2020-03-06  2:43           ` Nicolas Boichat
2020-03-06  2:43           ` Nicolas Boichat
2020-03-06  2:43           ` Nicolas Boichat
2020-03-06 14:13         ` Rob Herring
2020-03-06 14:13           ` Rob Herring
2020-03-06 14:13           ` Rob Herring
2020-03-06 14:13           ` Rob Herring
2020-03-06 14:43           ` Steven Price [this message]
2020-03-06 14:43             ` Steven Price
2020-03-06 14:43             ` Steven Price
2020-03-06 14:43             ` Steven Price
2020-03-09  7:55             ` Nick Fan
2020-03-09  7:55               ` Nick Fan
2020-03-09  7:55               ` Nick Fan
2020-03-09  7:55               ` Nick Fan
2020-02-07  5:26 ` [PATCH v4 2/7] arm64: dts: mt8183: Add node for the Mali GPU Nicolas Boichat
2020-02-07  5:26   ` Nicolas Boichat
2020-02-07  5:26   ` Nicolas Boichat
2020-02-07  5:26   ` Nicolas Boichat
2020-02-07  5:26 ` [PATCH v4 3/7] drm/panfrost: Improve error reporting in panfrost_gpu_power_on Nicolas Boichat
2020-02-07  5:26   ` Nicolas Boichat
2020-02-07  5:26   ` Nicolas Boichat
2020-02-07  5:26   ` Nicolas Boichat
2020-02-12 10:38   ` Matthias Brugger
2020-02-12 10:38     ` Matthias Brugger
2020-02-12 10:38     ` Matthias Brugger
2020-02-12 10:38     ` Matthias Brugger
2020-02-07  5:26 ` [PATCH v4 4/7] drm/panfrost: Add support for multiple regulators Nicolas Boichat
2020-02-07  5:26   ` Nicolas Boichat
2020-02-07  5:26   ` Nicolas Boichat
2020-02-07  5:26   ` Nicolas Boichat
2020-02-10 11:31   ` Steven Price
2020-02-10 11:31     ` Steven Price
2020-02-10 11:31     ` Steven Price
2020-02-10 11:31     ` Steven Price
2020-02-10 14:00   ` Mark Brown
2020-02-10 14:00     ` Mark Brown
2020-02-10 14:00     ` Mark Brown
2020-02-10 14:00     ` Mark Brown
2020-02-07  5:26 ` [PATCH v4 5/7] drm/panfrost: Add support for multiple power domains Nicolas Boichat
2020-02-07  5:26   ` Nicolas Boichat
2020-02-07  5:26   ` Nicolas Boichat
2020-02-07  5:26   ` Nicolas Boichat
2020-02-07 13:52   ` Alyssa Rosenzweig
2020-02-07 13:52     ` Alyssa Rosenzweig
2020-02-07 13:52     ` Alyssa Rosenzweig
2020-02-07 13:52     ` Alyssa Rosenzweig
2020-02-09 12:43     ` Nicolas Boichat
2020-02-09 12:43       ` Nicolas Boichat
2020-02-09 12:43       ` Nicolas Boichat
2020-02-09 12:43       ` Nicolas Boichat
2020-02-07 14:25   ` Ulf Hansson
2020-02-07 14:25     ` Ulf Hansson
2020-02-07 14:25     ` Ulf Hansson
2020-02-07 14:25     ` Ulf Hansson
2020-02-09 12:50     ` Nicolas Boichat
2020-02-09 12:50       ` Nicolas Boichat
2020-02-09 12:50       ` Nicolas Boichat
2020-02-09 12:50       ` Nicolas Boichat
2020-02-10  7:50       ` Ulf Hansson
2020-02-10  7:50         ` Ulf Hansson
2020-02-10  7:50         ` Ulf Hansson
2020-02-10  7:50         ` Ulf Hansson
2020-02-10 11:39   ` Steven Price
2020-02-10 11:39     ` Steven Price
2020-02-10 11:39     ` Steven Price
2020-02-10 11:39     ` Steven Price
2020-02-11 19:43   ` Rob Herring
2020-02-11 19:43     ` Rob Herring
2020-02-11 19:43     ` Rob Herring
2020-02-11 19:43     ` Rob Herring
2020-02-11 20:08     ` Saravana Kannan
2020-02-11 20:08       ` Saravana Kannan
2020-02-11 20:08       ` Saravana Kannan
2020-02-11 20:08       ` Saravana Kannan
2020-02-12  1:58       ` Rob Herring
2020-02-12  1:58         ` Rob Herring
2020-02-12  1:58         ` Rob Herring
2020-02-12  1:58         ` Rob Herring
2020-02-12  2:10         ` Saravana Kannan
2020-02-12  2:10           ` Saravana Kannan
2020-02-12  2:10           ` Saravana Kannan
2020-02-12  2:10           ` Saravana Kannan
2020-02-12  2:08       ` Nicolas Boichat
2020-02-12  2:08         ` Nicolas Boichat
2020-02-12  2:08         ` Nicolas Boichat
2020-02-12  2:08         ` Nicolas Boichat
2020-02-07  5:26 ` [PATCH v4 6/7] RFC: drm/panfrost: Add mt8183-mali compatible string Nicolas Boichat
2020-02-07  5:26   ` Nicolas Boichat
2020-02-07  5:26   ` Nicolas Boichat
2020-02-07  5:26   ` Nicolas Boichat
2020-02-07  5:26 ` [PATCH v4 7/7] RFC: drm/panfrost: devfreq: Add support for 2 regulators Nicolas Boichat
2020-02-07  5:26   ` Nicolas Boichat
2020-02-07  5:26   ` Nicolas Boichat
2020-02-07  5:26   ` Nicolas Boichat
2020-02-12  8:49   ` Nicolas Boichat
2020-02-12  8:49     ` Nicolas Boichat
2020-02-12  8:49     ` Nicolas Boichat
2020-02-12  8:49     ` Nicolas Boichat
2020-02-12  9:06     ` Viresh Kumar
2020-02-12  9:06       ` Viresh Kumar
2020-02-12  9:06       ` Viresh Kumar
2020-02-12  9:06       ` Viresh Kumar
2020-02-12 18:14     ` Rob Herring
2020-02-12 18:14       ` Rob Herring
2020-02-12 18:14       ` Rob Herring
2020-02-12 18:14       ` Rob Herring
2020-02-13  7:57       ` Nicolas Boichat
2020-02-13  7:57         ` Nicolas Boichat
2020-02-13  7:57         ` Nicolas Boichat
2020-02-13  7:57         ` Nicolas Boichat
2020-02-13  8:24         ` Nicolas Boichat
2020-02-13  8:24           ` Nicolas Boichat
2020-02-13  8:24           ` Nicolas Boichat
2020-02-13  8:24           ` Nicolas Boichat
2020-02-14  1:37         ` Nick Fan (范哲維)
2020-02-14  1:37           ` Nick Fan (范哲維)
2020-03-09  1:53           ` Nicolas Boichat
2020-03-09  1:53             ` Nicolas Boichat
2020-03-09  1:53             ` Nicolas Boichat
2020-03-09  1:53             ` Nicolas Boichat
2020-02-07  6:17 ` [PATCH v4 0/7] Add dts for mt8183 GPU (and misc panfrost patches) Tomeu Vizoso
2020-02-07  6:17   ` Tomeu Vizoso
2020-02-07  6:17   ` Tomeu Vizoso
2020-02-07  6:17   ` Tomeu Vizoso
2020-02-07  7:42   ` Nicolas Boichat
2020-02-07  7:42     ` Nicolas Boichat
2020-02-07  7:42     ` Nicolas Boichat
2020-02-07  7:42     ` Nicolas Boichat
2020-02-07  8:13     ` Tomeu Vizoso
2020-02-07  8:13       ` Tomeu Vizoso
2020-02-07  8:13       ` Tomeu Vizoso
2020-02-07  8:13       ` Tomeu Vizoso
2020-02-10  3:39       ` Nicolas Boichat
2020-02-10  3:39         ` Nicolas Boichat
2020-02-10  3:39         ` Nicolas Boichat
2020-02-10  3:39         ` Nicolas Boichat
2020-02-10  8:17         ` Tomeu Vizoso
2020-02-10  8:17           ` Tomeu Vizoso
2020-02-10  8:17           ` Tomeu Vizoso
2020-02-10  8:17           ` Tomeu Vizoso
2020-02-25 20:35 ` Rob Herring
2020-02-25 20:35   ` Rob Herring
2020-02-25 20:35   ` Rob Herring
2020-02-25 20:35   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200306144336.GA9234@arm.com \
    --to=steven.price@arm.com \
    --cc=Mark.Rutland@arm.com \
    --cc=airlied@linux.ie \
    --cc=alyssa.rosenzweig@collabora.com \
    --cc=broonie@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=drinkcat@chromium.org \
    --cc=hsinyi@chromium.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=nick.fan@mediatek.com \
    --cc=robh@kernel.org \
    --cc=sj.huang@mediatek.com \
    --cc=tomeu.vizoso@collabora.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.