All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: kbuild test robot <lkp@intel.com>
Cc: Vincent Chen <vincent.chen@sifive.com>,
	kbuild-all@lists.01.org, linux-serial@vger.kernel.org
Subject: Re: [tty:tty-testing 76/89] drivers/tty/serial/sifive.c:904:19: error: 'sifive_serial_poll_get_char' undeclared here (not in a function); did you mean 'sifive_serial_clk_notifier'?
Date: Sat, 7 Mar 2020 09:52:53 +0100	[thread overview]
Message-ID: <20200307085253.GB3878075@kroah.com> (raw)
In-Reply-To: <202003062159.aGzhVVSH%lkp@intel.com>

On Fri, Mar 06, 2020 at 09:57:25PM +0800, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
> head:   8434c477300896e50907650a7476116249030b16
> commit: cc2d0148b11763808c835ec5a413620ad92fc340 [76/89] tty: serial: Add CONSOLE_POLL support to SiFive UART
> config: sh-allmodconfig (attached as .config)
> compiler: sh4-linux-gcc (GCC) 7.5.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout cc2d0148b11763808c835ec5a413620ad92fc340
>         # save the attached .config to linux build tree
>         GCC_VERSION=7.5.0 make.cross ARCH=sh 
> 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
> >> drivers/tty/serial/sifive.c:904:19: error: 'sifive_serial_poll_get_char' undeclared here (not in a function); did you mean 'sifive_serial_clk_notifier'?
>      .poll_get_char = sifive_serial_poll_get_char,
>                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>                       sifive_serial_clk_notifier
> >> drivers/tty/serial/sifive.c:905:19: error: 'sifive_serial_poll_put_char' undeclared here (not in a function); did you mean 'sifive_serial_poll_get_char'?
>      .poll_put_char = sifive_serial_poll_put_char,
>                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>                       sifive_serial_poll_get_char
> 
> vim +904 drivers/tty/serial/sifive.c
> 
>    886	
>    887	static const struct uart_ops sifive_serial_uops = {
>    888		.tx_empty	= sifive_serial_tx_empty,
>    889		.set_mctrl	= sifive_serial_set_mctrl,
>    890		.get_mctrl	= sifive_serial_get_mctrl,
>    891		.stop_tx	= sifive_serial_stop_tx,
>    892		.start_tx	= sifive_serial_start_tx,
>    893		.stop_rx	= sifive_serial_stop_rx,
>    894		.break_ctl	= sifive_serial_break_ctl,
>    895		.startup	= sifive_serial_startup,
>    896		.shutdown	= sifive_serial_shutdown,
>    897		.set_termios	= sifive_serial_set_termios,
>    898		.type		= sifive_serial_type,
>    899		.release_port	= sifive_serial_release_port,
>    900		.request_port	= sifive_serial_request_port,
>    901		.config_port	= sifive_serial_config_port,
>    902		.verify_port	= sifive_serial_verify_port,
>    903	#ifdef CONFIG_CONSOLE_POLL
>  > 904		.poll_get_char	= sifive_serial_poll_get_char,
>  > 905		.poll_put_char	= sifive_serial_poll_put_char,
>    906	#endif
>    907	};
>    908	

I'm dropping this patch from my tree now.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: kbuild-all@lists.01.org
Subject: Re: [tty:tty-testing 76/89] drivers/tty/serial/sifive.c:904:19: error: 'sifive_serial_poll_get_char' undeclared here (not in a function); did you mean 'sifive_serial_clk_notifier'?
Date: Sat, 07 Mar 2020 09:52:53 +0100	[thread overview]
Message-ID: <20200307085253.GB3878075@kroah.com> (raw)
In-Reply-To: <202003062159.aGzhVVSH%lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 2642 bytes --]

On Fri, Mar 06, 2020 at 09:57:25PM +0800, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
> head:   8434c477300896e50907650a7476116249030b16
> commit: cc2d0148b11763808c835ec5a413620ad92fc340 [76/89] tty: serial: Add CONSOLE_POLL support to SiFive UART
> config: sh-allmodconfig (attached as .config)
> compiler: sh4-linux-gcc (GCC) 7.5.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout cc2d0148b11763808c835ec5a413620ad92fc340
>         # save the attached .config to linux build tree
>         GCC_VERSION=7.5.0 make.cross ARCH=sh 
> 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
> >> drivers/tty/serial/sifive.c:904:19: error: 'sifive_serial_poll_get_char' undeclared here (not in a function); did you mean 'sifive_serial_clk_notifier'?
>      .poll_get_char = sifive_serial_poll_get_char,
>                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>                       sifive_serial_clk_notifier
> >> drivers/tty/serial/sifive.c:905:19: error: 'sifive_serial_poll_put_char' undeclared here (not in a function); did you mean 'sifive_serial_poll_get_char'?
>      .poll_put_char = sifive_serial_poll_put_char,
>                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>                       sifive_serial_poll_get_char
> 
> vim +904 drivers/tty/serial/sifive.c
> 
>    886	
>    887	static const struct uart_ops sifive_serial_uops = {
>    888		.tx_empty	= sifive_serial_tx_empty,
>    889		.set_mctrl	= sifive_serial_set_mctrl,
>    890		.get_mctrl	= sifive_serial_get_mctrl,
>    891		.stop_tx	= sifive_serial_stop_tx,
>    892		.start_tx	= sifive_serial_start_tx,
>    893		.stop_rx	= sifive_serial_stop_rx,
>    894		.break_ctl	= sifive_serial_break_ctl,
>    895		.startup	= sifive_serial_startup,
>    896		.shutdown	= sifive_serial_shutdown,
>    897		.set_termios	= sifive_serial_set_termios,
>    898		.type		= sifive_serial_type,
>    899		.release_port	= sifive_serial_release_port,
>    900		.request_port	= sifive_serial_request_port,
>    901		.config_port	= sifive_serial_config_port,
>    902		.verify_port	= sifive_serial_verify_port,
>    903	#ifdef CONFIG_CONSOLE_POLL
>  > 904		.poll_get_char	= sifive_serial_poll_get_char,
>  > 905		.poll_put_char	= sifive_serial_poll_put_char,
>    906	#endif
>    907	};
>    908	

I'm dropping this patch from my tree now.

thanks,

greg k-h

  reply	other threads:[~2020-03-07  8:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-06 13:57 [tty:tty-testing 76/89] drivers/tty/serial/sifive.c:904:19: error: 'sifive_serial_poll_get_char' undeclared here (not in a function); did you mean 'sifive_serial_clk_notifier'? kbuild test robot
2020-03-06 13:57 ` kbuild test robot
2020-03-07  8:52 ` Greg Kroah-Hartman [this message]
2020-03-07  8:52   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200307085253.GB3878075@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=vincent.chen@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.