All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v1 2/2] syscalls/settimeofday02: convert to new library
Date: Mon, 9 Mar 2020 09:28:49 +0100	[thread overview]
Message-ID: <20200309082849.GA322685@x230> (raw)
In-Reply-To: <fd1bed86-4590-cf73-a121-b9f9f0271e13@cn.fujitsu.com>

Hi Xu,

> > > +static void verify_settimeofday(unsigned int n)
> > ...
> > > +	struct tcase *tc = &tcases[n];
> > > +
> > > +	flag = 0;
> > > +	tst_res(TINFO, "%s", tc->message);
> > > +	TEST(settimeofday(&tc->tv, NULL));
> > > +	if (TST_RET != -1) {
> > > +		tst_res(TFAIL, "settimeofday() succeeded unexpectedly");
> > Maybe add TTERRNO here as well?
> Why? When run into here, settimeofyday succeeded unexpectedly, errno should
> be 0.
Correct. I'm sorry, I read != as ==.

Kind regards,
Petr

  reply	other threads:[~2020-03-09  8:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-04  8:44 [LTP] [PATCH v1 1/2] syscalls/settimeofday01: convert to new library Yang Xu
2020-03-04  8:44 ` [LTP] [PATCH v1 2/2] syscalls/settimeofday02: " Yang Xu
2020-03-09  7:47   ` Petr Vorel
2020-03-09  7:52     ` Yang Xu
2020-03-09  8:28       ` Petr Vorel [this message]
2020-03-09  8:09   ` Petr Vorel
2020-03-09  8:10     ` Yang Xu
2020-03-09  8:30       ` Petr Vorel
2020-03-09  8:01 ` [LTP] [PATCH v1 1/2] syscalls/settimeofday01: " Petr Vorel
2020-03-09  9:27   ` Yang Xu
2020-03-09 17:47     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200309082849.GA322685@x230 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.