From: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v1 1/2] syscalls/settimeofday01: convert to new library
Date: Mon, 9 Mar 2020 17:27:27 +0800 [thread overview]
Message-ID: <3752c0de-404b-4436-6807-21688d1cfd94@cn.fujitsu.com> (raw)
In-Reply-To: <20200309080134.GB299736@x230>
Hi Petr
> Hi Xu,
>> Also, since glibc 2.31[1], when tz and tv are both null, it will get
>> SIGSEGV sig. So, remove this EFAULT error test to adopt glibc 2.31.
> +1, thanks for testing on new glibc.
>
>> Moreover, musl 1.2.0 is now available and changes time_t for 32-bit
>> archs to a 64-bit type. It is updated to slove y2038 problem and get
> => typo solve.
>> time function no longer used for 32bit arch but not affecting set time
>> function and 64 bit arch, more info see[2]. So for gettimeofday(), we
>> use tst_syscall instead of calling libc to avoid this problem.
> Hm, it'd be nice to test both raw syscall and libc implementations (via
> tst_variant),
From glibc 2.31 announce,
"settimeofday itself is obsolescent according to POSIX. Programs
that set the system time should use clock_settime and/or the adjtime
family of functions instead".
This is why I am not using tst_variant for this case.
Also, glibc actually call clock_settime/gettime for this pair.
>but IMHO there is no way to detect musl change. Or am I missing
> something?
>
I remembered we have a commit for this "
syscalls: Check for time64 unsafe syscalls before using them"
Looking musl glibc code[1], can we use
__NR_gettimeofday_time32/__NR_settimeofday_time32 in syscalls.h to
detect this change?
[1]http://git.musl-libc.org/cgit/musl/commit/?id=5a105f19b5aae79dd302899e634b6b18b3dcd0d6
> + one would prefer this change to be in a separate commit, but we can live with that :).
>
> I guess there is no need to setup SAFE_{G,S}ETTIMEOFDAY(), because only these 2
> tests and stime_var.h are using it (or at least no now).
Agree. The more important reason is that get/settimeofday is obsolete,
we should use other syscall to set/get time.
Best Regards
Yang Xu
>
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
>
> Kind regards,
> Petr
>
>
next prev parent reply other threads:[~2020-03-09 9:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 8:44 [LTP] [PATCH v1 1/2] syscalls/settimeofday01: convert to new library Yang Xu
2020-03-04 8:44 ` [LTP] [PATCH v1 2/2] syscalls/settimeofday02: " Yang Xu
2020-03-09 7:47 ` Petr Vorel
2020-03-09 7:52 ` Yang Xu
2020-03-09 8:28 ` Petr Vorel
2020-03-09 8:09 ` Petr Vorel
2020-03-09 8:10 ` Yang Xu
2020-03-09 8:30 ` Petr Vorel
2020-03-09 8:01 ` [LTP] [PATCH v1 1/2] syscalls/settimeofday01: " Petr Vorel
2020-03-09 9:27 ` Yang Xu [this message]
2020-03-09 17:47 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3752c0de-404b-4436-6807-21688d1cfd94@cn.fujitsu.com \
--to=xuyang2018.jy@cn.fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.