From: Peter Zijlstra <peterz@infradead.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
kernel test robot <rong.a.chen@intel.com>,
Jann Horn <jannh@google.com>, LKML <linux-kernel@vger.kernel.org>,
x86-ml <x86@kernel.org>, Ingo Molnar <mingo@kernel.org>,
Borislav Petkov <bp@suse.de>,
lkp@lists.01.org
Subject: Re: [futex] 8019ad13ef: will-it-scale.per_process_ops -97.8% regression
Date: Mon, 9 Mar 2020 09:51:23 +0100 [thread overview]
Message-ID: <20200309085123.GE12561@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <87h7yy90ve.fsf@nanos.tec.linutronix.de>
On Sun, Mar 08, 2020 at 07:07:17PM +0100, Thomas Gleixner wrote:
> Right you are. The pointer needs to be the starting point as it moved
> ahead of word, which means it starts at word and hashes word and
> offset and an extra u32 beyond the end of the key.
>
> Thanks,
>
> tglx
> ----
> diff --git a/kernel/futex.c b/kernel/futex.c
> index e14f7cd45dbd..9f3251349f65 100644
> --- a/kernel/futex.c
> +++ b/kernel/futex.c
> @@ -385,8 +385,8 @@ static inline int hb_waiters_pending(struct futex_hash_bucket *hb)
> */
> static struct futex_hash_bucket *hash_futex(union futex_key *key)
> {
> - u32 hash = jhash2((u32*)&key->both.word,
> - (sizeof(key->both.word)+sizeof(key->both.ptr))/4,
> + u32 hash = jhash2((u32*)&key->both.ptr,
> + (sizeof(key->both.ptr) + sizeof(key->both.word)) / 4,
> key->both.offset);
> return &futex_queues[hash & (futex_hashsize - 1)];
> }
Groan... I've gotta ask, why isn't that written like:
u32 hash = jhash2((u32 *)key,
offsetof(typeof(*key), offset) / 4
key->both.offset);
Or better yet:
u32 hash = jhash((u32 *)key, sizeof(*key) / 4, 0);
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: lkp@lists.01.org
Subject: Re: [futex] 8019ad13ef: will-it-scale.per_process_ops -97.8% regression
Date: Mon, 09 Mar 2020 09:51:23 +0100 [thread overview]
Message-ID: <20200309085123.GE12561@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <87h7yy90ve.fsf@nanos.tec.linutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1154 bytes --]
On Sun, Mar 08, 2020 at 07:07:17PM +0100, Thomas Gleixner wrote:
> Right you are. The pointer needs to be the starting point as it moved
> ahead of word, which means it starts at word and hashes word and
> offset and an extra u32 beyond the end of the key.
>
> Thanks,
>
> tglx
> ----
> diff --git a/kernel/futex.c b/kernel/futex.c
> index e14f7cd45dbd..9f3251349f65 100644
> --- a/kernel/futex.c
> +++ b/kernel/futex.c
> @@ -385,8 +385,8 @@ static inline int hb_waiters_pending(struct futex_hash_bucket *hb)
> */
> static struct futex_hash_bucket *hash_futex(union futex_key *key)
> {
> - u32 hash = jhash2((u32*)&key->both.word,
> - (sizeof(key->both.word)+sizeof(key->both.ptr))/4,
> + u32 hash = jhash2((u32*)&key->both.ptr,
> + (sizeof(key->both.ptr) + sizeof(key->both.word)) / 4,
> key->both.offset);
> return &futex_queues[hash & (futex_hashsize - 1)];
> }
Groan... I've gotta ask, why isn't that written like:
u32 hash = jhash2((u32 *)key,
offsetof(typeof(*key), offset) / 4
key->both.offset);
Or better yet:
u32 hash = jhash((u32 *)key, sizeof(*key) / 4, 0);
next prev parent reply other threads:[~2020-03-09 8:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-08 14:02 [futex] 8019ad13ef: will-it-scale.per_process_ops -97.8% regression kernel test robot
2020-03-08 14:02 ` kernel test robot
2020-03-08 14:22 ` Linus Torvalds
2020-03-08 15:28 ` Linus Torvalds
2020-03-08 15:28 ` Linus Torvalds
2020-03-08 18:07 ` Thomas Gleixner
2020-03-08 18:07 ` Thomas Gleixner
2020-03-09 8:26 ` kernel test robot
2020-03-09 8:26 ` kernel test robot
2020-03-09 8:51 ` Peter Zijlstra [this message]
2020-03-09 8:51 ` Peter Zijlstra
2020-03-09 9:34 ` Thomas Gleixner
2020-03-09 9:34 ` Thomas Gleixner
2020-03-09 21:42 ` [tip: locking/urgent] futex: Unbreak futex hashing tip-bot2 for Thomas Gleixner
2020-03-11 8:20 ` [futex] 8019ad13ef: will-it-scale.per_process_ops -97.8% regression Thierry Reding
2020-03-11 8:20 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200309085123.GE12561@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bp@suse.de \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@lists.01.org \
--cc=mingo@kernel.org \
--cc=rong.a.chen@intel.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.