* A question: commented out code
@ 2020-03-08 22:44 Lourdes Pedrajas
2020-03-09 7:37 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 3+ messages in thread
From: Lourdes Pedrajas @ 2020-03-08 22:44 UTC (permalink / raw)
To: outreachy-kernel
Is removing commented out, unused code, a good cleanup patch? I'm
wondering that maybe that code is there for a reason. I checked TODO files
prior to removing that code to see if they provide a reason, but for the files
I edited, they did not.
Thank you!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] A question: commented out code
2020-03-08 22:44 A question: commented out code Lourdes Pedrajas
@ 2020-03-09 7:37 ` Julia Lawall
2020-03-09 16:40 ` Lourdes Pedrajas
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2020-03-09 7:37 UTC (permalink / raw)
To: Lourdes Pedrajas; +Cc: outreachy-kernel
On Sun, 8 Mar 2020, Lourdes Pedrajas wrote:
> Is removing commented out, unused code, a good cleanup patch? I'm
> wondering that maybe that code is there for a reason. I checked TODO files
> prior to removing that code to see if they provide a reason, but for the files
> I edited, they did not.
The general principle is that it should go. The git history is always
there, so the code is not lost forever. You can use your judgement, of
course.
julia
>
> Thank you!
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200308224412.GA14124%40supernova.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] A question: commented out code
2020-03-09 7:37 ` [Outreachy kernel] " Julia Lawall
@ 2020-03-09 16:40 ` Lourdes Pedrajas
0 siblings, 0 replies; 3+ messages in thread
From: Lourdes Pedrajas @ 2020-03-09 16:40 UTC (permalink / raw)
To: Julia Lawall; +Cc: outreachy-kernel
On Mon, Mar 09, 2020 at 08:37:26AM +0100, Julia Lawall wrote:
> On Sun, 8 Mar 2020, Lourdes Pedrajas wrote:
>
> > Is removing commented out, unused code, a good cleanup patch? I'm
> > wondering that maybe that code is there for a reason. I checked TODO files
> > prior to removing that code to see if they provide a reason, but for the files
> > I edited, they did not.
>
> The general principle is that it should go. The git history is always
> there, so the code is not lost forever. You can use your judgement, of
> course.
>
> julia
>
I agree, thank you Julia!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-09 16:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-08 22:44 A question: commented out code Lourdes Pedrajas
2020-03-09 7:37 ` [Outreachy kernel] " Julia Lawall
2020-03-09 16:40 ` Lourdes Pedrajas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.