All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] net: fec: Add possibility to enable TXC delay
@ 2020-03-09 18:38 Philippe Schenker
  2020-03-09 18:38 ` [PATCH 2/2] config: apalis-imx8: Enable FEC " Philippe Schenker
  2020-03-11  9:55 ` [PATCH 1/2] net: fec: Add possibility to enable " Oleksandr Suvorov
  0 siblings, 2 replies; 4+ messages in thread
From: Philippe Schenker @ 2020-03-09 18:38 UTC (permalink / raw)
  To: u-boot

This patch enables the possibility to set FEC_ENET_ENABLE_TXC_DELAY or
FEC_ENET_ENABLE_RXC_DELAY so one can via a define enable the RXC or TXC
delay in the MAC.

Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
---

 drivers/net/fec_mxc.c | 10 ++++++++++
 drivers/net/fec_mxc.h |  2 ++
 2 files changed, 12 insertions(+)

diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
index bc5b63d7881..345d37be4e8 100644
--- a/drivers/net/fec_mxc.c
+++ b/drivers/net/fec_mxc.c
@@ -503,6 +503,16 @@ static int fec_open(struct eth_device *edev)
 	writel(readl(&fec->eth->ecntrl) | FEC_ECNTRL_ETHER_EN,
 	       &fec->eth->ecntrl);
 
+#ifdef FEC_ENET_ENABLE_TXC_DELAY
+	writel(readl(&fec->eth->ecntrl) | FEC_ECNTRL_TXC_DLY,
+	       &fec->eth->ecntrl);
+#endif
+
+#ifdef FEC_ENET_ENABLE_RXC_DELAY
+	writel(readl(&fec->eth->ecntrl) | FEC_ECNTRL_RXC_DLY,
+	       &fec->eth->ecntrl);
+#endif
+
 #if defined(CONFIG_MX25) || defined(CONFIG_MX53) || defined(CONFIG_MX6SL)
 	udelay(100);
 
diff --git a/drivers/net/fec_mxc.h b/drivers/net/fec_mxc.h
index 159aec89679..3c8fdda2638 100644
--- a/drivers/net/fec_mxc.h
+++ b/drivers/net/fec_mxc.h
@@ -188,6 +188,8 @@ struct ethernet_regs {
 #define FEC_ECNTRL_ETHER_EN		0x00000002	/* enable the FEC */
 #define FEC_ECNTRL_SPEED		0x00000020
 #define FEC_ECNTRL_DBSWAP		0x00000100
+#define FEC_ECNTRL_TXC_DLY		0x00010000	/* TXC delayed */
+#define FEC_ECNTRL_RXC_DLY		0x00020000	/* RXC delayed */
 
 #define FEC_X_WMRK_STRFWD		0x00000100
 
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH 2/2] config: apalis-imx8: Enable FEC TXC delay
  2020-03-09 18:38 [PATCH 1/2] net: fec: Add possibility to enable TXC delay Philippe Schenker
@ 2020-03-09 18:38 ` Philippe Schenker
  2020-03-11  9:58   ` Oleksandr Suvorov
  2020-03-11  9:55 ` [PATCH 1/2] net: fec: Add possibility to enable " Oleksandr Suvorov
  1 sibling, 1 reply; 4+ messages in thread
From: Philippe Schenker @ 2020-03-09 18:38 UTC (permalink / raw)
  To: u-boot

define FEC_ENET_ENABLE_TXC_DELAY to enable the delay on TXC line on
the MAC.

Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>

---

 include/configs/apalis-imx8.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/configs/apalis-imx8.h b/include/configs/apalis-imx8.h
index bea035c3e23..40037157339 100644
--- a/include/configs/apalis-imx8.h
+++ b/include/configs/apalis-imx8.h
@@ -24,6 +24,7 @@
 
 /* Networking */
 #define FEC_QUIRK_ENET_MAC
+#define FEC_ENET_ENABLE_TXC_DELAY
 
 #define CONFIG_TFTP_TSIZE
 
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH 1/2] net: fec: Add possibility to enable TXC delay
  2020-03-09 18:38 [PATCH 1/2] net: fec: Add possibility to enable TXC delay Philippe Schenker
  2020-03-09 18:38 ` [PATCH 2/2] config: apalis-imx8: Enable FEC " Philippe Schenker
@ 2020-03-11  9:55 ` Oleksandr Suvorov
  1 sibling, 0 replies; 4+ messages in thread
From: Oleksandr Suvorov @ 2020-03-11  9:55 UTC (permalink / raw)
  To: u-boot

On Mon, Mar 9, 2020 at 8:39 PM Philippe Schenker
<philippe.schenker@toradex.com> wrote:
>
> This patch enables the possibility to set FEC_ENET_ENABLE_TXC_DELAY or
> FEC_ENET_ENABLE_RXC_DELAY so one can via a define enable the RXC or TXC
> delay in the MAC.
>
> Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>

Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>

> ---
>
>  drivers/net/fec_mxc.c | 10 ++++++++++
>  drivers/net/fec_mxc.h |  2 ++
>  2 files changed, 12 insertions(+)
>
> diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
> index bc5b63d7881..345d37be4e8 100644
> --- a/drivers/net/fec_mxc.c
> +++ b/drivers/net/fec_mxc.c
> @@ -503,6 +503,16 @@ static int fec_open(struct eth_device *edev)
>         writel(readl(&fec->eth->ecntrl) | FEC_ECNTRL_ETHER_EN,
>                &fec->eth->ecntrl);
>
> +#ifdef FEC_ENET_ENABLE_TXC_DELAY
> +       writel(readl(&fec->eth->ecntrl) | FEC_ECNTRL_TXC_DLY,
> +              &fec->eth->ecntrl);
> +#endif
> +
> +#ifdef FEC_ENET_ENABLE_RXC_DELAY
> +       writel(readl(&fec->eth->ecntrl) | FEC_ECNTRL_RXC_DLY,
> +              &fec->eth->ecntrl);
> +#endif
> +
>  #if defined(CONFIG_MX25) || defined(CONFIG_MX53) || defined(CONFIG_MX6SL)
>         udelay(100);
>
> diff --git a/drivers/net/fec_mxc.h b/drivers/net/fec_mxc.h
> index 159aec89679..3c8fdda2638 100644
> --- a/drivers/net/fec_mxc.h
> +++ b/drivers/net/fec_mxc.h
> @@ -188,6 +188,8 @@ struct ethernet_regs {
>  #define FEC_ECNTRL_ETHER_EN            0x00000002      /* enable the FEC */
>  #define FEC_ECNTRL_SPEED               0x00000020
>  #define FEC_ECNTRL_DBSWAP              0x00000100
> +#define FEC_ECNTRL_TXC_DLY             0x00010000      /* TXC delayed */
> +#define FEC_ECNTRL_RXC_DLY             0x00020000      /* RXC delayed */
>
>  #define FEC_X_WMRK_STRFWD              0x00000100
>
> --
> 2.25.1
>


-- 
Best regards

Oleksandr Suvorov
cryosay at gmail.com

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PATCH 2/2] config: apalis-imx8: Enable FEC TXC delay
  2020-03-09 18:38 ` [PATCH 2/2] config: apalis-imx8: Enable FEC " Philippe Schenker
@ 2020-03-11  9:58   ` Oleksandr Suvorov
  0 siblings, 0 replies; 4+ messages in thread
From: Oleksandr Suvorov @ 2020-03-11  9:58 UTC (permalink / raw)
  To: u-boot

On Mon, Mar 9, 2020 at 8:39 PM Philippe Schenker
<philippe.schenker@toradex.com> wrote:
>
> define FEC_ENET_ENABLE_TXC_DELAY to enable the delay on TXC line on
> the MAC.

The description doesn't explain why we enable this delay.
Could you add an explanation, please?

With that:

Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>

>
> Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
>
> ---
>
>  include/configs/apalis-imx8.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/include/configs/apalis-imx8.h b/include/configs/apalis-imx8.h
> index bea035c3e23..40037157339 100644
> --- a/include/configs/apalis-imx8.h
> +++ b/include/configs/apalis-imx8.h
> @@ -24,6 +24,7 @@
>
>  /* Networking */
>  #define FEC_QUIRK_ENET_MAC
> +#define FEC_ENET_ENABLE_TXC_DELAY
>
>  #define CONFIG_TFTP_TSIZE
>
> --
> 2.25.1
>


-- 
Best regards

Oleksandr Suvorov
cryosay at gmail.com

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-11  9:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-09 18:38 [PATCH 1/2] net: fec: Add possibility to enable TXC delay Philippe Schenker
2020-03-09 18:38 ` [PATCH 2/2] config: apalis-imx8: Enable FEC " Philippe Schenker
2020-03-11  9:58   ` Oleksandr Suvorov
2020-03-11  9:55 ` [PATCH 1/2] net: fec: Add possibility to enable " Oleksandr Suvorov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.