linux-next: build warning after merge of the pidfd-fixes tree

linux-next: build warning after merge of the pidfd-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 844 bytes --]

Hi all,

After merging the pidfd-fixes tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

In file included from include/linux/rwsem.h:18,
                 from include/linux/mm_types.h:11,
                 from include/linux/mmzone.h:21,
                 from include/linux/gfp.h:6,
                 from include/linux/mm.h:10,
                 from kernel/pid.c:30:
kernel/pid.c: In function 'alloc_pid':
include/linux/err.h:26:9: warning: 'retval' may be used uninitialized in this function [-Wmaybe-uninitialized]
   26 |  return (void *) error;
      |         ^~~~~~~~~~~~~~
kernel/pid.c:168:6: note: 'retval' was declared here
  168 |  int retval;
      |      ^~~~~~

Introduced by commit

  8deb24dcb89c ("pid: make ENOMEM return value more obvious")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the pidfd-fixes tree

[Christian Brauner]

On Tue, Mar 10, 2020 at 08:07:58AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the pidfd-fixes tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> In file included from include/linux/rwsem.h:18,
>                  from include/linux/mm_types.h:11,
>                  from include/linux/mmzone.h:21,
>                  from include/linux/gfp.h:6,
>                  from include/linux/mm.h:10,
>                  from kernel/pid.c:30:
> kernel/pid.c: In function 'alloc_pid':
> include/linux/err.h:26:9: warning: 'retval' may be used uninitialized in this function [-Wmaybe-uninitialized]
>    26 |  return (void *) error;
>       |         ^~~~~~~~~~~~~~
> kernel/pid.c:168:6: note: 'retval' was declared here
>   168 |  int retval;
>       |      ^~~~~~
> 
> Introduced by commit
> 
>   8deb24dcb89c ("pid: make ENOMEM return value more obvious")

Thanks, will fix now. Sorry for the noise!
Christian;