All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] crypto: atmel-i2c - Fix wakeup fail
@ 2020-03-10 12:25 ` Jianhui Zhao
  0 siblings, 0 replies; 4+ messages in thread
From: Jianhui Zhao @ 2020-03-10 12:25 UTC (permalink / raw)
  To: herbert
  Cc: davem, nicolas.ferre, alexandre.belloni, ludovic.desroches,
	linux-crypto, linux-arm-kernel, linux-kernel, Jianhui Zhao

The wake token cannot be sent without ignoring the nack for the
device address

Signed-off-by: Jianhui Zhao <zhaojh329@gmail.com>
---
 drivers/crypto/atmel-i2c.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/crypto/atmel-i2c.c b/drivers/crypto/atmel-i2c.c
index 1d3355913b40..e8e8281e027d 100644
--- a/drivers/crypto/atmel-i2c.c
+++ b/drivers/crypto/atmel-i2c.c
@@ -176,7 +176,8 @@ static int atmel_i2c_wakeup(struct i2c_client *client)
 	 * device is idle, asleep or during waking up. Don't check for error
 	 * when waking up the device.
 	 */
-	i2c_master_send(client, i2c_priv->wake_token, i2c_priv->wake_token_sz);
+	i2c_transfer_buffer_flags(client, i2c_priv->wake_token,
+				i2c_priv->wake_token_sz, I2C_M_IGNORE_NAK);
 
 	/*
 	 * Wait to wake the device. Typical execution times for ecdh and genkey
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v2] crypto: atmel-i2c - Fix wakeup fail
@ 2020-03-10 12:25 ` Jianhui Zhao
  0 siblings, 0 replies; 4+ messages in thread
From: Jianhui Zhao @ 2020-03-10 12:25 UTC (permalink / raw)
  To: herbert
  Cc: alexandre.belloni, linux-kernel, ludovic.desroches, Jianhui Zhao,
	linux-crypto, davem, linux-arm-kernel

The wake token cannot be sent without ignoring the nack for the
device address

Signed-off-by: Jianhui Zhao <zhaojh329@gmail.com>
---
 drivers/crypto/atmel-i2c.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/crypto/atmel-i2c.c b/drivers/crypto/atmel-i2c.c
index 1d3355913b40..e8e8281e027d 100644
--- a/drivers/crypto/atmel-i2c.c
+++ b/drivers/crypto/atmel-i2c.c
@@ -176,7 +176,8 @@ static int atmel_i2c_wakeup(struct i2c_client *client)
 	 * device is idle, asleep or during waking up. Don't check for error
 	 * when waking up the device.
 	 */
-	i2c_master_send(client, i2c_priv->wake_token, i2c_priv->wake_token_sz);
+	i2c_transfer_buffer_flags(client, i2c_priv->wake_token,
+				i2c_priv->wake_token_sz, I2C_M_IGNORE_NAK);
 
 	/*
 	 * Wait to wake the device. Typical execution times for ecdh and genkey
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] crypto: atmel-i2c - Fix wakeup fail
  2020-03-10 12:25 ` Jianhui Zhao
@ 2020-03-20  3:50   ` Herbert Xu
  -1 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2020-03-20  3:50 UTC (permalink / raw)
  To: Jianhui Zhao
  Cc: davem, nicolas.ferre, alexandre.belloni, ludovic.desroches,
	linux-crypto, linux-arm-kernel, linux-kernel

On Tue, Mar 10, 2020 at 08:25:51PM +0800, Jianhui Zhao wrote:
> The wake token cannot be sent without ignoring the nack for the
> device address
> 
> Signed-off-by: Jianhui Zhao <zhaojh329@gmail.com>
> ---
>  drivers/crypto/atmel-i2c.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] crypto: atmel-i2c - Fix wakeup fail
@ 2020-03-20  3:50   ` Herbert Xu
  0 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2020-03-20  3:50 UTC (permalink / raw)
  To: Jianhui Zhao
  Cc: alexandre.belloni, linux-kernel, ludovic.desroches, linux-crypto,
	davem, linux-arm-kernel

On Tue, Mar 10, 2020 at 08:25:51PM +0800, Jianhui Zhao wrote:
> The wake token cannot be sent without ignoring the nack for the
> device address
> 
> Signed-off-by: Jianhui Zhao <zhaojh329@gmail.com>
> ---
>  drivers/crypto/atmel-i2c.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-03-20  3:51 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-10 12:25 [PATCH v2] crypto: atmel-i2c - Fix wakeup fail Jianhui Zhao
2020-03-10 12:25 ` Jianhui Zhao
2020-03-20  3:50 ` Herbert Xu
2020-03-20  3:50   ` Herbert Xu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.