[PATCH 0/7] Cover letter

[PATCH 0/7] Cover letter

[Kaaira Gupta]

This patch set aims at improving the code style in a few drivers in
staging. They have been found using sparse, coccinelle, and
checkpatch.pl.

Re: [Outreachy kernel] [PATCH 0/7] Cover letter

[Julia Lawall]

On Tue, 10 Mar 2020, Kaaira Gupta wrote:

> This patch set aims at improving the code style in a few drivers in
> staging. They have been found using sparse, coccinelle, and
> checkpatch.pl.

A cover letter should have a more informative subject.  It's obvious that
it is a cover letter from the number of the patch being 0.

The description suggests that there is no connection between the drivers
or the changes being performed.  If that is the case, then there is no
need to make a series.

The cover letter should contain a complete diffstat of the changes made.

You should be able to find some examples on lkml.org.

julia

>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200309221449.GA5032%40kaaira-HP-Pavilion-Notebook.
>

Re: [PATCH 0/7] Cover letter

[Greg Kroah-Hartman]

On Tue, Mar 10, 2020 at 03:44:49AM +0530, Kaaira Gupta wrote:
> This patch set aims at improving the code style in a few drivers in
> staging. They have been found using sparse, coccinelle, and
> checkpatch.pl.
> 

The cover letter should be auto-generated by 'git format-patch
--cover-letter', and will contain a lot more information than just this
paragraph.

Also, I did not see all 7 patches of this series on the mailing list,
only 4 of them.  They were also not "threaded" properly, can you use
'git send-email' to resend all of these when you redo the series next?

thanks,

greg k-h

Re: [Outreachy kernel] Re: [PATCH 0/7] Cover letter

[Kaaira Gupta]

On Tue, Mar 10, 2020 at 10:06:46AM +0100, Greg Kroah-Hartman wrote:
> On Tue, Mar 10, 2020 at 03:44:49AM +0530, Kaaira Gupta wrote:
> > This patch set aims at improving the code style in a few drivers in
> > staging. They have been found using sparse, coccinelle, and
> > checkpatch.pl.
> > 
> 
> The cover letter should be auto-generated by 'git format-patch
> --cover-letter', and will contain a lot more information than just this
> paragraph.
> 
> Also, I did not see all 7 patches of this series on the mailing list,
> only 4 of them.  They were also not "threaded" properly, can you use
> 'git send-email' to resend all of these when you redo the series next?

Can you please guide me as to how I should thread the patches in a
patchset properly so that individual commits get to different patches 
and a cover-letter is generated as well. I am using mutt.

> 
> thanks,
> 
> greg k-h
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200310090646.GA2479270%40kroah.com.

Re: [Outreachy kernel] [PATCH 0/7] Cover letter

[Kaaira Gupta]

On Tue, Mar 10, 2020 at 08:15:51AM +0100, Julia Lawall wrote:
> On Tue, 10 Mar 2020, Kaaira Gupta wrote:
> 
> > This patch set aims at improving the code style in a few drivers in
> > staging. They have been found using sparse, coccinelle, and
> > checkpatch.pl.
> 
> A cover letter should have a more informative subject.  It's obvious that
> it is a cover letter from the number of the patch being 0.
> 
> The description suggests that there is no connection between the drivers
> or the changes being performed.  If that is the case, then there is no
> need to make a series.

What kind of patch sets should Ithen submit? Please guide me.

> 
> The cover letter should contain a complete diffstat of the changes made.
> 
> You should be able to find some examples on lkml.org.
> 
> julia
> 
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200309221449.GA5032%40kaaira-HP-Pavilion-Notebook.
> >

Re: [Outreachy kernel] Re: [PATCH 0/7] Cover letter

[Greg Kroah-Hartman]

On Tue, Mar 10, 2020 at 05:31:13PM +0530, Kaaira Gupta wrote:
> On Tue, Mar 10, 2020 at 10:06:46AM +0100, Greg Kroah-Hartman wrote:
> > On Tue, Mar 10, 2020 at 03:44:49AM +0530, Kaaira Gupta wrote:
> > > This patch set aims at improving the code style in a few drivers in
> > > staging. They have been found using sparse, coccinelle, and
> > > checkpatch.pl.
> > > 
> > 
> > The cover letter should be auto-generated by 'git format-patch
> > --cover-letter', and will contain a lot more information than just this
> > paragraph.
> > 
> > Also, I did not see all 7 patches of this series on the mailing list,
> > only 4 of them.  They were also not "threaded" properly, can you use
> > 'git send-email' to resend all of these when you redo the series next?
> 
> Can you please guide me as to how I should thread the patches in a
> patchset properly so that individual commits get to different patches 
> and a cover-letter is generated as well. I am using mutt.

If you use 'git send-email' you do not have to use mutt to send the
patches out.

If you are using mutt, you can send a patch series, but you have to do
it "by hand" and it's not simple to describe through email, and only
recommended if you _really_ know how to use mutt :)

thanks,

greg k-h

Re: [Outreachy kernel] Re: [PATCH 0/7] Cover letter

[Kaaira Gupta]

On Tue, Mar 10, 2020 at 01:28:52PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Mar 10, 2020 at 05:31:13PM +0530, Kaaira Gupta wrote:
> > On Tue, Mar 10, 2020 at 10:06:46AM +0100, Greg Kroah-Hartman wrote:
> > > On Tue, Mar 10, 2020 at 03:44:49AM +0530, Kaaira Gupta wrote:
> > > > This patch set aims at improving the code style in a few drivers in
> > > > staging. They have been found using sparse, coccinelle, and
> > > > checkpatch.pl.
> > > > 
> > > 
> > > The cover letter should be auto-generated by 'git format-patch
> > > --cover-letter', and will contain a lot more information than just this
> > > paragraph.
> > > 
> > > Also, I did not see all 7 patches of this series on the mailing list,
> > > only 4 of them.  They were also not "threaded" properly, can you use
> > > 'git send-email' to resend all of these when you redo the series next?
> > 
> > Can you please guide me as to how I should thread the patches in a
> > patchset properly so that individual commits get to different patches 
> > and a cover-letter is generated as well. I am using mutt.
> 
> If you use 'git send-email' you do not have to use mutt to send the
> patches out.
> 
> If you are using mutt, you can send a patch series, but you have to do
> it "by hand" and it's not simple to describe through email, and only
> recommended if you _really_ know how to use mutt :)

Okay. So just to be sure I think I should describe how I understood
`send-email` must be used, as I have been using only mutt for a month
now. I'll create individual file changes, commit them one by one,the
format a cover letter using `git format-patch --cover-letter`, then give
command `git send-email --annotate HEAD~(no of commits), and the patchet
will be generated automatically (?). I'll jest have to send them.

Thanks for the time!

> 
> thanks,
> 
> greg k-h

Re: [Outreachy kernel] Re: [PATCH 0/7] Cover letter

[Julia Lawall]

On Tue, 10 Mar 2020, Kaaira Gupta wrote:

> On Tue, Mar 10, 2020 at 01:28:52PM +0100, Greg Kroah-Hartman wrote:
> > On Tue, Mar 10, 2020 at 05:31:13PM +0530, Kaaira Gupta wrote:
> > > On Tue, Mar 10, 2020 at 10:06:46AM +0100, Greg Kroah-Hartman wrote:
> > > > On Tue, Mar 10, 2020 at 03:44:49AM +0530, Kaaira Gupta wrote:
> > > > > This patch set aims at improving the code style in a few drivers in
> > > > > staging. They have been found using sparse, coccinelle, and
> > > > > checkpatch.pl.
> > > > >
> > > >
> > > > The cover letter should be auto-generated by 'git format-patch
> > > > --cover-letter', and will contain a lot more information than just this
> > > > paragraph.
> > > >
> > > > Also, I did not see all 7 patches of this series on the mailing list,
> > > > only 4 of them.  They were also not "threaded" properly, can you use
> > > > 'git send-email' to resend all of these when you redo the series next?
> > >
> > > Can you please guide me as to how I should thread the patches in a
> > > patchset properly so that individual commits get to different patches
> > > and a cover-letter is generated as well. I am using mutt.
> >
> > If you use 'git send-email' you do not have to use mutt to send the
> > patches out.
> >
> > If you are using mutt, you can send a patch series, but you have to do
> > it "by hand" and it's not simple to describe through email, and only
> > recommended if you _really_ know how to use mutt :)
>
> Okay. So just to be sure I think I should describe how I understood
> `send-email` must be used, as I have been using only mutt for a month
> now. I'll create individual file changes, commit them one by one,the
> format a cover letter using `git format-patch --cover-letter`, then give
> command `git send-email --annotate HEAD~(no of commits), and the patchet
> will be generated automatically (?). I'll jest have to send them.

git format-patch generates them.  git send-email sends them.  But git will
need some information about how to send mail.  Search for send-email in
the tutorial.

julia


>
> Thanks for the time!
>
> >
> > thanks,
> >
> > greg k-h
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200310125424.GA22891%40kaaira-HP-Pavilion-Notebook.
>

Re: [Outreachy kernel] [PATCH 0/7] Cover letter

[Julia Lawall]

On Tue, 10 Mar 2020, Kaaira Gupta wrote:

> On Tue, Mar 10, 2020 at 08:15:51AM +0100, Julia Lawall wrote:
> > On Tue, 10 Mar 2020, Kaaira Gupta wrote:
> >
> > > This patch set aims at improving the code style in a few drivers in
> > > staging. They have been found using sparse, coccinelle, and
> > > checkpatch.pl.
> >
> > A cover letter should have a more informative subject.  It's obvious that
> > it is a cover letter from the number of the patch being 0.
> >
> > The description suggests that there is no connection between the drivers
> > or the changes being performed.  If that is the case, then there is no
> > need to make a series.
>
> What kind of patch sets should Ithen submit? Please guide me.

For one driver file perhaps you find a spelling mistake, some extra blank
lines, and a useless function definition.  These are three separate
changes, so they shoudn't be in the same patch.  But for example if the
extra blank lines are before the useless function definition, then Greg
will see the function definition being removed from the wrong place, if he
applies the patches in the wrong order.  So you need a series to indicate
the order in which the patches should be applied.

julia

>
> >
> > The cover letter should contain a complete diffstat of the changes made.
> >
> > You should be able to find some examples on lkml.org.
> >
> > julia
> >
> > >
> > > --
> > > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200309221449.GA5032%40kaaira-HP-Pavilion-Notebook.
> > >
>

Re: [Outreachy kernel] Re: [PATCH 0/7] Cover letter

[Greg Kroah-Hartman]

On Tue, Mar 10, 2020 at 06:24:24PM +0530, Kaaira Gupta wrote:
> On Tue, Mar 10, 2020 at 01:28:52PM +0100, Greg Kroah-Hartman wrote:
> > On Tue, Mar 10, 2020 at 05:31:13PM +0530, Kaaira Gupta wrote:
> > > On Tue, Mar 10, 2020 at 10:06:46AM +0100, Greg Kroah-Hartman wrote:
> > > > On Tue, Mar 10, 2020 at 03:44:49AM +0530, Kaaira Gupta wrote:
> > > > > This patch set aims at improving the code style in a few drivers in
> > > > > staging. They have been found using sparse, coccinelle, and
> > > > > checkpatch.pl.
> > > > > 
> > > > 
> > > > The cover letter should be auto-generated by 'git format-patch
> > > > --cover-letter', and will contain a lot more information than just this
> > > > paragraph.
> > > > 
> > > > Also, I did not see all 7 patches of this series on the mailing list,
> > > > only 4 of them.  They were also not "threaded" properly, can you use
> > > > 'git send-email' to resend all of these when you redo the series next?
> > > 
> > > Can you please guide me as to how I should thread the patches in a
> > > patchset properly so that individual commits get to different patches 
> > > and a cover-letter is generated as well. I am using mutt.
> > 
> > If you use 'git send-email' you do not have to use mutt to send the
> > patches out.
> > 
> > If you are using mutt, you can send a patch series, but you have to do
> > it "by hand" and it's not simple to describe through email, and only
> > recommended if you _really_ know how to use mutt :)
> 
> Okay. So just to be sure I think I should describe how I understood
> `send-email` must be used, as I have been using only mutt for a month
> now. I'll create individual file changes, commit them one by one,the
> format a cover letter using `git format-patch --cover-letter`, then give
> command `git send-email --annotate HEAD~(no of commits), and the patchet
> will be generated automatically (?). I'll jest have to send them.

Close.

Commit the individual patches as before, then run:
	git format-patch --cover-letter HEAD~(no of commits)
that will throw you in the editor to edit the cover letter, which will
end up as the 00/NN mesage.

Then, run 'git send-email *patch' (making sure that _only_ the patches
you want to send out are in the directory).  That will email everything
out properly.  Note, you do have to set up git send-email properly to
point to your mail server, instructions on how to that should be around
somewhere, or try this page:
	https://git-send-email.io/
as it will walk you through what to do to set it up.

hope this helps,

greg k-h