* [PATCH 0/2] staging: exfat: exfat_super.c: remove unused code and improve readability
@ 2020-03-10 13:33 Lourdes Pedrajas
2020-03-10 13:33 ` [PATCH 1/2] staging: vt6655: power.c: Remove setting ATIM Window in PSvEnablePowerSaving() Lourdes Pedrajas
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Lourdes Pedrajas @ 2020-03-10 13:33 UTC (permalink / raw)
To: outreachy-kernel; +Cc: forest, gregkh
Here's a set of patches that performs code cleanup in the file
drivers/staging/vt6655/power.c
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] staging: vt6655: power.c: Remove setting ATIM Window in PSvEnablePowerSaving()
2020-03-10 13:33 [PATCH 0/2] staging: exfat: exfat_super.c: remove unused code and improve readability Lourdes Pedrajas
@ 2020-03-10 13:33 ` Lourdes Pedrajas
2020-03-10 13:33 ` [PATCH 2/2] staging: exfat: exfat_super.c: code reformatting for improved readability Lourdes Pedrajas
2020-03-10 13:40 ` [PATCH 0/2] staging: exfat: exfat_super.c: remove unused code and improve readability Greg KH
2 siblings, 0 replies; 6+ messages in thread
From: Lourdes Pedrajas @ 2020-03-10 13:33 UTC (permalink / raw)
To: outreachy-kernel; +Cc: forest, gregkh
Every time priv->op_mode is not NL80211_IFTYPE_ADHOC it sets ATIM Window, but
this feature it is marked TODO in 2014 and did go untouched since 2015.
Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
---
drivers/staging/vt6655/power.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/vt6655/power.c b/drivers/staging/vt6655/power.c
index bfd598a93b04..a68ec527679a 100644
--- a/drivers/staging/vt6655/power.c
+++ b/drivers/staging/vt6655/power.c
@@ -58,11 +58,6 @@ void PSvEnablePowerSaving(struct vnt_private *priv,
if (priv->op_mode != NL80211_IFTYPE_ADHOC) {
/* set AID */
VNSvOutPortW(priv->PortOffset + MAC_REG_AIDATIM, wAID);
- } else {
- /* set ATIM Window */
-#if 0 /* TODO atim window */
- MACvWriteATIMW(priv->PortOffset, pMgmt->wCurrATIMWindow);
-#endif
}
/* Set AutoSleep */
MACvRegBitsOn(priv->PortOffset, MAC_REG_PSCFG, PSCFG_AUTOSLEEP);
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] staging: exfat: exfat_super.c: code reformatting for improved readability
2020-03-10 13:33 [PATCH 0/2] staging: exfat: exfat_super.c: remove unused code and improve readability Lourdes Pedrajas
2020-03-10 13:33 ` [PATCH 1/2] staging: vt6655: power.c: Remove setting ATIM Window in PSvEnablePowerSaving() Lourdes Pedrajas
@ 2020-03-10 13:33 ` Lourdes Pedrajas
2020-03-10 13:40 ` [PATCH 0/2] staging: exfat: exfat_super.c: remove unused code and improve readability Greg KH
2 siblings, 0 replies; 6+ messages in thread
From: Lourdes Pedrajas @ 2020-03-10 13:33 UTC (permalink / raw)
To: outreachy-kernel; +Cc: forest, gregkh
Improve line grouping for better understanding the course of action and where
every comment belongs to.
Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
---
drivers/staging/vt6655/power.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/staging/vt6655/power.c b/drivers/staging/vt6655/power.c
index a68ec527679a..6b0407694e54 100644
--- a/drivers/staging/vt6655/power.c
+++ b/drivers/staging/vt6655/power.c
@@ -59,8 +59,10 @@ void PSvEnablePowerSaving(struct vnt_private *priv,
/* set AID */
VNSvOutPortW(priv->PortOffset + MAC_REG_AIDATIM, wAID);
}
+
/* Set AutoSleep */
MACvRegBitsOn(priv->PortOffset, MAC_REG_PSCFG, PSCFG_AUTOSLEEP);
+
/* Set HWUTSF */
MACvRegBitsOn(priv->PortOffset, MAC_REG_TFTCTL, TFTCTL_HWUTSF);
@@ -96,10 +98,13 @@ void PSvDisablePowerSaving(struct vnt_private *priv)
{
/* disable power saving hw function */
MACbPSWakeup(priv);
+
/* clear AutoSleep */
MACvRegBitsOff(priv->PortOffset, MAC_REG_PSCFG, PSCFG_AUTOSLEEP);
+
/* clear HWUTSF */
MACvRegBitsOff(priv->PortOffset, MAC_REG_TFTCTL, TFTCTL_HWUTSF);
+
/* set always listen beacon */
MACvRegBitsOn(priv->PortOffset, MAC_REG_PSCTL, PSCTL_ALBCN);
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] staging: exfat: exfat_super.c: remove unused code and improve readability
2020-03-10 13:33 [PATCH 0/2] staging: exfat: exfat_super.c: remove unused code and improve readability Lourdes Pedrajas
2020-03-10 13:33 ` [PATCH 1/2] staging: vt6655: power.c: Remove setting ATIM Window in PSvEnablePowerSaving() Lourdes Pedrajas
2020-03-10 13:33 ` [PATCH 2/2] staging: exfat: exfat_super.c: code reformatting for improved readability Lourdes Pedrajas
@ 2020-03-10 13:40 ` Greg KH
2 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2020-03-10 13:40 UTC (permalink / raw)
To: Lourdes Pedrajas; +Cc: outreachy-kernel, forest
On Tue, Mar 10, 2020 at 02:33:07PM +0100, Lourdes Pedrajas wrote:
> Here's a set of patches that performs code cleanup in the file
> drivers/staging/vt6655/power.c
>
Still not using --cover-letter.
Also the subject line is very odd for the vt6655 driver :(
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] staging: exfat: exfat_super.c: code reformatting for improved readability
2020-03-10 13:28 ` [PATCH 2/2] staging: exfat: exfat_super.c: code reformatting for improved readability Lourdes Pedrajas
@ 2020-03-10 13:35 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2020-03-10 13:35 UTC (permalink / raw)
To: Lourdes Pedrajas; +Cc: outreachy-kernel, forest
On Tue, Mar 10, 2020 at 02:28:14PM +0100, Lourdes Pedrajas wrote:
> Improve line grouping for better understanding the course of action and where
> every comment belongs to.
>
> Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
> ---
> drivers/staging/vt6655/power.c | 5 +++++
> 1 file changed, 5 insertions(+)
The subject does not match the file changed :(
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] staging: exfat: exfat_super.c: code reformatting for improved readability
2020-03-10 13:28 Lourdes Pedrajas
@ 2020-03-10 13:28 ` Lourdes Pedrajas
2020-03-10 13:35 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Lourdes Pedrajas @ 2020-03-10 13:28 UTC (permalink / raw)
To: outreachy-kernel; +Cc: forest, gregkh
Improve line grouping for better understanding the course of action and where
every comment belongs to.
Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
---
drivers/staging/vt6655/power.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/staging/vt6655/power.c b/drivers/staging/vt6655/power.c
index a68ec527679a..6b0407694e54 100644
--- a/drivers/staging/vt6655/power.c
+++ b/drivers/staging/vt6655/power.c
@@ -59,8 +59,10 @@ void PSvEnablePowerSaving(struct vnt_private *priv,
/* set AID */
VNSvOutPortW(priv->PortOffset + MAC_REG_AIDATIM, wAID);
}
+
/* Set AutoSleep */
MACvRegBitsOn(priv->PortOffset, MAC_REG_PSCFG, PSCFG_AUTOSLEEP);
+
/* Set HWUTSF */
MACvRegBitsOn(priv->PortOffset, MAC_REG_TFTCTL, TFTCTL_HWUTSF);
@@ -96,10 +98,13 @@ void PSvDisablePowerSaving(struct vnt_private *priv)
{
/* disable power saving hw function */
MACbPSWakeup(priv);
+
/* clear AutoSleep */
MACvRegBitsOff(priv->PortOffset, MAC_REG_PSCFG, PSCFG_AUTOSLEEP);
+
/* clear HWUTSF */
MACvRegBitsOff(priv->PortOffset, MAC_REG_TFTCTL, TFTCTL_HWUTSF);
+
/* set always listen beacon */
MACvRegBitsOn(priv->PortOffset, MAC_REG_PSCTL, PSCTL_ALBCN);
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-03-10 13:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-10 13:33 [PATCH 0/2] staging: exfat: exfat_super.c: remove unused code and improve readability Lourdes Pedrajas
2020-03-10 13:33 ` [PATCH 1/2] staging: vt6655: power.c: Remove setting ATIM Window in PSvEnablePowerSaving() Lourdes Pedrajas
2020-03-10 13:33 ` [PATCH 2/2] staging: exfat: exfat_super.c: code reformatting for improved readability Lourdes Pedrajas
2020-03-10 13:40 ` [PATCH 0/2] staging: exfat: exfat_super.c: remove unused code and improve readability Greg KH
-- strict thread matches above, loose matches on Subject: below --
2020-03-10 13:28 Lourdes Pedrajas
2020-03-10 13:28 ` [PATCH 2/2] staging: exfat: exfat_super.c: code reformatting for improved readability Lourdes Pedrajas
2020-03-10 13:35 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.