All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: kbuild test robot <lkp@intel.com>,
	kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	kvm@vger.kernel.org, Yan Zhao <yan.y.zhao@intel.com>,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Sean Christopherson <sean.j.christopherson@intel.com>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Christophe de Dinechin <dinechin@redhat.com>,
	Lei Cao <lei.cao@stratus.com>
Subject: Re: [PATCH v5 05/14] KVM: X86: Implement ring-based dirty memory tracking
Date: Tue, 10 Mar 2020 10:09:21 -0400	[thread overview]
Message-ID: <20200310140921.GD326977@xz-x1> (raw)
In-Reply-To: <20200310022931-mutt-send-email-mst@kernel.org>

On Tue, Mar 10, 2020 at 02:31:55AM -0400, Michael S. Tsirkin wrote:
> On Mon, Mar 09, 2020 at 05:35:54PM -0400, Peter Xu wrote:
> > I'll probably also
> > move KVM_DIRTY_LOG_PAGE_OFFSET==0 definition to uapi/linux/kvm.h.
> 
> 
> IMHO KVM_DIRTY_LOG_PAGE_OFFSET is kind of pointless anyway - 
> we won't be able to move data around just by changing the
> uapi value since userspace isn't
> recompiled when kernel changes ...

Yes I think we can even drop this KVM_DIRTY_LOG_PAGE_OFFSET==0
definition.  IMHO it's only a matter of whether we would like to
directly reference this value in the common code (e.g., for kernel
virt/kvm_main.c) or we want quite a few of this instead:

#ifdef KVM_DIRTY_LOG_PAGE_OFFSET
..
#endif

I slightly prefer to not use lots of "#ifdef"s so I chose to make sure
it's defined.  However I've no strong opinion on this either. So I'm
open to change that if anyone insists with some reasons.

Thanks,

-- 
Peter Xu


WARNING: multiple messages have this Message-ID (diff)
From: Peter Xu <peterx@redhat.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v5 05/14] KVM: X86: Implement ring-based dirty memory tracking
Date: Tue, 10 Mar 2020 10:09:21 -0400	[thread overview]
Message-ID: <20200310140921.GD326977@xz-x1> (raw)
In-Reply-To: <20200310022931-mutt-send-email-mst@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 969 bytes --]

On Tue, Mar 10, 2020 at 02:31:55AM -0400, Michael S. Tsirkin wrote:
> On Mon, Mar 09, 2020 at 05:35:54PM -0400, Peter Xu wrote:
> > I'll probably also
> > move KVM_DIRTY_LOG_PAGE_OFFSET==0 definition to uapi/linux/kvm.h.
> 
> 
> IMHO KVM_DIRTY_LOG_PAGE_OFFSET is kind of pointless anyway - 
> we won't be able to move data around just by changing the
> uapi value since userspace isn't
> recompiled when kernel changes ...

Yes I think we can even drop this KVM_DIRTY_LOG_PAGE_OFFSET==0
definition.  IMHO it's only a matter of whether we would like to
directly reference this value in the common code (e.g., for kernel
virt/kvm_main.c) or we want quite a few of this instead:

#ifdef KVM_DIRTY_LOG_PAGE_OFFSET
..
#endif

I slightly prefer to not use lots of "#ifdef"s so I chose to make sure
it's defined.  However I've no strong opinion on this either. So I'm
open to change that if anyone insists with some reasons.

Thanks,

-- 
Peter Xu

  reply	other threads:[~2020-03-10 14:09 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-04 17:49 [PATCH v5 00/14] KVM: Dirty ring interface Peter Xu
2020-03-04 17:49 ` [PATCH v5 01/14] KVM: X86: Change parameter for fast_page_fault tracepoint Peter Xu
2020-03-04 17:49 ` [PATCH v5 02/14] KVM: Cache as_id in kvm_memory_slot Peter Xu
2020-03-04 17:49 ` [PATCH v5 03/14] KVM: X86: Don't track dirty for KVM_SET_[TSS_ADDR|IDENTITY_MAP_ADDR] Peter Xu
2020-03-04 17:49 ` [PATCH v5 04/14] KVM: Pass in kvm pointer into mark_page_dirty_in_slot() Peter Xu
2020-03-04 17:49 ` [PATCH v5 05/14] KVM: X86: Implement ring-based dirty memory tracking Peter Xu
2020-03-06 11:32   ` kbuild test robot
2020-03-06 11:32     ` kbuild test robot
2020-03-09 21:35     ` Peter Xu
2020-03-09 21:35       ` Peter Xu
2020-03-10  6:31       ` Michael S. Tsirkin
2020-03-10  6:31         ` Michael S. Tsirkin
2020-03-10 14:09         ` Peter Xu [this message]
2020-03-10 14:09           ` Peter Xu
2020-03-10 14:11           ` Michael S. Tsirkin
2020-03-10 14:11             ` Michael S. Tsirkin
2020-03-10 14:19             ` Peter Xu
2020-03-10 14:19               ` Peter Xu
2020-03-10 14:46               ` Michael S. Tsirkin
2020-03-10 14:46                 ` Michael S. Tsirkin
2020-03-04 17:49 ` [PATCH v5 06/14] KVM: Make dirty ring exclusive to dirty bitmap log Peter Xu
2020-03-04 17:49 ` [PATCH v5 07/14] KVM: Don't allocate dirty bitmap if dirty ring is enabled Peter Xu
2020-03-04 17:49 ` [PATCH v5 08/14] KVM: selftests: Always clear dirty bitmap after iteration Peter Xu
2020-03-04 17:49 ` [PATCH v5 09/14] KVM: selftests: Sync uapi/linux/kvm.h to tools/ Peter Xu
2020-03-04 17:49 ` [PATCH v5 10/14] KVM: selftests: Use a single binary for dirty/clear log test Peter Xu
2020-03-04 17:49 ` [PATCH v5 11/14] KVM: selftests: Introduce after_vcpu_run hook for dirty " Peter Xu
2020-03-04 17:49 ` [PATCH v5 12/14] KVM: selftests: Add dirty ring buffer test Peter Xu
2020-03-04 17:49 ` [PATCH v5 13/14] KVM: selftests: Let dirty_log_test async for dirty ring test Peter Xu
2020-03-04 17:49 ` [PATCH v5 14/14] KVM: selftests: Add "-c" parameter to dirty log test Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200310140921.GD326977@xz-x1 \
    --to=peterx@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=dinechin@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=kbuild-all@lists.01.org \
    --cc=kevin.tian@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=lei.cao@stratus.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=sean.j.christopherson@intel.com \
    --cc=vkuznets@redhat.com \
    --cc=yan.y.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.