All of lore.kernel.org
 help / color / mirror / Atom feed
* [RHEL 8.2 virt PATCH 1/3] KVM: nVMX: Don't emulate instructions in guest mode
       [not found] <20200310141152.29029-1-jmaloy@redhat.com>
@ 2020-03-10 14:11 ` Jon Maloy
  2020-03-10 14:37   ` Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: Jon Maloy @ 2020-03-10 14:11 UTC (permalink / raw)
  To: jmaloy, rhkernel-list
  Cc: Paolo Bonzini, Paul Lai, Vitaly Kuznetsov, stable, Oliver Upton

From: Paolo Bonzini <pbonzini@redhat.com>

vmx_check_intercept is not yet fully implemented. To avoid emulating
instructions disallowed by the L1 hypervisor, refuse to emulate
instructions by default.

Cc: stable@vger.kernel.org
[Made commit, added commit msg - Oliver]
Signed-off-by: Oliver Upton <oupton@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

(cherry picked from commit 07721feee46b4b248402133228235318199b05ec)
Signed-off-by: Jon Maloy <jmaloy@redhat.com>
---
 arch/x86/kvm/vmx/vmx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
index f6f98f7895bf..5e9c77c818a7 100644
--- a/arch/x86/kvm/vmx/vmx.c
+++ b/arch/x86/kvm/vmx/vmx.c
@@ -7199,7 +7199,7 @@ static int vmx_check_intercept(struct kvm_vcpu *vcpu,
 	}
 
 	/* TODO: check more intercepts... */
-	return X86EMUL_CONTINUE;
+	return X86EMUL_UNHANDLEABLE;
 }
 
 #ifdef CONFIG_X86_64
-- 
2.18.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [RHEL 8.2 virt PATCH 1/3] KVM: nVMX: Don't emulate instructions in guest mode
  2020-03-10 14:11 ` [RHEL 8.2 virt PATCH 1/3] KVM: nVMX: Don't emulate instructions in guest mode Jon Maloy
@ 2020-03-10 14:37   ` Greg KH
  0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2020-03-10 14:37 UTC (permalink / raw)
  To: Jon Maloy
  Cc: rhkernel-list, Paolo Bonzini, Paul Lai, Vitaly Kuznetsov, stable,
	Oliver Upton

On Tue, Mar 10, 2020 at 10:11:50AM -0400, Jon Maloy wrote:
> From: Paolo Bonzini <pbonzini@redhat.com>
> 
> vmx_check_intercept is not yet fully implemented. To avoid emulating
> instructions disallowed by the L1 hypervisor, refuse to emulate
> instructions by default.
> 
> Cc: stable@vger.kernel.org
> [Made commit, added commit msg - Oliver]
> Signed-off-by: Oliver Upton <oupton@google.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> 
> (cherry picked from commit 07721feee46b4b248402133228235318199b05ec)
> Signed-off-by: Jon Maloy <jmaloy@redhat.com>
> ---
>  arch/x86/kvm/vmx/vmx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Please fix your email system to not mail public people internal Red
Hat-specific things :(

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [RHEL 8.2 virt PATCH 1/3] KVM: nVMX: Don't emulate instructions in guest mode
       [not found] <20200310135743.27633-1-jmaloy@redhat.com>
@ 2020-03-10 13:57 ` Jon Maloy
  0 siblings, 0 replies; 3+ messages in thread
From: Jon Maloy @ 2020-03-10 13:57 UTC (permalink / raw)
  To: jmaloy; +Cc: Paolo Bonzini, stable, Oliver Upton

From: Paolo Bonzini <pbonzini@redhat.com>

vmx_check_intercept is not yet fully implemented. To avoid emulating
instructions disallowed by the L1 hypervisor, refuse to emulate
instructions by default.

Cc: stable@vger.kernel.org
[Made commit, added commit msg - Oliver]
Signed-off-by: Oliver Upton <oupton@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

(cherry picked from commit 07721feee46b4b248402133228235318199b05ec)
Signed-off-by: Jon Maloy <jmaloy@redhat.com>
---
 arch/x86/kvm/vmx/vmx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
index f6f98f7895bf..5e9c77c818a7 100644
--- a/arch/x86/kvm/vmx/vmx.c
+++ b/arch/x86/kvm/vmx/vmx.c
@@ -7199,7 +7199,7 @@ static int vmx_check_intercept(struct kvm_vcpu *vcpu,
 	}
 
 	/* TODO: check more intercepts... */
-	return X86EMUL_CONTINUE;
+	return X86EMUL_UNHANDLEABLE;
 }
 
 #ifdef CONFIG_X86_64
-- 
2.18.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-03-10 14:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20200310141152.29029-1-jmaloy@redhat.com>
2020-03-10 14:11 ` [RHEL 8.2 virt PATCH 1/3] KVM: nVMX: Don't emulate instructions in guest mode Jon Maloy
2020-03-10 14:37   ` Greg KH
     [not found] <20200310135743.27633-1-jmaloy@redhat.com>
2020-03-10 13:57 ` Jon Maloy

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.