All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: lucien.xin@gmail.com, netdev@vger.kernel.org,
	linux-sctp@vger.kernel.org, nhorman@tuxdriver.com,
	jere.leppanen@nokia.com, michael.tuexen@lurchi.franken.de
Subject: Re: [PATCH net] sctp: return a one-to-one type socket when doing peeloff
Date: Wed, 11 Mar 2020 00:35:52 -0300	[thread overview]
Message-ID: <20200311033552.GE2547@localhost.localdomain> (raw)
In-Reply-To: <20200309.180949.633904935953558472.davem@davemloft.net>

On Mon, Mar 09, 2020 at 06:09:49PM -0700, David Miller wrote:
> From: Xin Long <lucien.xin@gmail.com>
> Date: Mon,  2 Mar 2020 14:57:15 +0800
> 
> > As it says in rfc6458#section-9.2:
> > 
> >   The application uses the sctp_peeloff() call to branch off an
> >   association into a separate socket.  (Note that the semantics are
> >   somewhat changed from the traditional one-to-one style accept()
> >   call.)  Note also that the new socket is a one-to-one style socket.
> >   Thus, it will be confined to operations allowed for a one-to-one
> >   style socket.
> > 
> > Prior to this patch, sctp_peeloff() returned a one-to-many type socket,
> > on which some operations are not allowed, like shutdown, as Jere
> > reported.
> > 
> > This patch is to change it to return a one-to-one type socket instead.
> > 
> > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> > Reported-by: Leppanen, Jere (Nokia - FI/Espoo) <jere.leppanen@nokia.com>
> > Signed-off-by: Xin Long <lucien.xin@gmail.com>
> 
> I don't know what to do with this patch.
> 
> There seems to be some discussion about a potential alternative approach
> to the fix, but there were problems with that suggestion.
> 
> Please advise, thank you.

Please drop it. As you noticed, we do need more discussions around
it. Thanks.

WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: lucien.xin@gmail.com, netdev@vger.kernel.org,
	linux-sctp@vger.kernel.org, nhorman@tuxdriver.com,
	jere.leppanen@nokia.com, michael.tuexen@lurchi.franken.de
Subject: Re: [PATCH net] sctp: return a one-to-one type socket when doing peeloff
Date: Wed, 11 Mar 2020 03:35:52 +0000	[thread overview]
Message-ID: <20200311033552.GE2547@localhost.localdomain> (raw)
In-Reply-To: <20200309.180949.633904935953558472.davem@davemloft.net>

On Mon, Mar 09, 2020 at 06:09:49PM -0700, David Miller wrote:
> From: Xin Long <lucien.xin@gmail.com>
> Date: Mon,  2 Mar 2020 14:57:15 +0800
> 
> > As it says in rfc6458#section-9.2:
> > 
> >   The application uses the sctp_peeloff() call to branch off an
> >   association into a separate socket.  (Note that the semantics are
> >   somewhat changed from the traditional one-to-one style accept()
> >   call.)  Note also that the new socket is a one-to-one style socket.
> >   Thus, it will be confined to operations allowed for a one-to-one
> >   style socket.
> > 
> > Prior to this patch, sctp_peeloff() returned a one-to-many type socket,
> > on which some operations are not allowed, like shutdown, as Jere
> > reported.
> > 
> > This patch is to change it to return a one-to-one type socket instead.
> > 
> > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> > Reported-by: Leppanen, Jere (Nokia - FI/Espoo) <jere.leppanen@nokia.com>
> > Signed-off-by: Xin Long <lucien.xin@gmail.com>
> 
> I don't know what to do with this patch.
> 
> There seems to be some discussion about a potential alternative approach
> to the fix, but there were problems with that suggestion.
> 
> Please advise, thank you.

Please drop it. As you noticed, we do need more discussions around
it. Thanks.

  reply	other threads:[~2020-03-11  3:35 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-02  6:57 [PATCH net] sctp: return a one-to-one type socket when doing peeloff Xin Long
2020-03-02  6:57 ` Xin Long
2020-03-03 18:38 ` Leppanen, Jere (Nokia - FI/Espoo)
2020-03-03 18:38   ` Leppanen, Jere (Nokia - FI/Espoo)
2020-03-04  9:38   ` Xin Long
2020-03-04  9:38     ` Xin Long
2020-03-04 17:13     ` Jere Leppanen
2020-03-04 17:13       ` Jere Leppanen
2020-03-05 14:01       ` David Laight
2020-03-05 14:01         ` David Laight
2020-03-05 17:31         ` Jere Leppanen
2020-03-05 17:31           ` Jere Leppanen
2020-03-11  3:34       ` Marcelo Ricardo Leitner
2020-03-11  3:34         ` Marcelo Ricardo Leitner
2020-03-11 18:41         ` Jere Leppanen
2020-03-11 18:41           ` Jere Leppanen
2020-03-10  1:09 ` David Miller
2020-03-10  1:09   ` David Miller
2020-03-11  3:35   ` Marcelo Ricardo Leitner [this message]
2020-03-11  3:35     ` Marcelo Ricardo Leitner
2020-03-13  0:27 ` [sctp] 38ec705901: ltp.test_peeloff.fail kernel test robot
2020-03-13  0:27   ` kernel test robot
2020-03-13  0:27   ` [LTP] " kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200311033552.GE2547@localhost.localdomain \
    --to=marcelo.leitner@gmail.com \
    --cc=davem@davemloft.net \
    --cc=jere.leppanen@nokia.com \
    --cc=linux-sctp@vger.kernel.org \
    --cc=lucien.xin@gmail.com \
    --cc=michael.tuexen@lurchi.franken.de \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.