* [PATCH] Bluetooth: Use bt_dev_err for RPA generation failure message
@ 2020-03-09 21:48 Marcel Holtmann
2020-03-10 15:12 ` Alain Michaud
2020-03-11 8:07 ` Johan Hedberg
0 siblings, 2 replies; 3+ messages in thread
From: Marcel Holtmann @ 2020-03-09 21:48 UTC (permalink / raw)
To: linux-bluetooth
When the RPA generation fails, indicate the error with a device specifc
error message.
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
---
net/bluetooth/hci_request.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bluetooth/hci_request.c b/net/bluetooth/hci_request.c
index 2a1b64dbf76e..53179ae856ae 100644
--- a/net/bluetooth/hci_request.c
+++ b/net/bluetooth/hci_request.c
@@ -1499,7 +1499,7 @@ int hci_get_random_address(struct hci_dev *hdev, bool require_privacy,
err = smp_generate_rpa(hdev, hdev->irk, &hdev->rpa);
if (err < 0) {
- BT_ERR("%s failed to generate new RPA", hdev->name);
+ bt_dev_err(hdev, "failed to generate new RPA");
return err;
}
--
2.24.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Bluetooth: Use bt_dev_err for RPA generation failure message
2020-03-09 21:48 [PATCH] Bluetooth: Use bt_dev_err for RPA generation failure message Marcel Holtmann
@ 2020-03-10 15:12 ` Alain Michaud
2020-03-11 8:07 ` Johan Hedberg
1 sibling, 0 replies; 3+ messages in thread
From: Alain Michaud @ 2020-03-10 15:12 UTC (permalink / raw)
To: Marcel Holtmann; +Cc: BlueZ
Hi Marcel,
On Mon, Mar 9, 2020 at 5:48 PM Marcel Holtmann <marcel@holtmann.org> wrote:
>
> When the RPA generation fails, indicate the error with a device specifc
> error message.
>
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> ---
> net/bluetooth/hci_request.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bluetooth/hci_request.c b/net/bluetooth/hci_request.c
> index 2a1b64dbf76e..53179ae856ae 100644
> --- a/net/bluetooth/hci_request.c
> +++ b/net/bluetooth/hci_request.c
> @@ -1499,7 +1499,7 @@ int hci_get_random_address(struct hci_dev *hdev, bool require_privacy,
>
> err = smp_generate_rpa(hdev, hdev->irk, &hdev->rpa);
> if (err < 0) {
> - BT_ERR("%s failed to generate new RPA", hdev->name);
> + bt_dev_err(hdev, "failed to generate new RPA");
> return err;
> }
>
> --
> 2.24.1
>
LGTM.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Bluetooth: Use bt_dev_err for RPA generation failure message
2020-03-09 21:48 [PATCH] Bluetooth: Use bt_dev_err for RPA generation failure message Marcel Holtmann
2020-03-10 15:12 ` Alain Michaud
@ 2020-03-11 8:07 ` Johan Hedberg
1 sibling, 0 replies; 3+ messages in thread
From: Johan Hedberg @ 2020-03-11 8:07 UTC (permalink / raw)
To: Marcel Holtmann; +Cc: linux-bluetooth
Hi Marcel,
On Mon, Mar 09, 2020, Marcel Holtmann wrote:
> When the RPA generation fails, indicate the error with a device specifc
> error message.
>
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> ---
> net/bluetooth/hci_request.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to bluetooth-next. Thanks.
Johan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-11 8:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-09 21:48 [PATCH] Bluetooth: Use bt_dev_err for RPA generation failure message Marcel Holtmann
2020-03-10 15:12 ` Alain Michaud
2020-03-11 8:07 ` Johan Hedberg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.