From: Daniel Thompson <daniel.thompson@linaro.org>
To: kgunda@codeaurora.org
Cc: bjorn.andersson@linaro.org, jingoohan1@gmail.com,
lee.jones@linaro.org, b.zolnierkie@samsung.com,
dri-devel@lists.freedesktop.org, jacek.anaszewski@gmail.com,
pavel@ucw.cz, robh+dt@kernel.org, mark.rutland@arm.com,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Andy Gross <agross@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCH V3 2/4] backlight: qcom-wled: Add callback functions
Date: Wed, 11 Mar 2020 10:30:47 +0000 [thread overview]
Message-ID: <20200311103047.v7rt5ii3saack22a@holly.lan> (raw)
In-Reply-To: <05ab744dfbd83b6704bd394ce3c3dfc9@codeaurora.org>
On Wed, Mar 11, 2020 at 12:11:00PM +0530, kgunda@codeaurora.org wrote:
> On 2020-03-10 20:57, Daniel Thompson wrote:
> > On Mon, Mar 09, 2020 at 06:56:00PM +0530, Kiran Gunda wrote:
> > > Add cabc_config, sync_toggle, wled_ovp_fault_status and wled_ovp_delay
> > > callback functions to prepare the driver for adding WLED5 support.
> > >
> > > Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
> >
> > Overall this code would a lot easier to review if
> > > ---
> > > drivers/video/backlight/qcom-wled.c | 196
> > > +++++++++++++++++++++++-------------
> > > 1 file changed, 126 insertions(+), 70 deletions(-)
> > >
> > > diff --git a/drivers/video/backlight/qcom-wled.c
> > > b/drivers/video/backlight/qcom-wled.c
> > > index 3d276b3..b73f273 100644
> > > --- a/drivers/video/backlight/qcom-wled.c
> > > +++ b/drivers/video/backlight/qcom-wled.c
> > > @@ -128,6 +128,7 @@ struct wled_config {
> > > bool cs_out_en;
> > > bool ext_gen;
> > > bool cabc;
> > > + bool en_cabc;
> >
> > Does this ever get set to true?
> >
> Yes. If user wants use the cabc pin to control the brightness and
> use the "qcom,cabc" DT property in the device tree.
That sounds like what you intended the code to do!
Is the code that does this present in the patch? I could not find
it.
Daniel.
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Thompson <daniel.thompson@linaro.org>
To: kgunda@codeaurora.org
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
linux-fbdev@vger.kernel.org, b.zolnierkie@samsung.com,
jingoohan1@gmail.com, Andy Gross <agross@kernel.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
bjorn.andersson@linaro.org, robh+dt@kernel.org,
jacek.anaszewski@gmail.com, pavel@ucw.cz,
linux-arm-msm@vger.kernel.org, lee.jones@linaro.org,
linux-arm-msm-owner@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH V3 2/4] backlight: qcom-wled: Add callback functions
Date: Wed, 11 Mar 2020 10:30:47 +0000 [thread overview]
Message-ID: <20200311103047.v7rt5ii3saack22a@holly.lan> (raw)
In-Reply-To: <05ab744dfbd83b6704bd394ce3c3dfc9@codeaurora.org>
On Wed, Mar 11, 2020 at 12:11:00PM +0530, kgunda@codeaurora.org wrote:
> On 2020-03-10 20:57, Daniel Thompson wrote:
> > On Mon, Mar 09, 2020 at 06:56:00PM +0530, Kiran Gunda wrote:
> > > Add cabc_config, sync_toggle, wled_ovp_fault_status and wled_ovp_delay
> > > callback functions to prepare the driver for adding WLED5 support.
> > >
> > > Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
> >
> > Overall this code would a lot easier to review if
> > > ---
> > > drivers/video/backlight/qcom-wled.c | 196
> > > +++++++++++++++++++++++-------------
> > > 1 file changed, 126 insertions(+), 70 deletions(-)
> > >
> > > diff --git a/drivers/video/backlight/qcom-wled.c
> > > b/drivers/video/backlight/qcom-wled.c
> > > index 3d276b3..b73f273 100644
> > > --- a/drivers/video/backlight/qcom-wled.c
> > > +++ b/drivers/video/backlight/qcom-wled.c
> > > @@ -128,6 +128,7 @@ struct wled_config {
> > > bool cs_out_en;
> > > bool ext_gen;
> > > bool cabc;
> > > + bool en_cabc;
> >
> > Does this ever get set to true?
> >
> Yes. If user wants use the cabc pin to control the brightness and
> use the "qcom,cabc" DT property in the device tree.
That sounds like what you intended the code to do!
Is the code that does this present in the patch? I could not find
it.
Daniel.
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Thompson <daniel.thompson@linaro.org>
To: kgunda@codeaurora.org
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
linux-fbdev@vger.kernel.org, b.zolnierkie@samsung.com,
jingoohan1@gmail.com, Andy Gross <agross@kernel.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
bjorn.andersson@linaro.org, robh+dt@kernel.org,
jacek.anaszewski@gmail.com, pavel@ucw.cz,
linux-arm-msm@vger.kernel.org, lee.jones@linaro.org,
linux-arm-msm-owner@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH V3 2/4] backlight: qcom-wled: Add callback functions
Date: Wed, 11 Mar 2020 10:30:47 +0000 [thread overview]
Message-ID: <20200311103047.v7rt5ii3saack22a@holly.lan> (raw)
In-Reply-To: <05ab744dfbd83b6704bd394ce3c3dfc9@codeaurora.org>
On Wed, Mar 11, 2020 at 12:11:00PM +0530, kgunda@codeaurora.org wrote:
> On 2020-03-10 20:57, Daniel Thompson wrote:
> > On Mon, Mar 09, 2020 at 06:56:00PM +0530, Kiran Gunda wrote:
> > > Add cabc_config, sync_toggle, wled_ovp_fault_status and wled_ovp_delay
> > > callback functions to prepare the driver for adding WLED5 support.
> > >
> > > Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
> >
> > Overall this code would a lot easier to review if
> > > ---
> > > drivers/video/backlight/qcom-wled.c | 196
> > > +++++++++++++++++++++++-------------
> > > 1 file changed, 126 insertions(+), 70 deletions(-)
> > >
> > > diff --git a/drivers/video/backlight/qcom-wled.c
> > > b/drivers/video/backlight/qcom-wled.c
> > > index 3d276b3..b73f273 100644
> > > --- a/drivers/video/backlight/qcom-wled.c
> > > +++ b/drivers/video/backlight/qcom-wled.c
> > > @@ -128,6 +128,7 @@ struct wled_config {
> > > bool cs_out_en;
> > > bool ext_gen;
> > > bool cabc;
> > > + bool en_cabc;
> >
> > Does this ever get set to true?
> >
> Yes. If user wants use the cabc pin to control the brightness and
> use the "qcom,cabc" DT property in the device tree.
That sounds like what you intended the code to do!
Is the code that does this present in the patch? I could not find
it.
Daniel.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-03-11 10:30 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 13:25 [PATCH V3 0/4] Add support for WLED5 Kiran Gunda
2020-03-09 13:25 ` Kiran Gunda
2020-03-09 13:25 ` [PATCH V3 1/4] backlight: qcom-wled: convert the wled bindings to .yaml format Kiran Gunda
2020-03-09 13:25 ` Kiran Gunda
2020-03-10 15:01 ` Daniel Thompson
2020-03-10 15:01 ` Daniel Thompson
2020-03-11 7:00 ` kgunda
2020-03-11 7:00 ` kgunda
2020-03-10 18:31 ` Rob Herring
2020-03-10 18:31 ` Rob Herring
2020-03-11 7:03 ` kgunda
2020-03-11 7:03 ` kgunda
2020-03-09 13:26 ` [PATCH V3 2/4] backlight: qcom-wled: Add callback functions Kiran Gunda
2020-03-09 13:38 ` Kiran Gunda
2020-03-09 13:26 ` Kiran Gunda
2020-03-10 15:27 ` Daniel Thompson
2020-03-10 15:27 ` Daniel Thompson
2020-03-10 15:27 ` Daniel Thompson
2020-03-11 6:41 ` kgunda
2020-03-11 6:53 ` kgunda
2020-03-11 6:41 ` kgunda
2020-03-11 10:30 ` Daniel Thompson [this message]
2020-03-11 10:30 ` Daniel Thompson
2020-03-11 10:30 ` Daniel Thompson
2020-03-23 15:36 ` kgunda
2020-03-23 15:48 ` kgunda
2020-03-23 15:36 ` kgunda
2020-03-09 13:26 ` [PATCH V3 3/4] backlight: qcom-wled: Add support for WLED5 peripheral in PM8150L Kiran Gunda
2020-03-09 13:38 ` Kiran Gunda
2020-03-09 13:26 ` Kiran Gunda
2020-03-10 15:45 ` Daniel Thompson
2020-03-10 15:45 ` Daniel Thompson
2020-03-10 15:45 ` Daniel Thompson
2020-03-11 7:00 ` kgunda
2020-03-11 7:12 ` kgunda
2020-03-11 7:00 ` kgunda
2020-03-09 13:26 ` [PATCH V3 4/4] backlight: qcom-wled: Update auto calibration support for WLED5 Kiran Gunda
2020-03-09 13:38 ` Kiran Gunda
2020-03-09 13:26 ` Kiran Gunda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200311103047.v7rt5ii3saack22a@holly.lan \
--to=daniel.thompson@linaro.org \
--cc=agross@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.anaszewski@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=kgunda@codeaurora.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm-owner@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.