* [PATCH] Staging: qlge: include newline after declarations
@ 2020-03-11 14:28 Enrique Vargas
2020-03-11 15:05 ` [Outreachy kernel] " Julia Lawall
2020-03-12 8:15 ` Greg Kroah-Hartman
0 siblings, 2 replies; 4+ messages in thread
From: Enrique Vargas @ 2020-03-11 14:28 UTC (permalink / raw)
To: Manish Chopra, GR-Linux-NIC-Dev, Greg Kroah-Hartman, outreachy-kernel
Add newline following coding conventions, to eliminate WARNING found
using checkpath.
Signed-off-by: Enrique Vargas <jevargas@seas.upenn.edu>
---
drivers/staging/qlge/qlge_dbg.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
index 670361873d1d..52704c67e110 100644
--- a/drivers/staging/qlge/qlge_dbg.c
+++ b/drivers/staging/qlge/qlge_dbg.c
@@ -1332,6 +1332,7 @@ static void ql_dump_intr_states(struct ql_adapter *qdev)
{
int i;
u32 value;
+
for (i = 0; i < qdev->intr_count; i++) {
ql_write32(qdev, INTR_EN, qdev->intr_context[i].intr_read_mask);
value = ql_read32(qdev, INTR_EN);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: qlge: include newline after declarations
2020-03-11 14:28 [PATCH] Staging: qlge: include newline after declarations Enrique Vargas
@ 2020-03-11 15:05 ` Julia Lawall
2020-03-12 8:15 ` Greg Kroah-Hartman
1 sibling, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2020-03-11 15:05 UTC (permalink / raw)
To: Enrique Vargas
Cc: Manish Chopra, GR-Linux-NIC-Dev, Greg Kroah-Hartman, outreachy-kernel
On Wed, 11 Mar 2020, Enrique Vargas wrote:
> Add newline following coding conventions, to eliminate WARNING found
> using checkpath.
>
> Signed-off-by: Enrique Vargas <jevargas@seas.upenn.edu>
> ---
> drivers/staging/qlge/qlge_dbg.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
> index 670361873d1d..52704c67e110 100644
> --- a/drivers/staging/qlge/qlge_dbg.c
> +++ b/drivers/staging/qlge/qlge_dbg.c
> @@ -1332,6 +1332,7 @@ static void ql_dump_intr_states(struct ql_adapter *qdev)
> {
> int i;
> u32 value;
> +
> for (i = 0; i < qdev->intr_count; i++) {
> ql_write32(qdev, INTR_EN, qdev->intr_context[i].intr_read_mask);
> value = ql_read32(qdev, INTR_EN);
It looks better now, thanks.
Acked-by: Julia Lawall <julia.lawall@inria.fr>
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200311142836.GA17614%40evX1.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Staging: qlge: include newline after declarations
2020-03-11 14:28 [PATCH] Staging: qlge: include newline after declarations Enrique Vargas
2020-03-11 15:05 ` [Outreachy kernel] " Julia Lawall
@ 2020-03-12 8:15 ` Greg Kroah-Hartman
1 sibling, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2020-03-12 8:15 UTC (permalink / raw)
To: Enrique Vargas; +Cc: Manish Chopra, GR-Linux-NIC-Dev, outreachy-kernel
On Wed, Mar 11, 2020 at 08:28:36AM -0600, Enrique Vargas wrote:
> Add newline following coding conventions, to eliminate WARNING found
> using checkpath.
>
> Signed-off-by: Enrique Vargas <jevargas@seas.upenn.edu>
> ---
> drivers/staging/qlge/qlge_dbg.c | 1 +
> 1 file changed, 1 insertion(+)
As this is a "version 2" of the patch, you need to tell me that
somehow. Please read the submitting patches document in the kernel
Documentation directory for how to do that properly.
Please fix up and send a v3.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Staging: qlge: include newline after declarations
@ 2020-03-11 14:18 Enrique Vargas
0 siblings, 0 replies; 4+ messages in thread
From: Enrique Vargas @ 2020-03-11 14:18 UTC (permalink / raw)
To: Manish Chopra, GR-Linux-NIC-Dev, Greg Kroah-Hartman, outreachy-kernel
add newline following coding conventions
Signed-off-by: Enrique Vargas <jevargas@seas.upenn.edu>
---
drivers/staging/qlge/qlge_dbg.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
index 670361873d1d..52704c67e110 100644
--- a/drivers/staging/qlge/qlge_dbg.c
+++ b/drivers/staging/qlge/qlge_dbg.c
@@ -1332,6 +1332,7 @@ static void ql_dump_intr_states(struct ql_adapter *qdev)
{
int i;
u32 value;
+
for (i = 0; i < qdev->intr_count; i++) {
ql_write32(qdev, INTR_EN, qdev->intr_context[i].intr_read_mask);
value = ql_read32(qdev, INTR_EN);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-12 8:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-11 14:28 [PATCH] Staging: qlge: include newline after declarations Enrique Vargas
2020-03-11 15:05 ` [Outreachy kernel] " Julia Lawall
2020-03-12 8:15 ` Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2020-03-11 14:18 Enrique Vargas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.