All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: ti: k3-am65: Add clocks to dwc3 nodes
@ 2020-03-11 14:41 ` Roger Quadros
  0 siblings, 0 replies; 4+ messages in thread
From: Roger Quadros @ 2020-03-11 14:41 UTC (permalink / raw)
  To: t-kristo
  Cc: nm, d-gerlach, nsekhar, linux-arm-kernel, devicetree,
	linux-kernel, Roger Quadros, stable

From: Dave Gerlach <d-gerlach@ti.com>

The TI sci-clk driver can scan the DT for all clocks provided by system
firmware and does this by checking the clocks property of all nodes, so
we must add this to the dwc3 nodes so USB clocks are available.

Without this USB does not work with latest system firmware i.e.
[    1.714662] clk: couldn't get parent clock 0 for /interconnect@100000/dwc3@4020000

Fixes: cc54a99464ccd ("arm64: dts: ti: k3-am6: add USB suppor")
Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
Signed-off-by: Roger Quadros <rogerq@ti.com>
Cc: stable@kernel.org
---
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
index e5df20a2d2f9..d86c5c7b82fc 100644
--- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
@@ -296,6 +296,7 @@
 		interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;
 		dma-coherent;
 		power-domains = <&k3_pds 151 TI_SCI_PD_EXCLUSIVE>;
+		clocks = <&k3_clks 151 2>, <&k3_clks 151 7>;
 		assigned-clocks = <&k3_clks 151 2>, <&k3_clks 151 7>;
 		assigned-clock-parents = <&k3_clks 151 4>,	/* set REF_CLK to 20MHz i.e. PER0_PLL/48 */
 					 <&k3_clks 151 9>;	/* set PIPE3_TXB_CLK to CLK_12M_RC/256 (for HS only) */
@@ -335,6 +336,7 @@
 		interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
 		dma-coherent;
 		power-domains = <&k3_pds 152 TI_SCI_PD_EXCLUSIVE>;
+		clocks = <&k3_clks 152 2>;
 		assigned-clocks = <&k3_clks 152 2>;
 		assigned-clock-parents = <&k3_clks 152 4>;	/* set REF_CLK to 20MHz i.e. PER0_PLL/48 */
 
-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] arm64: dts: ti: k3-am65: Add clocks to dwc3 nodes
@ 2020-03-11 14:41 ` Roger Quadros
  0 siblings, 0 replies; 4+ messages in thread
From: Roger Quadros @ 2020-03-11 14:41 UTC (permalink / raw)
  To: t-kristo
  Cc: nm, devicetree, d-gerlach, nsekhar, linux-kernel, stable,
	linux-arm-kernel, Roger Quadros

From: Dave Gerlach <d-gerlach@ti.com>

The TI sci-clk driver can scan the DT for all clocks provided by system
firmware and does this by checking the clocks property of all nodes, so
we must add this to the dwc3 nodes so USB clocks are available.

Without this USB does not work with latest system firmware i.e.
[    1.714662] clk: couldn't get parent clock 0 for /interconnect@100000/dwc3@4020000

Fixes: cc54a99464ccd ("arm64: dts: ti: k3-am6: add USB suppor")
Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
Signed-off-by: Roger Quadros <rogerq@ti.com>
Cc: stable@kernel.org
---
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
index e5df20a2d2f9..d86c5c7b82fc 100644
--- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
@@ -296,6 +296,7 @@
 		interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;
 		dma-coherent;
 		power-domains = <&k3_pds 151 TI_SCI_PD_EXCLUSIVE>;
+		clocks = <&k3_clks 151 2>, <&k3_clks 151 7>;
 		assigned-clocks = <&k3_clks 151 2>, <&k3_clks 151 7>;
 		assigned-clock-parents = <&k3_clks 151 4>,	/* set REF_CLK to 20MHz i.e. PER0_PLL/48 */
 					 <&k3_clks 151 9>;	/* set PIPE3_TXB_CLK to CLK_12M_RC/256 (for HS only) */
@@ -335,6 +336,7 @@
 		interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
 		dma-coherent;
 		power-domains = <&k3_pds 152 TI_SCI_PD_EXCLUSIVE>;
+		clocks = <&k3_clks 152 2>;
 		assigned-clocks = <&k3_clks 152 2>;
 		assigned-clock-parents = <&k3_clks 152 4>;	/* set REF_CLK to 20MHz i.e. PER0_PLL/48 */
 
-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: ti: k3-am65: Add clocks to dwc3 nodes
  2020-03-11 14:41 ` Roger Quadros
@ 2020-03-20  9:07   ` Tero Kristo
  -1 siblings, 0 replies; 4+ messages in thread
From: Tero Kristo @ 2020-03-20  9:07 UTC (permalink / raw)
  To: Roger Quadros
  Cc: nm, d-gerlach, nsekhar, linux-arm-kernel, devicetree,
	linux-kernel, stable

On 11/03/2020 16:41, Roger Quadros wrote:
> From: Dave Gerlach <d-gerlach@ti.com>
> 
> The TI sci-clk driver can scan the DT for all clocks provided by system
> firmware and does this by checking the clocks property of all nodes, so
> we must add this to the dwc3 nodes so USB clocks are available.
> 
> Without this USB does not work with latest system firmware i.e.
> [    1.714662] clk: couldn't get parent clock 0 for /interconnect@100000/dwc3@4020000
> 
> Fixes: cc54a99464ccd ("arm64: dts: ti: k3-am6: add USB suppor")
> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> Cc: stable@kernel.org
> ---

Queued up towards 5.7, thanks.

-Tero

>   arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> index e5df20a2d2f9..d86c5c7b82fc 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> @@ -296,6 +296,7 @@
>   		interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;
>   		dma-coherent;
>   		power-domains = <&k3_pds 151 TI_SCI_PD_EXCLUSIVE>;
> +		clocks = <&k3_clks 151 2>, <&k3_clks 151 7>;
>   		assigned-clocks = <&k3_clks 151 2>, <&k3_clks 151 7>;
>   		assigned-clock-parents = <&k3_clks 151 4>,	/* set REF_CLK to 20MHz i.e. PER0_PLL/48 */
>   					 <&k3_clks 151 9>;	/* set PIPE3_TXB_CLK to CLK_12M_RC/256 (for HS only) */
> @@ -335,6 +336,7 @@
>   		interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
>   		dma-coherent;
>   		power-domains = <&k3_pds 152 TI_SCI_PD_EXCLUSIVE>;
> +		clocks = <&k3_clks 152 2>;
>   		assigned-clocks = <&k3_clks 152 2>;
>   		assigned-clock-parents = <&k3_clks 152 4>;	/* set REF_CLK to 20MHz i.e. PER0_PLL/48 */
>   
> 

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: ti: k3-am65: Add clocks to dwc3 nodes
@ 2020-03-20  9:07   ` Tero Kristo
  0 siblings, 0 replies; 4+ messages in thread
From: Tero Kristo @ 2020-03-20  9:07 UTC (permalink / raw)
  To: Roger Quadros
  Cc: nm, devicetree, d-gerlach, nsekhar, linux-kernel, stable,
	linux-arm-kernel

On 11/03/2020 16:41, Roger Quadros wrote:
> From: Dave Gerlach <d-gerlach@ti.com>
> 
> The TI sci-clk driver can scan the DT for all clocks provided by system
> firmware and does this by checking the clocks property of all nodes, so
> we must add this to the dwc3 nodes so USB clocks are available.
> 
> Without this USB does not work with latest system firmware i.e.
> [    1.714662] clk: couldn't get parent clock 0 for /interconnect@100000/dwc3@4020000
> 
> Fixes: cc54a99464ccd ("arm64: dts: ti: k3-am6: add USB suppor")
> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> Cc: stable@kernel.org
> ---

Queued up towards 5.7, thanks.

-Tero

>   arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> index e5df20a2d2f9..d86c5c7b82fc 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> @@ -296,6 +296,7 @@
>   		interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;
>   		dma-coherent;
>   		power-domains = <&k3_pds 151 TI_SCI_PD_EXCLUSIVE>;
> +		clocks = <&k3_clks 151 2>, <&k3_clks 151 7>;
>   		assigned-clocks = <&k3_clks 151 2>, <&k3_clks 151 7>;
>   		assigned-clock-parents = <&k3_clks 151 4>,	/* set REF_CLK to 20MHz i.e. PER0_PLL/48 */
>   					 <&k3_clks 151 9>;	/* set PIPE3_TXB_CLK to CLK_12M_RC/256 (for HS only) */
> @@ -335,6 +336,7 @@
>   		interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
>   		dma-coherent;
>   		power-domains = <&k3_pds 152 TI_SCI_PD_EXCLUSIVE>;
> +		clocks = <&k3_clks 152 2>;
>   		assigned-clocks = <&k3_clks 152 2>;
>   		assigned-clock-parents = <&k3_clks 152 4>;	/* set REF_CLK to 20MHz i.e. PER0_PLL/48 */
>   
> 

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-20  9:07 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-11 14:41 [PATCH] arm64: dts: ti: k3-am65: Add clocks to dwc3 nodes Roger Quadros
2020-03-11 14:41 ` Roger Quadros
2020-03-20  9:07 ` Tero Kristo
2020-03-20  9:07   ` Tero Kristo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.