[PATCH] weston-init: Allow use of weston without input devices

[PATCH] weston-init: Allow use of weston without input devices

[Domarys Correa]

Don't force users to have input device in your targets. As the default
option require-input is set to true, Weston only starts if we have a
device in /dev/input/event* and this not a requirement for all applications,
e.g. kiosk browser.

Signed-off-by: Domarys Correa <domarys.correa@ossystems.com.br>
---
 meta/recipes-graphics/wayland/weston-init/weston.ini | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-graphics/wayland/weston-init/weston.ini b/meta/recipes-graphics/wayland/weston-init/weston.ini
index 1eecf48bc1..1e6dff68fd 100644
--- a/meta/recipes-graphics/wayland/weston-init/weston.ini
+++ b/meta/recipes-graphics/wayland/weston-init/weston.ini
@@ -1,9 +1,10 @@
 # configuration file for Weston
 
-#[core]
+[core]
 #modules=xwayland.so,cms-colord.so
 #shell=desktop-shell.so
 #gbm-format=xrgb2101010
+require-input=false
 
 #[shell]
 #background-image=/usr/share/backgrounds/gnome/Aqua.jpg
-- 
2.17.1

Re: [PATCH] weston-init: Allow use of weston without input devices

[Alexander Kanavin]

[-- Attachment #1: Type: text/plain, Size: 1506 bytes --]

I do not think we should be overriding upstream defaults like this. If your
use case is different, you can always provide a custom weston.ini through a
bbappend.

Alex

On Wed, 11 Mar 2020 at 17:52, Domarys Correa <
domarys.correa@ossystems.com.br> wrote:

> Don't force users to have input device in your targets. As the default
> option require-input is set to true, Weston only starts if we have a
> device in /dev/input/event* and this not a requirement for all
> applications,
> e.g. kiosk browser.
>
> Signed-off-by: Domarys Correa <domarys.correa@ossystems.com.br>
> ---
>  meta/recipes-graphics/wayland/weston-init/weston.ini | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-graphics/wayland/weston-init/weston.ini
> b/meta/recipes-graphics/wayland/weston-init/weston.ini
> index 1eecf48bc1..1e6dff68fd 100644
> --- a/meta/recipes-graphics/wayland/weston-init/weston.ini
> +++ b/meta/recipes-graphics/wayland/weston-init/weston.ini
> @@ -1,9 +1,10 @@
>  # configuration file for Weston
>
> -#[core]
> +[core]
>  #modules=xwayland.so,cms-colord.so
>  #shell=desktop-shell.so
>  #gbm-format=xrgb2101010
> +require-input=false
>
>  #[shell]
>  #background-image=/usr/share/backgrounds/gnome/Aqua.jpg
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 2169 bytes --]

Re: [PATCH] weston-init: Allow use of weston without input devices

[Otavio Salvador]

Hello Alex,

On Wed, Mar 11, 2020 at 2:22 PM Alexander Kanavin
<alex.kanavin@gmail.com> wrote:
> I do not think we should be overriding upstream defaults like this. If your use case is different, you can always provide a custom weston.ini through a bbappend.

I'd like to argue why, in this case, it makes sense.

The weston is getting more and more adoption and often we use it on
devices that do not have keyboard and mouse connected. The default
configuration file, on OE-Core, should be adequate for common use
cases as we see on embedded devices and failing to start just because
we lack input devices is far from user-friendly.

We do have a bbappend our multiple customer layers and as it has
become common we'd like to upstream it as we used quite some time to
understand why it was failing when we first faced it.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750

Re: [PATCH] weston-init: Allow use of weston without input devices

[Alexander Kanavin]

[-- Attachment #1: Type: text/plain, Size: 1439 bytes --]

But shouldn’t you take it all the way upstream then and change the default
there? My concern is that we currently ship a blank configuration and rely
on defaults and auto-discovery; I wouldn’t want to erode that with all
sorts of customizations.

Alex

On Wed 11. Mar 2020 at 19.19, Otavio Salvador <
otavio.salvador@ossystems.com.br> wrote:

> Hello Alex,
>
> On Wed, Mar 11, 2020 at 2:22 PM Alexander Kanavin
> <alex.kanavin@gmail.com> wrote:
> > I do not think we should be overriding upstream defaults like this. If
> your use case is different, you can always provide a custom weston.ini
> through a bbappend.
>
> I'd like to argue why, in this case, it makes sense.
>
> The weston is getting more and more adoption and often we use it on
> devices that do not have keyboard and mouse connected. The default
> configuration file, on OE-Core, should be adequate for common use
> cases as we see on embedded devices and failing to start just because
> we lack input devices is far from user-friendly.
>
> We do have a bbappend our multiple customer layers and as it has
> become common we'd like to upstream it as we used quite some time to
> understand why it was failing when we first faced it.
>
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750
>

[-- Attachment #2: Type: text/html, Size: 2063 bytes --]

Re: [PATCH] weston-init: Allow use of weston without input devices

[Khem Raj]

Hi Alex

On 3/11/20 10:22 AM, Alexander Kanavin wrote:
> I do not think we should be overriding upstream defaults like this. If 
> your use case is different, you can always provide a custom weston.ini 
> through a bbappend.
> 

I share your sentiments and we should be vigilant, however in this case 
I think it makes sense especially when we are doing testing on remote 
units or emulators on server farms which may have no input devices 
connected. I filed a bug recently on YP bugzilla [1] which is very 
related to what this patch it fixing. In embedded case I think its more 
common to not have attached input devices

[1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=13828