* [hch-block:remove-dma-mask-indirection 2/2] drivers/eisa/pci_eisa.c:56:32: error: 'struct pci_dev' has no member named 'dma_mask'
@ 2020-03-11 21:27 kbuild test robot
2020-03-11 22:51 ` Li, Philip
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2020-03-11 21:27 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 4983 bytes --]
tree: git://git.infradead.org/users/hch/block.git remove-dma-mask-indirection
head: 7f0f0d04b7c2d957bee8220cf37362ed7b956a3b
commit: 7f0f0d04b7c2d957bee8220cf37362ed7b956a3b [2/2] device.h: make dma_mask a scalar instead of a pointer
config: x86_64-randconfig-s2-20200311 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.2-10+deb8u1) 4.9.2
reproduce:
git checkout 7f0f0d04b7c2d957bee8220cf37362ed7b956a3b
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/eisa/pci_eisa.c: In function 'pci_eisa_init':
>> drivers/eisa/pci_eisa.c:56:32: error: 'struct pci_dev' has no member named 'dma_mask'
pci_eisa_root.dma_mask = pdev->dma_mask;
^
vim +56 drivers/eisa/pci_eisa.c
^1da177e4c3f415 Linus Torvalds 2005-04-16 20
c5fb301ae83bec6 Yinghai Lu 2013-03-27 21 static int __init pci_eisa_init(struct pci_dev *pdev)
^1da177e4c3f415 Linus Torvalds 2005-04-16 22 {
2cfda637e29ce9e Yinghai Lu 2013-04-01 23 int rc, i;
2cfda637e29ce9e Yinghai Lu 2013-04-01 24 struct resource *res, *bus_res = NULL;
^1da177e4c3f415 Linus Torvalds 2005-04-16 25
^1da177e4c3f415 Linus Torvalds 2005-04-16 26 if ((rc = pci_enable_device (pdev))) {
4cf9f24db3954ac Bjorn Helgaas 2013-04-15 27 dev_err(&pdev->dev, "Could not enable device\n");
^1da177e4c3f415 Linus Torvalds 2005-04-16 28 return rc;
^1da177e4c3f415 Linus Torvalds 2005-04-16 29 }
^1da177e4c3f415 Linus Torvalds 2005-04-16 30
2cfda637e29ce9e Yinghai Lu 2013-04-01 31 /*
2cfda637e29ce9e Yinghai Lu 2013-04-01 32 * The Intel 82375 PCI-EISA bridge is a subtractive-decode PCI
2cfda637e29ce9e Yinghai Lu 2013-04-01 33 * device, so the resources available on EISA are the same as those
2cfda637e29ce9e Yinghai Lu 2013-04-01 34 * available on the 82375 bus. This works the same as a PCI-PCI
2cfda637e29ce9e Yinghai Lu 2013-04-01 35 * bridge in subtractive-decode mode (see pci_read_bridge_bases()).
2cfda637e29ce9e Yinghai Lu 2013-04-01 36 * We assume other PCI-EISA bridges are similar.
2cfda637e29ce9e Yinghai Lu 2013-04-01 37 *
2cfda637e29ce9e Yinghai Lu 2013-04-01 38 * eisa_root_register() can only deal with a single io port resource,
2cfda637e29ce9e Yinghai Lu 2013-04-01 39 * so we use the first valid io port resource.
2cfda637e29ce9e Yinghai Lu 2013-04-01 40 */
2cfda637e29ce9e Yinghai Lu 2013-04-01 41 pci_bus_for_each_resource(pdev->bus, res, i)
2cfda637e29ce9e Yinghai Lu 2013-04-01 42 if (res && (res->flags & IORESOURCE_IO)) {
2cfda637e29ce9e Yinghai Lu 2013-04-01 43 bus_res = res;
2cfda637e29ce9e Yinghai Lu 2013-04-01 44 break;
2cfda637e29ce9e Yinghai Lu 2013-04-01 45 }
2cfda637e29ce9e Yinghai Lu 2013-04-01 46
2cfda637e29ce9e Yinghai Lu 2013-04-01 47 if (!bus_res) {
2cfda637e29ce9e Yinghai Lu 2013-04-01 48 dev_err(&pdev->dev, "No resources available\n");
2cfda637e29ce9e Yinghai Lu 2013-04-01 49 return -1;
2cfda637e29ce9e Yinghai Lu 2013-04-01 50 }
2cfda637e29ce9e Yinghai Lu 2013-04-01 51
^1da177e4c3f415 Linus Torvalds 2005-04-16 52 pci_eisa_root.dev = &pdev->dev;
2cfda637e29ce9e Yinghai Lu 2013-04-01 53 pci_eisa_root.res = bus_res;
2cfda637e29ce9e Yinghai Lu 2013-04-01 54 pci_eisa_root.bus_base_addr = bus_res->start;
^1da177e4c3f415 Linus Torvalds 2005-04-16 55 pci_eisa_root.slots = EISA_MAX_SLOTS;
^1da177e4c3f415 Linus Torvalds 2005-04-16 @56 pci_eisa_root.dma_mask = pdev->dma_mask;
4b9d0d3b81ec090 Greg Kroah-Hartman 2009-04-30 57 dev_set_drvdata(pci_eisa_root.dev, &pci_eisa_root);
^1da177e4c3f415 Linus Torvalds 2005-04-16 58
^1da177e4c3f415 Linus Torvalds 2005-04-16 59 if (eisa_root_register (&pci_eisa_root)) {
4cf9f24db3954ac Bjorn Helgaas 2013-04-15 60 dev_err(&pdev->dev, "Could not register EISA root\n");
^1da177e4c3f415 Linus Torvalds 2005-04-16 61 return -1;
^1da177e4c3f415 Linus Torvalds 2005-04-16 62 }
^1da177e4c3f415 Linus Torvalds 2005-04-16 63
^1da177e4c3f415 Linus Torvalds 2005-04-16 64 return 0;
^1da177e4c3f415 Linus Torvalds 2005-04-16 65 }
^1da177e4c3f415 Linus Torvalds 2005-04-16 66
:::::: The code at line 56 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34196 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [hch-block:remove-dma-mask-indirection 2/2] drivers/eisa/pci_eisa.c:56:32: error: 'struct pci_dev' has no member named 'dma_mask'
2020-03-11 21:27 [hch-block:remove-dma-mask-indirection 2/2] drivers/eisa/pci_eisa.c:56:32: error: 'struct pci_dev' has no member named 'dma_mask' kbuild test robot
@ 2020-03-11 22:51 ` Li, Philip
2020-03-12 7:30 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Li, Philip @ 2020-03-11 22:51 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 5626 bytes --]
> Subject: [kbuild-all] [hch-block:remove-dma-mask-indirection 2/2]
> drivers/eisa/pci_eisa.c:56:32: error: 'struct pci_dev' has no member named
> 'dma_mask'
Hi Christoph, there're multiple duplicated reports against this commit, which
should be a problem in our side for this number of similar reports. The error
is invalid, and we will check the report side to reduce the number of similar
reports.
Thanks
>
> tree: git://git.infradead.org/users/hch/block.git remove-dma-mask-indirection
> head: 7f0f0d04b7c2d957bee8220cf37362ed7b956a3b
> commit: 7f0f0d04b7c2d957bee8220cf37362ed7b956a3b [2/2] device.h: make
> dma_mask a scalar instead of a pointer
> config: x86_64-randconfig-s2-20200311 (attached as .config)
> compiler: gcc-4.9 (Debian 4.9.2-10+deb8u1) 4.9.2
> reproduce:
> git checkout 7f0f0d04b7c2d957bee8220cf37362ed7b956a3b
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> drivers/eisa/pci_eisa.c: In function 'pci_eisa_init':
> >> drivers/eisa/pci_eisa.c:56:32: error: 'struct pci_dev' has no member named
> 'dma_mask'
> pci_eisa_root.dma_mask = pdev->dma_mask;
> ^
>
> vim +56 drivers/eisa/pci_eisa.c
>
> ^1da177e4c3f415 Linus Torvalds 2005-04-16 20
> c5fb301ae83bec6 Yinghai Lu 2013-03-27 21 static int __init
> pci_eisa_init(struct pci_dev *pdev)
> ^1da177e4c3f415 Linus Torvalds 2005-04-16 22 {
> 2cfda637e29ce9e Yinghai Lu 2013-04-01 23 int rc, i;
> 2cfda637e29ce9e Yinghai Lu 2013-04-01 24 struct resource *res,
> *bus_res = NULL;
> ^1da177e4c3f415 Linus Torvalds 2005-04-16 25
> ^1da177e4c3f415 Linus Torvalds 2005-04-16 26 if ((rc =
> pci_enable_device (pdev))) {
> 4cf9f24db3954ac Bjorn Helgaas 2013-04-15 27 dev_err(&pdev-
> >dev, "Could not enable device\n");
> ^1da177e4c3f415 Linus Torvalds 2005-04-16 28 return rc;
> ^1da177e4c3f415 Linus Torvalds 2005-04-16 29 }
> ^1da177e4c3f415 Linus Torvalds 2005-04-16 30
> 2cfda637e29ce9e Yinghai Lu 2013-04-01 31 /*
> 2cfda637e29ce9e Yinghai Lu 2013-04-01 32 * The Intel 82375 PCI-
> EISA bridge is a subtractive-decode PCI
> 2cfda637e29ce9e Yinghai Lu 2013-04-01 33 * device, so the
> resources available on EISA are the same as those
> 2cfda637e29ce9e Yinghai Lu 2013-04-01 34 * available on the 82375
> bus. This works the same as a PCI-PCI
> 2cfda637e29ce9e Yinghai Lu 2013-04-01 35 * bridge in subtractive-
> decode mode (see pci_read_bridge_bases()).
> 2cfda637e29ce9e Yinghai Lu 2013-04-01 36 * We assume other PCI-
> EISA bridges are similar.
> 2cfda637e29ce9e Yinghai Lu 2013-04-01 37 *
> 2cfda637e29ce9e Yinghai Lu 2013-04-01 38 * eisa_root_register() can
> only deal with a single io port resource,
> 2cfda637e29ce9e Yinghai Lu 2013-04-01 39 * so we use the first valid
> io port resource.
> 2cfda637e29ce9e Yinghai Lu 2013-04-01 40 */
> 2cfda637e29ce9e Yinghai Lu 2013-04-01 41
> pci_bus_for_each_resource(pdev->bus, res, i)
> 2cfda637e29ce9e Yinghai Lu 2013-04-01 42 if (res && (res-
> >flags & IORESOURCE_IO)) {
> 2cfda637e29ce9e Yinghai Lu 2013-04-01 43 bus_res =
> res;
> 2cfda637e29ce9e Yinghai Lu 2013-04-01 44 break;
> 2cfda637e29ce9e Yinghai Lu 2013-04-01 45 }
> 2cfda637e29ce9e Yinghai Lu 2013-04-01 46
> 2cfda637e29ce9e Yinghai Lu 2013-04-01 47 if (!bus_res) {
> 2cfda637e29ce9e Yinghai Lu 2013-04-01 48 dev_err(&pdev-
> >dev, "No resources available\n");
> 2cfda637e29ce9e Yinghai Lu 2013-04-01 49 return -1;
> 2cfda637e29ce9e Yinghai Lu 2013-04-01 50 }
> 2cfda637e29ce9e Yinghai Lu 2013-04-01 51
> ^1da177e4c3f415 Linus Torvalds 2005-04-16 52 pci_eisa_root.dev
> = &pdev->dev;
> 2cfda637e29ce9e Yinghai Lu 2013-04-01 53 pci_eisa_root.res
> = bus_res;
> 2cfda637e29ce9e Yinghai Lu 2013-04-01 54
> pci_eisa_root.bus_base_addr = bus_res->start;
> ^1da177e4c3f415 Linus Torvalds 2005-04-16 55 pci_eisa_root.slots
> = EISA_MAX_SLOTS;
> ^1da177e4c3f415 Linus Torvalds 2005-04-16 @56 pci_eisa_root.dma_mask
> = pdev->dma_mask;
> 4b9d0d3b81ec090 Greg Kroah-Hartman 2009-04-30 57
> dev_set_drvdata(pci_eisa_root.dev, &pci_eisa_root);
> ^1da177e4c3f415 Linus Torvalds 2005-04-16 58
> ^1da177e4c3f415 Linus Torvalds 2005-04-16 59 if (eisa_root_register
> (&pci_eisa_root)) {
> 4cf9f24db3954ac Bjorn Helgaas 2013-04-15 60 dev_err(&pdev-
> >dev, "Could not register EISA root\n");
> ^1da177e4c3f415 Linus Torvalds 2005-04-16 61 return -1;
> ^1da177e4c3f415 Linus Torvalds 2005-04-16 62 }
> ^1da177e4c3f415 Linus Torvalds 2005-04-16 63
> ^1da177e4c3f415 Linus Torvalds 2005-04-16 64 return 0;
> ^1da177e4c3f415 Linus Torvalds 2005-04-16 65 }
> ^1da177e4c3f415 Linus Torvalds 2005-04-16 66
>
> :::::: The code at line 56 was first introduced by commit
> :::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
>
> :::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
> :::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [hch-block:remove-dma-mask-indirection 2/2] drivers/eisa/pci_eisa.c:56:32: error: 'struct pci_dev' has no member named 'dma_mask'
2020-03-11 22:51 ` Li, Philip
@ 2020-03-12 7:30 ` Christoph Hellwig
0 siblings, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2020-03-12 7:30 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 737 bytes --]
On Wed, Mar 11, 2020 at 10:51:40PM +0000, Li, Philip wrote:
> > Subject: [kbuild-all] [hch-block:remove-dma-mask-indirection 2/2]
> > drivers/eisa/pci_eisa.c:56:32: error: 'struct pci_dev' has no member named
> > 'dma_mask'
> Hi Christoph, there're multiple duplicated reports against this commit, which
> should be a problem in our side for this number of similar reports. The error
> is invalid, and we will check the report side to reduce the number of similar
> reports.
The error is valid - the field is removed in this commit. I sent
this out as a test after my local defconfig worked, but there is obviously
a lot of work in drivers that have been violating abstraactions all the
time.
But thanks for the headsup!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-12 7:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-11 21:27 [hch-block:remove-dma-mask-indirection 2/2] drivers/eisa/pci_eisa.c:56:32: error: 'struct pci_dev' has no member named 'dma_mask' kbuild test robot
2020-03-11 22:51 ` Li, Philip
2020-03-12 7:30 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.