All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: rtl8712: Fixes for simple typos in C comments
@ 2020-03-12  9:10 R Veera Kumar
  2020-03-15 20:29 ` [Outreachy kernel] " Stefano Brivio
  0 siblings, 1 reply; 4+ messages in thread
From: R Veera Kumar @ 2020-03-12  9:10 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Larry Finger, Florian Schilhabel, outreachy-kernel

Fixes for simple typos in C comments.
Found using checkpatch.pl.

Signed-off-by: R Veera Kumar <vkor@vkten.in>
---
 drivers/staging/rtl8712/rtl871x_cmd.h  | 2 +-
 drivers/staging/rtl8712/rtl871x_recv.h | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
index 98d7fbfce1a5..254182a6ce8e 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.h
+++ b/drivers/staging/rtl8712/rtl871x_cmd.h
@@ -478,7 +478,7 @@ struct drvint_cmd_parm {
 	unsigned char *pbuf;
 };
 
-/*------------------- Below are used for RF/BB tunning ---------------------*/
+/*------------------- Below are used for RF/BB tuning ---------------------*/
 
 struct	setantenna_parm {
 	u8	tx_antset;
diff --git a/drivers/staging/rtl8712/rtl871x_recv.h b/drivers/staging/rtl8712/rtl871x_recv.h
index 0146a774e19d..e93f356ed2b0 100644
--- a/drivers/staging/rtl8712/rtl871x_recv.h
+++ b/drivers/staging/rtl8712/rtl871x_recv.h
@@ -53,7 +53,7 @@ struct rx_pkt_attrib {
 	u8	privacy; /* in frame_ctrl field */
 	u8	bdecrypted;
 	int	hdrlen;	 /* the WLAN Header Len */
-	int	encrypt; /* 0 no encrypt. != 0 encrypt algorith */
+	int	encrypt; /* 0 no encrypt. != 0 encrypt algorithm */
 	int	iv_len;
 	int	icv_len;
 	int	priority;
@@ -105,7 +105,7 @@ struct recv_priv {
 	u8 *precv_buf;    /* 4 alignment */
 	struct  __queue	free_recv_buf_queue;
 	u32	free_recv_buf_queue_cnt;
-	/* For the phy informatiom */
+	/* For the phy information */
 	s8 rssi;
 	u8 signal;
 	u8 noise;
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Outreachy kernel] [PATCH] staging: rtl8712: Fixes for simple typos in C comments
  2020-03-12  9:10 [PATCH] staging: rtl8712: Fixes for simple typos in C comments R Veera Kumar
@ 2020-03-15 20:29 ` Stefano Brivio
  2020-03-16  1:27   ` R Veera Kumar
  0 siblings, 1 reply; 4+ messages in thread
From: Stefano Brivio @ 2020-03-15 20:29 UTC (permalink / raw)
  To: R Veera Kumar
  Cc: Greg Kroah-Hartman, Larry Finger, Florian Schilhabel, outreachy-kernel

Hi,

On Thu, 12 Mar 2020 14:40:48 +0530
R Veera Kumar <vkor@vkten.in> wrote:

> Fixes for simple typos in C comments.
> Found using checkpatch.pl.

This looks good to me, except for the same points Julia had on your
patch:
	"[Outreachy kernel] [PATCH] staging: rts5208: Fix long line in C func call argument"

Can you please fix that up (title and description) and resend?

-- 
Stefano



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Outreachy kernel] [PATCH] staging: rtl8712: Fixes for simple typos in C comments
  2020-03-15 20:29 ` [Outreachy kernel] " Stefano Brivio
@ 2020-03-16  1:27   ` R Veera Kumar
  2020-03-16  9:07     ` Julia Lawall
  0 siblings, 1 reply; 4+ messages in thread
From: R Veera Kumar @ 2020-03-16  1:27 UTC (permalink / raw)
  To: Stefano Brivio
  Cc: Greg Kroah-Hartman, Larry Finger, Florian Schilhabel, outreachy-kernel

On Sun, Mar 15, 2020 at 09:29:01PM +0100, Stefano Brivio wrote:
> Hi,
> 
> On Thu, 12 Mar 2020 14:40:48 +0530
> R Veera Kumar <vkor@vkten.in> wrote:
> 
> > Fixes for simple typos in C comments.
> > Found using checkpatch.pl.
> 
> This looks good to me, except for the same points Julia had on your
> patch:
> 	"[Outreachy kernel] [PATCH] staging: rts5208: Fix long line in C func call argument"
> 
> Can you please fix that up (title and description) and resend?
> 

But, this patch has already been accepted by Greg KH and is in
staging-testing and staging-next branch. May be late.

Regards,
Veera

> -- 
> Stefano
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Outreachy kernel] [PATCH] staging: rtl8712: Fixes for simple typos in C comments
  2020-03-16  1:27   ` R Veera Kumar
@ 2020-03-16  9:07     ` Julia Lawall
  0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2020-03-16  9:07 UTC (permalink / raw)
  To: R Veera Kumar
  Cc: Stefano Brivio, Greg Kroah-Hartman, Larry Finger,
	Florian Schilhabel, outreachy-kernel



On Mon, 16 Mar 2020, R Veera Kumar wrote:

> On Sun, Mar 15, 2020 at 09:29:01PM +0100, Stefano Brivio wrote:
> > Hi,
> >
> > On Thu, 12 Mar 2020 14:40:48 +0530
> > R Veera Kumar <vkor@vkten.in> wrote:
> >
> > > Fixes for simple typos in C comments.
> > > Found using checkpatch.pl.
> >
> > This looks good to me, except for the same points Julia had on your
> > patch:
> > 	"[Outreachy kernel] [PATCH] staging: rts5208: Fix long line in C func call argument"
> >
> > Can you please fix that up (title and description) and resend?
> >
>
> But, this patch has already been accepted by Greg KH and is in
> staging-testing and staging-next branch. May be late.

Yes, you can let it go.

julia


>
> Regards,
> Veera
>
> > --
> > Stefano
> >
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200316012751.GA608%40tulip.local.
>


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-03-16  9:07 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-12  9:10 [PATCH] staging: rtl8712: Fixes for simple typos in C comments R Veera Kumar
2020-03-15 20:29 ` [Outreachy kernel] " Stefano Brivio
2020-03-16  1:27   ` R Veera Kumar
2020-03-16  9:07     ` Julia Lawall

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.