[PATCH v5] staging: rtl8192u: r8192U_wx: use netdev_warn() instead of printk()

[PATCH v5] staging: rtl8192u: r8192U_wx: use netdev_warn() instead of printk()

[Lourdes Pedrajas]

printk() is deprecated, use netdev_warn() instead, which is a message printing
function specific for network devices defined in include/linux/netdevice.h.
Issue found by checkpatch.

Suggested-by: Julia Lawall <julia.lawall@inria.fr>
Suggested-by: Stefano Brivio <sbrivio@redhat.com>
Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
---
Changes since v4:
- Log message correction.

 drivers/staging/rtl8192u/r8192U_wx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c
index 0118edb0b9ab..100532598781 100644
--- a/drivers/staging/rtl8192u/r8192U_wx.c
+++ b/drivers/staging/rtl8192u/r8192U_wx.c
@@ -588,7 +588,7 @@ static int r8192_wx_set_enc(struct net_device *dev,
 				hwkey);                 /* KeyContent */
 
 		} else {
-			printk("wrong type in WEP, not WEP40 and WEP104\n");
+			netdev_warn(dev, "wrong type in WEP, not WEP40 and WEP104\n");
 		}
 
 	}
-- 
2.17.1

Re: [Outreachy kernel] [PATCH v5] staging: rtl8192u: r8192U_wx: use netdev_warn() instead of printk()

[Julia Lawall]

On Thu, 12 Mar 2020, Lourdes Pedrajas wrote:

> printk() is deprecated, use netdev_warn() instead, which is a message printing
> function specific for network devices defined in include/linux/netdevice.h.

I still don't think that "defined in include/linux/netdevice.h" is
necessary.  It's a well known function, and anyway if I don't know what it
is, then grep or elixir is sufficient to find the definition.

julia

> Issue found by checkpatch.
>
> Suggested-by: Julia Lawall <julia.lawall@inria.fr>
> Suggested-by: Stefano Brivio <sbrivio@redhat.com>
> Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
> ---
> Changes since v4:
> - Log message correction.
>
>  drivers/staging/rtl8192u/r8192U_wx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c
> index 0118edb0b9ab..100532598781 100644
> --- a/drivers/staging/rtl8192u/r8192U_wx.c
> +++ b/drivers/staging/rtl8192u/r8192U_wx.c
> @@ -588,7 +588,7 @@ static int r8192_wx_set_enc(struct net_device *dev,
>  				hwkey);                 /* KeyContent */
>
>  		} else {
> -			printk("wrong type in WEP, not WEP40 and WEP104\n");
> +			netdev_warn(dev, "wrong type in WEP, not WEP40 and WEP104\n");
>  		}
>
>  	}
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200312210540.9381-1-lu%40pplo.net.
>

Re: [Outreachy kernel] [PATCH v5] staging: rtl8192u: r8192U_wx: use netdev_warn() instead of printk()

[Lourdes Pedrajas]

On Fri, Mar 13, 2020 at 08:04:44AM +0100, Julia Lawall wrote:
> 
> 
> On Thu, 12 Mar 2020, Lourdes Pedrajas wrote:
> 
> > printk() is deprecated, use netdev_warn() instead, which is a message printing
> > function specific for network devices defined in include/linux/netdevice.h.
> 
> I still don't think that "defined in include/linux/netdevice.h" is
> necessary.  It's a well known function, and anyway if I don't know what it
> is, then grep or elixir is sufficient to find the definition.
> 
> julia
> 
Indeed, I am so sorry. Thank for your patience!

Lourdes

Re: [PATCH v5] staging: rtl8192u: r8192U_wx: use netdev_warn() instead of printk()

[Greg KH]

On Fri, Mar 13, 2020 at 10:05:44AM +0100, Lourdes Pedrajas wrote:
> printk() is deprecated, use netdev_warn() instead, which is a message printing
> function specific for network devices.
> Issue found by checkpatch.
> 
> Suggested-by: Julia Lawall <julia.lawall@inria.fr>
> Suggested-by: Stefano Brivio <sbrivio@redhat.com>
> Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
> ---
> Changes since v4:
> - Log message correction.
> 

You sent out 2 "v5" patches that were different :(

Please fix up and send out v6 properly.

thanks,

greg k-h

[PATCH v5] staging: rtl8192u: r8192U_wx: use netdev_warn() instead of printk()

[Lourdes Pedrajas]

printk() is deprecated, use netdev_warn() instead, which is a message printing
function specific for network devices.
Issue found by checkpatch.

Suggested-by: Julia Lawall <julia.lawall@inria.fr>
Suggested-by: Stefano Brivio <sbrivio@redhat.com>
Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
---
Changes since v4:
- Log message correction.

 drivers/staging/rtl8192u/r8192U_wx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c
index 0118edb0b9ab..100532598781 100644
--- a/drivers/staging/rtl8192u/r8192U_wx.c
+++ b/drivers/staging/rtl8192u/r8192U_wx.c
@@ -588,7 +588,7 @@ static int r8192_wx_set_enc(struct net_device *dev,
 				hwkey);                 /* KeyContent */
 
 		} else {
-			printk("wrong type in WEP, not WEP40 and WEP104\n");
+			netdev_warn(dev, "wrong type in WEP, not WEP40 and WEP104\n");
 		}
 
 	}
-- 
2.17.1