[PATCH net] cxgb4: fix delete filter entry fail in unload path

[PATCH net] cxgb4: fix delete filter entry fail in unload path

[Shahjada Abul Husain]

Currently, the hardware TID index is assumed to start from index 0.
However, with the following changeset,

commit c21939998802 ("cxgb4: add support for high priority filters")

hardware TID index can start after the high priority region, which
has introduced a regression resulting in remove filters entry
failure for cxgb4 unload path. This patch fix that.

Fixes: c21939998802 ("cxgb4: add support for high priority filters")
Signed-off-by: Shahjada Abul Husain <shahjada@chelsio.com>
---
 drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
index 2a2938bbb93a..fc05248984fc 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
@@ -902,7 +902,7 @@ void clear_all_filters(struct adapter *adapter)
 				adapter->tids.tid_tab[i];
 
 			if (f && (f->valid || f->pending))
-				cxgb4_del_filter(dev, i, &f->fs);
+				cxgb4_del_filter(dev, f->tid, &f->fs);
 		}
 
 		sb = t4_read_reg(adapter, LE_DB_SRVR_START_INDEX_A);
@@ -910,7 +910,7 @@ void clear_all_filters(struct adapter *adapter)
 			f = (struct filter_entry *)adapter->tids.tid_tab[i];
 
 			if (f && (f->valid || f->pending))
-				cxgb4_del_filter(dev, i, &f->fs);
+				cxgb4_del_filter(dev, f->tid, &f->fs);
 		}
 	}
 }
-- 
2.23.0.256.g4c86140

Re: [PATCH net] cxgb4: fix delete filter entry fail in unload path

[David Miller]

From: Shahjada Abul Husain <shahjada@chelsio.com>
Date: Fri, 13 Mar 2020 14:32:57 +0530

> Currently, the hardware TID index is assumed to start from index 0.
> However, with the following changeset,
> 
> commit c21939998802 ("cxgb4: add support for high priority filters")
> 
> hardware TID index can start after the high priority region, which
> has introduced a regression resulting in remove filters entry
> failure for cxgb4 unload path. This patch fix that.
> 
> Fixes: c21939998802 ("cxgb4: add support for high priority filters")
> Signed-off-by: Shahjada Abul Husain <shahjada@chelsio.com>

Applied, thanks.