All of lore.kernel.org
 help / color / mirror / Atom feed
From: afzal mohammed <afzal.mohd.ma@gmail.com>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Nathan Chancellor <natechancellor@gmail.com>,
	linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Ralf Baechle <ralf@linux-mips.org>,
	Paul Burton <paulburton@kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	bcm-kernel-feedback-list@broadcom.com,
	"Maciej W. Rozycki" <macro@linux-mips.org>,
	Jiaxun Yang <jiaxun.yang@flygoat.com>,
	Keguang Zhang <keguang.zhang@gmail.com>,
	Huacai Chen <chenhc@lemote.com>, John Crispin <john@phrozen.org>
Subject: Re: [PATCH v4] MIPS: Replace setup_irq() by request_irq()
Date: Fri, 13 Mar 2020 17:41:38 +0530	[thread overview]
Message-ID: <20200313121138.GA5985@afzalpc> (raw)
In-Reply-To: <20200311163249.GA4984@afzalpc>

Hi Thomas,

On Wed, Mar 11, 2020 at 10:02:49PM +0530, afzal mohammed wrote:
> On Wed, Mar 11, 2020 at 05:03:07PM +0100, Thomas Bogendoerfer wrote:

> > case ? I guess using handler as dev_id does a better job here.

> > And before doing that, lets clean up some of the IRQF_SHARED usage first.
> > All sni IRQF_SHARED can go away, the interrupt lines are exclusive there. 
> > 
> > loongson2ef/lemote-2f/irq.c: looks like the only user of
> > LOONGSON_NORTH_BRIDGE_IRQ, so IRQF_SHARED could go as well.
> > Could someone confirm that ?
> > 
> > All other need to stay, IMHO.

i am thinking of sending a new patch, with,

1) IRQF_SHARED removed from sni/{a20r.c,pcit.c,rm200.c}
2) IRQF_SHARED kept in,
        kernel/cevt-r4k.c
        dec/setup.c
        pmcs-msp71xx/msp-time.c
        loongson2ef/lemote-2f/irq.c
    and use handler as dev_id in those

Let me know if you have any other thoughts.

Regards
afzal

WARNING: multiple messages have this Message-ID (diff)
From: afzal mohammed <afzal.mohd.ma@gmail.com>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	Paul Burton <paulburton@kernel.org>,
	linux-mips@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
	linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	Jiaxun Yang <jiaxun.yang@flygoat.com>,
	"Maciej W. Rozycki" <macro@linux-mips.org>,
	John Crispin <john@phrozen.org>, Huacai Chen <chenhc@lemote.com>,
	Nathan Chancellor <natechancellor@gmail.com>,
	Keguang Zhang <keguang.zhang@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4] MIPS: Replace setup_irq() by request_irq()
Date: Fri, 13 Mar 2020 17:41:38 +0530	[thread overview]
Message-ID: <20200313121138.GA5985@afzalpc> (raw)
In-Reply-To: <20200311163249.GA4984@afzalpc>

Hi Thomas,

On Wed, Mar 11, 2020 at 10:02:49PM +0530, afzal mohammed wrote:
> On Wed, Mar 11, 2020 at 05:03:07PM +0100, Thomas Bogendoerfer wrote:

> > case ? I guess using handler as dev_id does a better job here.

> > And before doing that, lets clean up some of the IRQF_SHARED usage first.
> > All sni IRQF_SHARED can go away, the interrupt lines are exclusive there. 
> > 
> > loongson2ef/lemote-2f/irq.c: looks like the only user of
> > LOONGSON_NORTH_BRIDGE_IRQ, so IRQF_SHARED could go as well.
> > Could someone confirm that ?
> > 
> > All other need to stay, IMHO.

i am thinking of sending a new patch, with,

1) IRQF_SHARED removed from sni/{a20r.c,pcit.c,rm200.c}
2) IRQF_SHARED kept in,
        kernel/cevt-r4k.c
        dec/setup.c
        pmcs-msp71xx/msp-time.c
        loongson2ef/lemote-2f/irq.c
    and use handler as dev_id in those

Let me know if you have any other thoughts.

Regards
afzal

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-03-13 12:11 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-04  0:55 [PATCH v3] MIPS: Replace setup_irq() by request_irq() afzal mohammed
2020-03-04  0:55 ` afzal mohammed
2020-03-04 20:31 ` Thomas Bogendoerfer
2020-03-04 20:31   ` Thomas Bogendoerfer
2020-03-05 11:57   ` [PATCH v4] " afzal mohammed
2020-03-05 11:57     ` afzal mohammed
2020-03-06 12:47     ` Thomas Bogendoerfer
2020-03-06 12:47       ` Thomas Bogendoerfer
2020-03-11  5:31     ` Nathan Chancellor
2020-03-11  5:31       ` Nathan Chancellor
2020-03-11  7:56       ` afzal mohammed
2020-03-11  7:56         ` afzal mohammed
2020-03-11  9:03       ` afzal mohammed
2020-03-11  9:03         ` afzal mohammed
2020-03-11 10:42         ` Thomas Bogendoerfer
2020-03-11 10:42           ` Thomas Bogendoerfer
2020-03-11 13:12           ` afzal mohammed
2020-03-11 13:12             ` afzal mohammed
2020-03-11 16:03             ` Thomas Bogendoerfer
2020-03-11 16:03               ` Thomas Bogendoerfer
2020-03-11 16:32               ` afzal mohammed
2020-03-11 16:32                 ` afzal mohammed
2020-03-13 12:11                 ` afzal mohammed [this message]
2020-03-13 12:11                   ` afzal mohammed
2020-03-14  8:13                   ` [PATCH v2] MIPS: pass non-NULL dev_id on shared request_irq() afzal mohammed
2020-03-14  8:13                     ` afzal mohammed
2020-03-14 17:19                     ` Guenter Roeck
2020-03-14 17:19                       ` Guenter Roeck
2020-03-15  7:11                     ` Nathan Chancellor
2020-03-15  7:11                       ` Nathan Chancellor
2020-03-16 15:32                     ` Thomas Bogendoerfer
2020-03-16 15:32                       ` Thomas Bogendoerfer
2020-03-14  6:55                 ` [PATCH v4] MIPS: Replace setup_irq() by request_irq() afzal mohammed
2020-03-14  6:55                   ` afzal mohammed
2020-03-11 15:27           ` [PATCH] MIPS: pass non-NULL dev_id on shared request_irq() afzal mohammed
2020-03-11 15:27             ` afzal mohammed
2020-03-11 16:06           ` afzal mohammed
2020-03-11 16:06             ` afzal mohammed
2020-03-13 16:47     ` [PATCH v4] MIPS: Replace setup_irq() by request_irq() Guenter Roeck
2020-03-13 16:47       ` Guenter Roeck
2020-03-14  1:07       ` afzal mohammed
2020-03-14  1:07         ` afzal mohammed
2020-03-14  5:21         ` maobibo
2020-03-14  6:49           ` afzal mohammed
2020-03-14  6:49             ` afzal mohammed
2020-03-14 10:28         ` Guenter Roeck
2020-03-14 10:28           ` Guenter Roeck
2020-03-14 11:42           ` afzal mohammed
2020-03-14 11:42             ` afzal mohammed
2020-03-05 12:29   ` [PATCH v3] " afzal mohammed
2020-03-05 12:29     ` afzal mohammed
2020-03-05 12:42     ` afzal mohammed
2020-03-05 12:42       ` afzal mohammed
2020-03-04 20:38 ` kbuild test robot
2020-03-04 20:38   ` kbuild test robot
2020-03-04 20:38   ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200313121138.GA5985@afzalpc \
    --to=afzal.mohd.ma@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=chenhc@lemote.com \
    --cc=f.fainelli@gmail.com \
    --cc=jiaxun.yang@flygoat.com \
    --cc=john@phrozen.org \
    --cc=keguang.zhang@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=macro@linux-mips.org \
    --cc=natechancellor@gmail.com \
    --cc=paulburton@kernel.org \
    --cc=ralf@linux-mips.org \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.