All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Qian Cai <cai@lca.pw>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	John Stultz <john.stultz@linaro.org>,
	sboyd@kernel.org, rostedt@goodmis.org, hannes@cmpxchg.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] timer: silenct a lockdep splat with debugobjects
Date: Fri, 13 Mar 2020 21:13:14 +0100	[thread overview]
Message-ID: <20200313201314.GE5086@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <4FFD109D-EAC1-486F-8548-AA1F5E024120@lca.pw>

On Fri, Mar 13, 2020 at 03:32:52PM -0400, Qian Cai wrote:
> Well, in mm/vmstat.c (init_mm_internals) case for example, it was initialized
> as a static,
> 
> static DECLARE_DEFERRABLE_WORK(shepherd, vmstat_shepherd);
> 
> which will not call __debug_object_init(). 

Then fix that.

That is, all of:

  DECLARE_DEFERRABLE_WORK
  KTHREAD_DELAYED_WORK_INIT
  DEFINE_TIMER

are broken and need to go.

Unless of course, you can frob debugobjects such that we can provide the
required storage through is_static_object() and modify the above static
declarators to provide the storage.

Or, fix that random crud to do the wakeup outside of the lock.

Plenty options..

  reply	other threads:[~2020-03-13 20:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-13 15:42 [PATCH] timer: silenct a lockdep splat with debugobjects Qian Cai
2020-03-13 18:08 ` Peter Zijlstra
2020-03-13 19:32   ` Qian Cai
2020-03-13 20:13     ` Peter Zijlstra [this message]
2020-03-13 21:00       ` Qian Cai
2020-03-13 21:26         ` Peter Zijlstra
2020-03-14  2:53           ` Qian Cai
2020-03-23 13:41             ` Qian Cai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200313201314.GE5086@worktop.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=cai@lca.pw \
    --cc=hannes@cmpxchg.org \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=sboyd@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.