All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qian Cai <cai@lca.pw>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	John Stultz <john.stultz@linaro.org>,
	sboyd@kernel.org, "Steven Rostedt (VMware)" <rostedt@goodmis.org>,
	hannes@cmpxchg.org, LKML <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] timer: silenct a lockdep splat with debugobjects
Date: Mon, 23 Mar 2020 09:41:53 -0400	[thread overview]
Message-ID: <EBB4D2B4-1EDF-4EDF-B667-81FDFA1F4AF2@lca.pw> (raw)
In-Reply-To: <47A499D0-D1F5-4B72-A99D-6FBC8E3DD8AD@lca.pw>



> On Mar 13, 2020, at 10:53 PM, Qian Cai <cai@lca.pw> wrote:
> 
> 
> 
>> On Mar 13, 2020, at 5:26 PM, Peter Zijlstra <peterz@infradead.org> wrote:
>> 
>> On Fri, Mar 13, 2020 at 05:00:41PM -0400, Qian Cai wrote:
>>>> On Mar 13, 2020, at 4:13 PM, Peter Zijlstra <peterz@infradead.org> wrote:
>> 
>>>> 
>>>> Or, fix that random crud to do the wakeup outside of the lock.
>>> 
>>> That is likely to be difficult until we can find a creative way to not “uglifying" the
>>> random code by dropping locks in the middle etc just because of debugojects.
>> 
>> https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/log/?h=random/fast
>> 
>> Doesn't look difficult at all.
> 
> Great. I cherry-picked the first two patches,
> 
> random: Consolidate entropy batches for u32 and u64
> random: Remove batched entropy locking
> 
> which solved the issue here as well.
> 
> Andy, may I ask what your plan to post those?

Andy, do you mind me posting those 2 patches to Ted on your behalf if you have
no plan to do this in the near future?


      reply	other threads:[~2020-03-23 13:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-13 15:42 [PATCH] timer: silenct a lockdep splat with debugobjects Qian Cai
2020-03-13 18:08 ` Peter Zijlstra
2020-03-13 19:32   ` Qian Cai
2020-03-13 20:13     ` Peter Zijlstra
2020-03-13 21:00       ` Qian Cai
2020-03-13 21:26         ` Peter Zijlstra
2020-03-14  2:53           ` Qian Cai
2020-03-23 13:41             ` Qian Cai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=EBB4D2B4-1EDF-4EDF-B667-81FDFA1F4AF2@lca.pw \
    --to=cai@lca.pw \
    --cc=hannes@cmpxchg.org \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=sboyd@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.