[PATCH v3] staging: wlan-ng: Fix line going over 80 characters

[PATCH v3] staging: wlan-ng: Fix line going over 80 characters

[John B. Wyatt IV]

Add a newline before the second argument for style, readability, and
consistency.

Please note: checkpatch reports the third argument as being over 80
characters, but not the second argument.

Signed-off-by: John B. Wyatt IV <jbwyatt4@gmail.com>
---
v3: Fixed comment misspelling as suggested by Julia Lawall <julia.lawall@inria.fr>
    Also fixed missing colon ':'

v2: Fixed comment to be in the imperative as suggested by Julia Lawall <julia.lawall@inria.fr>

 drivers/staging/wlan-ng/hfa384x_usb.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index b71756ab0394..f8485601aead 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -3317,7 +3317,8 @@ static void hfa384x_usbin_rx(struct wlandevice *wlandev, struct sk_buff *skb)
 		break;
 
 	default:
-		netdev_warn(hw->wlandev->netdev, "Received frame on unsupported port=%d\n",
+		netdev_warn(hw->wlandev->netdev,
+			    "Received frame on unsupported port=%d\n",
 			    HFA384x_RXSTATUS_MACPORT_GET(usbin->rxfrm.desc.status));
 		break;
 	}
-- 
2.25.1

Re: [Outreachy kernel] [PATCH v3] staging: wlan-ng: Fix line going over 80 characters

[Stefano Brivio]

On Mon, 16 Mar 2020 15:15:44 -0700
"John B. Wyatt IV" <jbwyatt4@gmail.com> wrote:

> Add a newline before the second argument for style, readability, and
> consistency.
> 
> Please note: checkpatch reports the third argument as being over 80
> characters, but not the second argument.
> 
> Signed-off-by: John B. Wyatt IV <jbwyatt4@gmail.com>
> ---
> v3: Fixed comment misspelling as suggested by Julia Lawall <julia.lawall@inria.fr>
>     Also fixed missing colon ':'
> 
> v2: Fixed comment to be in the imperative as suggested by Julia Lawall <julia.lawall@inria.fr>

Reviewed-by: Stefano Brivio <sbrivio@redhat.com>

...but, please, don't forget about the unnecessary
HFA384x_RXSTATUS_MACPORT_GET() duplication here.

-- 
Stefano