[Buildroot] [PATCH 1/2] package/llvm: specify LLVM_ENABLE_BINDINGS=OFF

[Buildroot] [PATCH 1/2] package/llvm: specify LLVM_ENABLE_BINDINGS=OFF

[Joseph Kogut]

LLVM builds bindings for other languages such as Go and OCaml when the
appropriate dependencies can be found. We currently don't support
building these bindings in Buildroot, as they're currently unused by any
package.

Building these bindings was originally disabled by overriding the
dependencies with values indicating that they were not found.

Newer versions of LLVM no longer disable the OCaml bindings when overriding
OCAMLFIND. Consequently, the build process attempts to install the bindings
to the default location on the host of /usr/lib/ocaml/llvm, causing a
permissions error and build failure.

Additionally, LLVM has since added the variable LLVM_ENABLE_BINDINGS to
control whether bindings are enabled, so we override that to disable the
bindings.

Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
---
 package/llvm/llvm.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/llvm/llvm.mk b/package/llvm/llvm.mk
index 28ad6a5704..f1034f0365 100644
--- a/package/llvm/llvm.mk
+++ b/package/llvm/llvm.mk
@@ -193,7 +193,8 @@ LLVM_CONF_OPTS += -DLLVM_HOST_TRIPLE=$(GNU_TARGET_NAME)
 # check preventively. Building the Go and OCaml bindings is yet unsupported.
 HOST_LLVM_CONF_OPTS += \
 	-DGO_EXECUTABLE=GO_EXECUTABLE-NOTFOUND \
-	-DOCAMLFIND=OCAMLFIND-NOTFOUND
+	-DOCAMLFIND=OCAMLFIND-NOTFOUND \
+	-DLLVM_ENABLE_BINDINGS=OFF
 
 # Builds a release host tablegen that gets used during the LLVM build.
 HOST_LLVM_CONF_OPTS += -DLLVM_OPTIMIZED_TABLEGEN=ON
-- 
2.25.1

[Buildroot] [PATCH 2/2] package/llvm: remove outdated variables disabling bindings

[Joseph Kogut]

LLVM no longer disables unsupported bindings by overriding OCAMLFIND and
GO_EXECUTABLE, so remove them.

Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
---
 package/llvm/llvm.mk | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/package/llvm/llvm.mk b/package/llvm/llvm.mk
index f1034f0365..24d033d124 100644
--- a/package/llvm/llvm.mk
+++ b/package/llvm/llvm.mk
@@ -189,11 +189,8 @@ LLVM_CONF_OPTS += -DLLVM_DEFAULT_TARGET_TRIPLE=$(GNU_TARGET_NAME)
 # This solves "No available targets are compatible for this triple" with llvmpipe
 LLVM_CONF_OPTS += -DLLVM_HOST_TRIPLE=$(GNU_TARGET_NAME)
 
-# The Go bindings have no CMake rules at the moment, but better remove the
-# check preventively. Building the Go and OCaml bindings is yet unsupported.
+# Building the Go and OCaml bindings is yet unsupported.
 HOST_LLVM_CONF_OPTS += \
-	-DGO_EXECUTABLE=GO_EXECUTABLE-NOTFOUND \
-	-DOCAMLFIND=OCAMLFIND-NOTFOUND \
 	-DLLVM_ENABLE_BINDINGS=OFF
 
 # Builds a release host tablegen that gets used during the LLVM build.
-- 
2.25.1

[Buildroot] [PATCH 1/2] package/llvm: specify LLVM_ENABLE_BINDINGS=OFF

[Romain Naour]

Hi Joseph,

Le 16/03/2020 ? 21:01, Joseph Kogut a ?crit?:
> LLVM builds bindings for other languages such as Go and OCaml when the
> appropriate dependencies can be found. We currently don't support
> building these bindings in Buildroot, as they're currently unused by any
> package.
> 
> Building these bindings was originally disabled by overriding the
> dependencies with values indicating that they were not found.
> 
> Newer versions of LLVM no longer disable the OCaml bindings when overriding
> OCAMLFIND. Consequently, the build process attempts to install the bindings
> to the default location on the host of /usr/lib/ocaml/llvm, causing a
> permissions error and build failure.
> 
> Additionally, LLVM has since added the variable LLVM_ENABLE_BINDINGS to
> control whether bindings are enabled, so we override that to disable the
> bindings.

My autobuilder doesn't have ocaml libraries installed, maybe I can install them
to trigger the issue.

Reviewed-by: Romain Naour <romain.naour@gmail.com>

Best regards,
Romain


> 
> Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
> ---
>  package/llvm/llvm.mk | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/llvm/llvm.mk b/package/llvm/llvm.mk
> index 28ad6a5704..f1034f0365 100644
> --- a/package/llvm/llvm.mk
> +++ b/package/llvm/llvm.mk
> @@ -193,7 +193,8 @@ LLVM_CONF_OPTS += -DLLVM_HOST_TRIPLE=$(GNU_TARGET_NAME)
>  # check preventively. Building the Go and OCaml bindings is yet unsupported.
>  HOST_LLVM_CONF_OPTS += \
>  	-DGO_EXECUTABLE=GO_EXECUTABLE-NOTFOUND \
> -	-DOCAMLFIND=OCAMLFIND-NOTFOUND
> +	-DOCAMLFIND=OCAMLFIND-NOTFOUND \
> +	-DLLVM_ENABLE_BINDINGS=OFF
>  
>  # Builds a release host tablegen that gets used during the LLVM build.
>  HOST_LLVM_CONF_OPTS += -DLLVM_OPTIMIZED_TABLEGEN=ON
> 

[Buildroot] [PATCH 2/2] package/llvm: remove outdated variables disabling bindings

[Romain Naour]

Hi Joseph,

Le 16/03/2020 ? 21:01, Joseph Kogut a ?crit?:
> LLVM no longer disables unsupported bindings by overriding OCAMLFIND and
> GO_EXECUTABLE, so remove them.
> 
> Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
> ---
>  package/llvm/llvm.mk | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/package/llvm/llvm.mk b/package/llvm/llvm.mk
> index f1034f0365..24d033d124 100644
> --- a/package/llvm/llvm.mk
> +++ b/package/llvm/llvm.mk
> @@ -189,11 +189,8 @@ LLVM_CONF_OPTS += -DLLVM_DEFAULT_TARGET_TRIPLE=$(GNU_TARGET_NAME)
>  # This solves "No available targets are compatible for this triple" with llvmpipe
>  LLVM_CONF_OPTS += -DLLVM_HOST_TRIPLE=$(GNU_TARGET_NAME)
>  
> -# The Go bindings have no CMake rules at the moment, but better remove the
> -# check preventively. Building the Go and OCaml bindings is yet unsupported.
> +# Building the Go and OCaml bindings is yet unsupported.
>  HOST_LLVM_CONF_OPTS += \
> -	-DGO_EXECUTABLE=GO_EXECUTABLE-NOTFOUND \
> -	-DOCAMLFIND=OCAMLFIND-NOTFOUND \
>  	-DLLVM_ENABLE_BINDINGS=OFF

Reviewed-by: Romain Naour <romain.naour@gmail.com>

Best regards,
Romain

>  
>  # Builds a release host tablegen that gets used during the LLVM build.
> 

[Buildroot] [PATCH 1/2] package/llvm: specify LLVM_ENABLE_BINDINGS=OFF

[Joseph Kogut]

Hi Romain,

On Mon, Mar 16, 2020 at 3:09 PM Romain Naour <romain.naour@gmail.com> wrote:
>
> Hi Joseph,
>
> Le 16/03/2020 ? 21:01, Joseph Kogut a ?crit :
> > LLVM builds bindings for other languages such as Go and OCaml when the
> > appropriate dependencies can be found. We currently don't support
> > building these bindings in Buildroot, as they're currently unused by any
> > package.
> >
> > Building these bindings was originally disabled by overriding the
> > dependencies with values indicating that they were not found.
> >
> > Newer versions of LLVM no longer disable the OCaml bindings when overriding
> > OCAMLFIND. Consequently, the build process attempts to install the bindings
> > to the default location on the host of /usr/lib/ocaml/llvm, causing a
> > permissions error and build failure.
> >
> > Additionally, LLVM has since added the variable LLVM_ENABLE_BINDINGS to
> > control whether bindings are enabled, so we override that to disable the
> > bindings.
>
> My autobuilder doesn't have ocaml libraries installed, maybe I can install them
> to trigger the issue.
>

That would be great. I did check the autobuilders to see if this was a
known issue, and didn't find any build problems but timeouts for LLVM.




> Reviewed-by: Romain Naour <romain.naour@gmail.com>
>
> Best regards,
> Romain
>
>
> >
> > Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
> > ---
> >  package/llvm/llvm.mk | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/package/llvm/llvm.mk b/package/llvm/llvm.mk
> > index 28ad6a5704..f1034f0365 100644
> > --- a/package/llvm/llvm.mk
> > +++ b/package/llvm/llvm.mk
> > @@ -193,7 +193,8 @@ LLVM_CONF_OPTS += -DLLVM_HOST_TRIPLE=$(GNU_TARGET_NAME)
> >  # check preventively. Building the Go and OCaml bindings is yet unsupported.
> >  HOST_LLVM_CONF_OPTS += \
> >       -DGO_EXECUTABLE=GO_EXECUTABLE-NOTFOUND \
> > -     -DOCAMLFIND=OCAMLFIND-NOTFOUND
> > +     -DOCAMLFIND=OCAMLFIND-NOTFOUND \
> > +     -DLLVM_ENABLE_BINDINGS=OFF
> >
> >  # Builds a release host tablegen that gets used during the LLVM build.
> >  HOST_LLVM_CONF_OPTS += -DLLVM_OPTIMIZED_TABLEGEN=ON
> >
>

[Buildroot] [PATCH 1/2] package/llvm: specify LLVM_ENABLE_BINDINGS=OFF

[Thomas Petazzoni]

On Mon, 16 Mar 2020 13:01:05 -0700
Joseph Kogut <joseph.kogut@gmail.com> wrote:

> LLVM builds bindings for other languages such as Go and OCaml when the
> appropriate dependencies can be found. We currently don't support
> building these bindings in Buildroot, as they're currently unused by any
> package.
> 
> Building these bindings was originally disabled by overriding the
> dependencies with values indicating that they were not found.
> 
> Newer versions of LLVM no longer disable the OCaml bindings when overriding
> OCAMLFIND. Consequently, the build process attempts to install the bindings
> to the default location on the host of /usr/lib/ocaml/llvm, causing a
> permissions error and build failure.
> 
> Additionally, LLVM has since added the variable LLVM_ENABLE_BINDINGS to
> control whether bindings are enabled, so we override that to disable the
> bindings.
> 
> Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
> ---
>  package/llvm/llvm.mk | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Thanks, both patches applied.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/2] package/llvm: specify LLVM_ENABLE_BINDINGS=OFF

[Romain Naour]

Hi Joseph,

Le 18/03/2020 ? 01:27, Joseph Kogut a ?crit?:
> Hi Romain,
> 
> On Mon, Mar 16, 2020 at 3:09 PM Romain Naour <romain.naour@gmail.com> wrote:
>>
>> Hi Joseph,
>>
>> Le 16/03/2020 ? 21:01, Joseph Kogut a ?crit :
>>> LLVM builds bindings for other languages such as Go and OCaml when the
>>> appropriate dependencies can be found. We currently don't support
>>> building these bindings in Buildroot, as they're currently unused by any
>>> package.
>>>
>>> Building these bindings was originally disabled by overriding the
>>> dependencies with values indicating that they were not found.
>>>
>>> Newer versions of LLVM no longer disable the OCaml bindings when overriding
>>> OCAMLFIND. Consequently, the build process attempts to install the bindings
>>> to the default location on the host of /usr/lib/ocaml/llvm, causing a
>>> permissions error and build failure.
>>>
>>> Additionally, LLVM has since added the variable LLVM_ENABLE_BINDINGS to
>>> control whether bindings are enabled, so we override that to disable the
>>> bindings.
>>
>> My autobuilder doesn't have ocaml libraries installed, maybe I can install them
>> to trigger the issue.
>>
> 
> That would be great. I did check the autobuilders to see if this was a
> known issue, and didn't find any build problems but timeouts for LLVM.

Actually, the issue can't be trigged on the Fedora distribution since there is
no ocaml-ctype package [1]. Event with Fedora 30/31 ocaml bindings are
automatically disabled while configuring llvm:

"OCaml bindings disabled, need ctypes >=0.4."

[1] https://lists.fedoraproject.org/pipermail/devel/2015-March/208677.html

Best regards,
Romain

> 
> 
> 
> 
>> Reviewed-by: Romain Naour <romain.naour@gmail.com>
>>
>> Best regards,
>> Romain
>>
>>
>>>
>>> Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
>>> ---
>>>  package/llvm/llvm.mk | 3 ++-
>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/package/llvm/llvm.mk b/package/llvm/llvm.mk
>>> index 28ad6a5704..f1034f0365 100644
>>> --- a/package/llvm/llvm.mk
>>> +++ b/package/llvm/llvm.mk
>>> @@ -193,7 +193,8 @@ LLVM_CONF_OPTS += -DLLVM_HOST_TRIPLE=$(GNU_TARGET_NAME)
>>>  # check preventively. Building the Go and OCaml bindings is yet unsupported.
>>>  HOST_LLVM_CONF_OPTS += \
>>>       -DGO_EXECUTABLE=GO_EXECUTABLE-NOTFOUND \
>>> -     -DOCAMLFIND=OCAMLFIND-NOTFOUND
>>> +     -DOCAMLFIND=OCAMLFIND-NOTFOUND \
>>> +     -DLLVM_ENABLE_BINDINGS=OFF
>>>
>>>  # Builds a release host tablegen that gets used during the LLVM build.
>>>  HOST_LLVM_CONF_OPTS += -DLLVM_OPTIMIZED_TABLEGEN=ON
>>>
>>

[Buildroot] [PATCH 1/2] package/llvm: specify LLVM_ENABLE_BINDINGS=OFF

[Joseph Kogut]

Hi Romain,

On Thu, Mar 19, 2020 at 1:57 PM Romain Naour <romain.naour@gmail.com> wrote:
>
> Hi Joseph,
>
> Le 18/03/2020 ? 01:27, Joseph Kogut a ?crit :
> > Hi Romain,
> >
> > On Mon, Mar 16, 2020 at 3:09 PM Romain Naour <romain.naour@gmail.com> wrote:
> >>
> >> Hi Joseph,
> >>
> >> Le 16/03/2020 ? 21:01, Joseph Kogut a ?crit :
> >>> LLVM builds bindings for other languages such as Go and OCaml when the
> >>> appropriate dependencies can be found. We currently don't support
> >>> building these bindings in Buildroot, as they're currently unused by any
> >>> package.
> >>>
> >>> Building these bindings was originally disabled by overriding the
> >>> dependencies with values indicating that they were not found.
> >>>
> >>> Newer versions of LLVM no longer disable the OCaml bindings when overriding
> >>> OCAMLFIND. Consequently, the build process attempts to install the bindings
> >>> to the default location on the host of /usr/lib/ocaml/llvm, causing a
> >>> permissions error and build failure.
> >>>
> >>> Additionally, LLVM has since added the variable LLVM_ENABLE_BINDINGS to
> >>> control whether bindings are enabled, so we override that to disable the
> >>> bindings.
> >>
> >> My autobuilder doesn't have ocaml libraries installed, maybe I can install them
> >> to trigger the issue.
> >>
> >
> > That would be great. I did check the autobuilders to see if this was a
> > known issue, and didn't find any build problems but timeouts for LLVM.
>
> Actually, the issue can't be trigged on the Fedora distribution since there is
> no ocaml-ctype package [1]. Event with Fedora 30/31 ocaml bindings are
> automatically disabled while configuring llvm:
>
> "OCaml bindings disabled, need ctypes >=0.4."

Gotcha, I'm on Arch, for the record. I might look at spinning up a new
autobuilder to cover this.

>
> [1] https://lists.fedoraproject.org/pipermail/devel/2015-March/208677.html
>
> Best regards,
> Romain
>
> >
> >
> >
> >
> >> Reviewed-by: Romain Naour <romain.naour@gmail.com>
> >>
> >> Best regards,
> >> Romain
> >>
> >>
> >>>
> >>> Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
> >>> ---
> >>>  package/llvm/llvm.mk | 3 ++-
> >>>  1 file changed, 2 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/package/llvm/llvm.mk b/package/llvm/llvm.mk
> >>> index 28ad6a5704..f1034f0365 100644
> >>> --- a/package/llvm/llvm.mk
> >>> +++ b/package/llvm/llvm.mk
> >>> @@ -193,7 +193,8 @@ LLVM_CONF_OPTS += -DLLVM_HOST_TRIPLE=$(GNU_TARGET_NAME)
> >>>  # check preventively. Building the Go and OCaml bindings is yet unsupported.
> >>>  HOST_LLVM_CONF_OPTS += \
> >>>       -DGO_EXECUTABLE=GO_EXECUTABLE-NOTFOUND \
> >>> -     -DOCAMLFIND=OCAMLFIND-NOTFOUND
> >>> +     -DOCAMLFIND=OCAMLFIND-NOTFOUND \
> >>> +     -DLLVM_ENABLE_BINDINGS=OFF
> >>>
> >>>  # Builds a release host tablegen that gets used during the LLVM build.
> >>>  HOST_LLVM_CONF_OPTS += -DLLVM_OPTIMIZED_TABLEGEN=ON
> >>>
> >>
>

[Buildroot] [PATCH 1/2] package/llvm: specify LLVM_ENABLE_BINDINGS=OFF

[Peter Korsgaard]

>>>>> "Joseph" == Joseph Kogut <joseph.kogut@gmail.com> writes:

 > LLVM builds bindings for other languages such as Go and OCaml when the
 > appropriate dependencies can be found. We currently don't support
 > building these bindings in Buildroot, as they're currently unused by any
 > package.

 > Building these bindings was originally disabled by overriding the
 > dependencies with values indicating that they were not found.

 > Newer versions of LLVM no longer disable the OCaml bindings when overriding
 > OCAMLFIND. Consequently, the build process attempts to install the bindings
 > to the default location on the host of /usr/lib/ocaml/llvm, causing a
 > permissions error and build failure.

 > Additionally, LLVM has since added the variable LLVM_ENABLE_BINDINGS to
 > control whether bindings are enabled, so we override that to disable the
 > bindings.

 > Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>

Committed to 2019.11.x and 2020.02.x, thanks.

-- 
Bye, Peter Korsgaard