* [PATCH] ASoC: tas2562: Fixed incorrect amp_level setting.
@ 2020-03-19 14:00 Jonghwan Choi
2020-03-19 14:01 ` Dan Murphy
2020-03-24 16:37 ` Mark Brown
0 siblings, 2 replies; 7+ messages in thread
From: Jonghwan Choi @ 2020-03-19 14:00 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai, Dan Murphy
Cc: alsa-devel, linux-kernel
According to the tas2562 datasheet,the bits[5:1] represents the amp_level value.
So to set the amp_level value correctly,the shift value should be set to 1.
Signed-off-by: Jonghwan Choi <charlie.jh@kakaocorp.com>
---
sound/soc/codecs/tas2562.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/tas2562.c b/sound/soc/codecs/tas2562.c
index be52886a5edb..fb2233ca9103 100644
--- a/sound/soc/codecs/tas2562.c
+++ b/sound/soc/codecs/tas2562.c
@@ -409,7 +409,7 @@ static const struct snd_kcontrol_new vsense_switch =
1, 1);
static const struct snd_kcontrol_new tas2562_snd_controls[] = {
- SOC_SINGLE_TLV("Amp Gain Volume", TAS2562_PB_CFG1, 0, 0x1c, 0,
+ SOC_SINGLE_TLV("Amp Gain Volume", TAS2562_PB_CFG1, 1, 0x1c, 0,
tas2562_dac_tlv),
};
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] ASoC: tas2562: Fixed incorrect amp_level setting.
2020-03-19 14:00 [PATCH] ASoC: tas2562: Fixed incorrect amp_level setting Jonghwan Choi
@ 2020-03-19 14:01 ` Dan Murphy
2020-03-24 16:37 ` Mark Brown
1 sibling, 0 replies; 7+ messages in thread
From: Dan Murphy @ 2020-03-19 14:01 UTC (permalink / raw)
To: Jonghwan Choi, Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai
Cc: alsa-devel, linux-kernel
Jonghwan
On 3/19/20 9:00 AM, Jonghwan Choi wrote:
> According to the tas2562 datasheet,the bits[5:1] represents the amp_level value.
> So to set the amp_level value correctly,the shift value should be set to 1.
>
> Signed-off-by: Jonghwan Choi <charlie.jh@kakaocorp.com>
> ---
> sound/soc/codecs/tas2562.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/tas2562.c b/sound/soc/codecs/tas2562.c
> index be52886a5edb..fb2233ca9103 100644
> --- a/sound/soc/codecs/tas2562.c
> +++ b/sound/soc/codecs/tas2562.c
> @@ -409,7 +409,7 @@ static const struct snd_kcontrol_new vsense_switch =
> 1, 1);
>
> static const struct snd_kcontrol_new tas2562_snd_controls[] = {
> - SOC_SINGLE_TLV("Amp Gain Volume", TAS2562_PB_CFG1, 0, 0x1c, 0,
> + SOC_SINGLE_TLV("Amp Gain Volume", TAS2562_PB_CFG1, 1, 0x1c, 0,
> tas2562_dac_tlv),
> };
>
Acked-by: Dan Murphy <dmurphy@ti.com>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] ASoC: tas2562: Fixed incorrect amp_level setting.
@ 2020-03-19 14:01 ` Dan Murphy
0 siblings, 0 replies; 7+ messages in thread
From: Dan Murphy @ 2020-03-19 14:01 UTC (permalink / raw)
To: Jonghwan Choi, Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai
Cc: alsa-devel, linux-kernel
Jonghwan
On 3/19/20 9:00 AM, Jonghwan Choi wrote:
> According to the tas2562 datasheet,the bits[5:1] represents the amp_level value.
> So to set the amp_level value correctly,the shift value should be set to 1.
>
> Signed-off-by: Jonghwan Choi <charlie.jh@kakaocorp.com>
> ---
> sound/soc/codecs/tas2562.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/tas2562.c b/sound/soc/codecs/tas2562.c
> index be52886a5edb..fb2233ca9103 100644
> --- a/sound/soc/codecs/tas2562.c
> +++ b/sound/soc/codecs/tas2562.c
> @@ -409,7 +409,7 @@ static const struct snd_kcontrol_new vsense_switch =
> 1, 1);
>
> static const struct snd_kcontrol_new tas2562_snd_controls[] = {
> - SOC_SINGLE_TLV("Amp Gain Volume", TAS2562_PB_CFG1, 0, 0x1c, 0,
> + SOC_SINGLE_TLV("Amp Gain Volume", TAS2562_PB_CFG1, 1, 0x1c, 0,
> tas2562_dac_tlv),
> };
>
Acked-by: Dan Murphy <dmurphy@ti.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Applied "ASoC: tas2562: Fixed incorrect amp_level setting." to the asoc tree
2020-03-19 14:00 [PATCH] ASoC: tas2562: Fixed incorrect amp_level setting Jonghwan Choi
@ 2020-03-24 16:37 ` Mark Brown
2020-03-24 16:37 ` Mark Brown
1 sibling, 0 replies; 7+ messages in thread
From: Mark Brown @ 2020-03-24 16:37 UTC (permalink / raw)
To: Jonghwan Choi
Cc: alsa-devel, Dan Murphy, Jaroslav Kysela, Liam Girdwood,
linux-kernel, Mark Brown, stable, Takashi Iwai
The patch
ASoC: tas2562: Fixed incorrect amp_level setting.
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
From eedf8a126629bf9db8ad3a2a5dc9dc1798fb2302 Mon Sep 17 00:00:00 2001
From: Jonghwan Choi <charlie.jh@kakaocorp.com>
Date: Thu, 19 Mar 2020 23:00:44 +0900
Subject: [PATCH] ASoC: tas2562: Fixed incorrect amp_level setting.
According to the tas2562 datasheet,the bits[5:1] represents the amp_level value.
So to set the amp_level value correctly,the shift value should be set to 1.
Signed-off-by: Jonghwan Choi <charlie.jh@kakaocorp.com>
Acked-by: Dan Murphy <dmurphy@ti.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20200319140043.GA6688@jhbirdchoi-MS-7B79
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/codecs/tas2562.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/tas2562.c b/sound/soc/codecs/tas2562.c
index be52886a5edb..fb2233ca9103 100644
--- a/sound/soc/codecs/tas2562.c
+++ b/sound/soc/codecs/tas2562.c
@@ -409,7 +409,7 @@ static const struct snd_kcontrol_new vsense_switch =
1, 1);
static const struct snd_kcontrol_new tas2562_snd_controls[] = {
- SOC_SINGLE_TLV("Amp Gain Volume", TAS2562_PB_CFG1, 0, 0x1c, 0,
+ SOC_SINGLE_TLV("Amp Gain Volume", TAS2562_PB_CFG1, 1, 0x1c, 0,
tas2562_dac_tlv),
};
--
2.20.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Applied "ASoC: tas2562: Fixed incorrect amp_level setting." to the asoc tree
@ 2020-03-24 16:37 ` Mark Brown
0 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2020-03-24 16:37 UTC (permalink / raw)
To: Jonghwan Choi
Cc: alsa-devel, Takashi Iwai, Liam Girdwood, stable, linux-kernel,
Mark Brown, Dan Murphy
The patch
ASoC: tas2562: Fixed incorrect amp_level setting.
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
From eedf8a126629bf9db8ad3a2a5dc9dc1798fb2302 Mon Sep 17 00:00:00 2001
From: Jonghwan Choi <charlie.jh@kakaocorp.com>
Date: Thu, 19 Mar 2020 23:00:44 +0900
Subject: [PATCH] ASoC: tas2562: Fixed incorrect amp_level setting.
According to the tas2562 datasheet,the bits[5:1] represents the amp_level value.
So to set the amp_level value correctly,the shift value should be set to 1.
Signed-off-by: Jonghwan Choi <charlie.jh@kakaocorp.com>
Acked-by: Dan Murphy <dmurphy@ti.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20200319140043.GA6688@jhbirdchoi-MS-7B79
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/codecs/tas2562.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/tas2562.c b/sound/soc/codecs/tas2562.c
index be52886a5edb..fb2233ca9103 100644
--- a/sound/soc/codecs/tas2562.c
+++ b/sound/soc/codecs/tas2562.c
@@ -409,7 +409,7 @@ static const struct snd_kcontrol_new vsense_switch =
1, 1);
static const struct snd_kcontrol_new tas2562_snd_controls[] = {
- SOC_SINGLE_TLV("Amp Gain Volume", TAS2562_PB_CFG1, 0, 0x1c, 0,
+ SOC_SINGLE_TLV("Amp Gain Volume", TAS2562_PB_CFG1, 1, 0x1c, 0,
tas2562_dac_tlv),
};
--
2.20.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] ASoC: tas2562: Fixed incorrect amp_level setting.
@ 2020-03-19 6:16 jonghwan Choi
2020-03-19 13:04 ` Dan Murphy
0 siblings, 1 reply; 7+ messages in thread
From: jonghwan Choi @ 2020-03-19 6:16 UTC (permalink / raw)
To: Dan Murphy; +Cc: alsa-devel
From 9f837d75f16ab18342ac517d5b1e5259ab9b797e Mon Sep 17 00:00:00 2001
From: Jonghwan Choi <charlie.jh@kakaocorp.com>
Date: Thu, 19 Mar 2020 14:44:14 +0900
Subject: [PATCH] ASoC: tas2562: Fixed incorrect amp_level setting.
Signed-off-by: Jonghwan Choi <charlie.jh@kakaocorp.com>
---
sound/soc/codecs/tas2562.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/tas2562.c b/sound/soc/codecs/tas2562.c
index be52886a5edb..fb2233ca9103 100644
--- a/sound/soc/codecs/tas2562.c
+++ b/sound/soc/codecs/tas2562.c
@@ -409,7 +409,7 @@ static const struct snd_kcontrol_new vsense_switch =
1, 1);
static const struct snd_kcontrol_new tas2562_snd_controls[] = {
- SOC_SINGLE_TLV("Amp Gain Volume", TAS2562_PB_CFG1, 0, 0x1c, 0,
+ SOC_SINGLE_TLV("Amp Gain Volume", TAS2562_PB_CFG1, 1, 0x1c, 0,
tas2562_dac_tlv),
};
--
2.17.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] ASoC: tas2562: Fixed incorrect amp_level setting.
2020-03-19 6:16 [PATCH] ASoC: tas2562: Fixed incorrect amp_level setting jonghwan Choi
@ 2020-03-19 13:04 ` Dan Murphy
0 siblings, 0 replies; 7+ messages in thread
From: Dan Murphy @ 2020-03-19 13:04 UTC (permalink / raw)
To: jonghwan Choi; +Cc: alsa-devel
Jonghwan
On 3/19/20 1:16 AM, jonghwan Choi wrote:
> From 9f837d75f16ab18342ac517d5b1e5259ab9b797e Mon Sep 17 00:00:00 2001
>
> From: Jonghwan Choi <charlie.jh@kakaocorp.com>
>
> Date: Thu, 19 Mar 2020 14:44:14 +0900
>
> Subject: [PATCH] ASoC: tas2562: Fixed incorrect amp_level setting.
There does not seem to be a commit message here.
Also please add the Fixes tag.
The change is fine just needs commit message and you need to add all the
proper reviewers.
You can get this by using the get_maintainers script
Dan
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-03-24 16:38 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-19 14:00 [PATCH] ASoC: tas2562: Fixed incorrect amp_level setting Jonghwan Choi
2020-03-19 14:01 ` Dan Murphy
2020-03-19 14:01 ` Dan Murphy
2020-03-24 16:37 ` Applied "ASoC: tas2562: Fixed incorrect amp_level setting." to the asoc tree Mark Brown
2020-03-24 16:37 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2020-03-19 6:16 [PATCH] ASoC: tas2562: Fixed incorrect amp_level setting jonghwan Choi
2020-03-19 13:04 ` Dan Murphy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.