All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shourya Shukla <shouryashukla.oo@gmail.com>
To: harshitjain1371999@gmail.com
Cc: git@vger.kernel.org, Shourya Shukla <shouryashukla.oo@gmail.com>
Subject: Re: [GSoC][PATCH 1/2] t4131: modernize style
Date: Thu, 19 Mar 2020 22:08:17 +0530	[thread overview]
Message-ID: <20200319163817.4239-1-shouryashukla.oo@gmail.com> (raw)
In-Reply-To: <20200319132957.17813-2-harshitjain1371999@gmail.com>

Hello Harshit,

> The tests in 't4131-apply-fake-ancestor.sh' were written a long time ago, and have a few style violations. Update it to adhere to the CodingGuidelines.

Maybe add a commit title and then have a body? To do so, do a 'git commit' instead of 'git commit -m "message"'. This will open a text editor
in which you can edit your commit message. You may refer to this answer I gave on StackOverflow on commit messages:

https://stackoverflow.com/a/60755299/10751129

Also, commit messages are generally around 72 characters per line. What are the
style violations you are talking about BTW?

The commit title can be of the form:

t4131: modernise style

<<commit description>>


Regards,
Shourya Shukla

  reply	other threads:[~2020-03-19 16:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-19 13:29 [GSoC][Patch 0/2] t4131: update test script Harshit Jain
2020-03-19 13:29 ` [GSoC][PATCH 1/2] t4131: modernize style Harshit Jain
2020-03-19 16:38   ` Shourya Shukla [this message]
2020-03-19 17:45     ` Harshit Jain
2020-03-19 21:55       ` Junio C Hamano
2020-03-19 13:29 ` [GSoC][PATCH 2/2] t4131: use helper function to replace test -f <path> Harshit Jain
2020-03-19 16:42   ` Shourya Shukla
2020-03-19 17:33     ` Kaartic Sivaraam
2020-03-19 20:18       ` Harshit Jain
2020-03-20 15:39       ` Re: RFC][Feature] submodule Shourya Shukla
2020-03-19 21:58     ` [GSoC][PATCH 2/2] t4131: use helper function to replace test -f <path> Junio C Hamano
2020-03-20 13:08       ` [GSoC][Patch 0/2] made the changes as per community suggestions Harshit Jain
2020-03-20 13:08         ` [PATCH 1/2] t4131: modernize style Harshit Jain
2020-03-20 15:56           ` Re: [GSoC][Patch] Shourya Shukla
2020-03-20 17:14             ` Harshit Jain
2020-03-20 13:08         ` [PATCH 2/2] t4131: use helper function to replace 'test -f' Harshit Jain
2020-03-20 15:43       ` Re: [GSoC][Patch] Shourya Shukla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200319163817.4239-1-shouryashukla.oo@gmail.com \
    --to=shouryashukla.oo@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=harshitjain1371999@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.