From: Harshit Jain <harshitjain1371999@gmail.com>
To: gitster@pobox.com
Cc: git@vger.kernel.org, harshitjain1371999@gmail.com,
shouryashukla.oo@gmail.com
Subject: [PATCH 1/2] t4131: modernize style
Date: Fri, 20 Mar 2020 18:38:44 +0530 [thread overview]
Message-ID: <20200320130845.23257-2-harshitjain1371999@gmail.com> (raw)
In-Reply-To: <20200320130845.23257-1-harshitjain1371999@gmail.com>
The tests in t4131 leave a space character between the redirection operator
and the file i.e. the redirection target which does not conform to the
modern coding style.
Fix them.
Signed-off-by: Harshit Jain <harshitjain1371999@gmail.com>
---
t/t4131-apply-fake-ancestor.sh | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/t/t4131-apply-fake-ancestor.sh b/t/t4131-apply-fake-ancestor.sh
index b1361ce546..828d1a355b 100755
--- a/t/t4131-apply-fake-ancestor.sh
+++ b/t/t4131-apply-fake-ancestor.sh
@@ -17,8 +17,8 @@ test_expect_success 'setup' '
test_expect_success 'apply --build-fake-ancestor' '
git checkout 2 &&
- echo "A" > 1.t &&
- git diff > 1.patch &&
+ echo "A" >1.t &&
+ git diff >1.patch &&
git reset --hard &&
git checkout 1 &&
git apply --build-fake-ancestor 1.ancestor 1.patch
@@ -26,8 +26,8 @@ test_expect_success 'apply --build-fake-ancestor' '
test_expect_success 'apply --build-fake-ancestor in a subdirectory' '
git checkout 3 &&
- echo "C" > sub/3.t &&
- git diff > 3.patch &&
+ echo "C" >sub/3.t &&
+ git diff >3.patch &&
git reset --hard &&
git checkout 4 &&
(
--
2.26.0.rc2
next prev parent reply other threads:[~2020-03-20 13:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 13:29 [GSoC][Patch 0/2] t4131: update test script Harshit Jain
2020-03-19 13:29 ` [GSoC][PATCH 1/2] t4131: modernize style Harshit Jain
2020-03-19 16:38 ` Shourya Shukla
2020-03-19 17:45 ` Harshit Jain
2020-03-19 21:55 ` Junio C Hamano
2020-03-19 13:29 ` [GSoC][PATCH 2/2] t4131: use helper function to replace test -f <path> Harshit Jain
2020-03-19 16:42 ` Shourya Shukla
2020-03-19 17:33 ` Kaartic Sivaraam
2020-03-19 20:18 ` Harshit Jain
2020-03-20 15:39 ` Re: RFC][Feature] submodule Shourya Shukla
2020-03-19 21:58 ` [GSoC][PATCH 2/2] t4131: use helper function to replace test -f <path> Junio C Hamano
2020-03-20 13:08 ` [GSoC][Patch 0/2] made the changes as per community suggestions Harshit Jain
2020-03-20 13:08 ` Harshit Jain [this message]
2020-03-20 15:56 ` Re: [GSoC][Patch] Shourya Shukla
2020-03-20 17:14 ` Harshit Jain
2020-03-20 13:08 ` [PATCH 2/2] t4131: use helper function to replace 'test -f' Harshit Jain
2020-03-20 15:43 ` Re: [GSoC][Patch] Shourya Shukla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320130845.23257-2-harshitjain1371999@gmail.com \
--to=harshitjain1371999@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=shouryashukla.oo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.