Re: [Outreachy kernel] Trying to use Coccinelle

[Lourdes Pedrajas <lu@pplo.net>]

Julia, Stefano,

I would like to move to coccinelle instead of continue using checkpatch. So 
after the problem I explained in my last email, I have been trying various
combinations of commands and modifications in some makefiles, as Stefano
suggested. In order to see what is happening or to see why I can't use
coccinelle.

This is long, so I ask for forgiveness for that :( 

Lines preceded with $ are the commands I have run. Lines inside braces () are 
some modifications I have done that is not reflected in the console's output or 
clarifications.  The majority of the output is stripped in the sake of brevity, 
only the obvious errors are here.                                               
                                                                                
I don't know if this will be useful or not :( But I'll be glad if as least my 
problem helps to find any error or bug, or helps coccinelle itself.

Thank you,
Lourdes 


====

$ make coccicheck MODE=patch J=8 M=drivers/staging/android/ --debug

--(stripped output)
File 'coccicheck' does not exist.
Must remake target 'coccicheck'.

Please check for false positives in the output before submitting a patch.
When using "patch" mode, carefully review the patch before submitting it.

coccicheck failed
Makefile:1740: recipe for target 'coccicheck' failed
make: *** [coccicheck] Error 255

====

$ make coccicheck MODE=patch J=8 M=drivers/staging/android/ --debug

(showing $(BASH) and $(srctree) variables from 1740 line of the main Makefile,
and DIR and SPATCH from scripts/coccicheck lines 10-11)

--(stripped output)
File 'coccicheck' does not exist.
Must remake target 'coccicheck'.

Please check for false positives in the output before submitting a patch.
When using "patch" mode, carefully review the patch before submitting it.

BASH = bash
srctree = .

DIR = /mnt/btrfsimg/gregkh/staging/scripts/..
SPATCH = /usr/local/bin/spatch

coccicheck failed
Makefile:1740: recipe for target 'coccicheck' failed
make: *** [coccicheck] Error 255

====

$ make /mnt/btrfsimg/gregkh/staging/scripts/coccicheck MODE=patch J=8
  M=drivers/staging/android/ --debug

(but x86_64 binutils are installed!! It don't repeat the error of last command
about not finding coccicheck file here)

--(stripped output)

arch/x86/Makefile:147: CONFIG_X86_X32 enabled but no binutils support

====

$ make /mnt/btrfsimg/gregkh/staging/scripts/coccicheck MODE=patch J=8
  M=drivers/staging/android/ --debug

(w/o CONFIG_X86_X32 or commenting-out the ifdef CONFIG_X86_X32 section of
arch/x86/Makefile)

--(stripped output)

make: Nothing to be done for '/mnt/btrfsimg/gregkh/staging/scripts/coccicheck'.

====

$ make coccicheck C=2 MODE=patch J=8 drivers/staging/android/ashmem.c --debug

--(stripped output)
File 'coccicheck' does not exist.
Must remake target 'coccicheck'.
./scripts/coccicheck: line 65: shift: -1: shift count out of range
Successfully remade target file 'coccicheck'.
make: Nothing to be done for 'drivers/staging/android/ashmem.c'.

====

$ make coccicheck C=2 MODE=patch J=8 --debug drivers/staging/*/*.c

--(stripped output)
File 'coccicheck' does not exist.
Must remake target 'coccicheck'.
./scripts/coccicheck: line 65: shift: -1: shift count out of range
Successfully remade target file 'coccicheck'.
make: Nothing to be done for 'drivers/staging/android/ashmem.c'.
make: Nothing to be done for 'drivers/staging/axis-fifo/axis-fifo.c'.
--(stripped output: it repeats the same line for all C files inside staging
   drivers)

====

$ make coccicheck C=1 MODE=patch J=8 --debug drivers/staging/*/*.c

--(stripped output)
File 'coccicheck' does not exist.
Must remake target 'coccicheck'.
./scripts/coccicheck: line 65: shift: -1: shift count out of range
Successfully remade target file 'coccicheck'.
make: Nothing to be done for 'drivers/staging/android/ashmem.c'.
make: Nothing to be done for 'drivers/staging/axis-fifo/axis-fifo.c'.
--(stripped output: it repeats the same line for all C files inside staging
   drivers)

====

$ make coccicheck MODE=patch J=8 drivers/staging/android/ --debug

Reading makefiles...
Updating goal targets....
 File 'coccicheck' does not exist.
   File '__build_one_by_one' does not exist.
  Must remake target '__build_one_by_one'.
GNU Make 4.1
Built for x86_64-pc-linux-gnu
Copyright (C) 1988-2014 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Reading makefiles...
Updating goal targets....
 File 'coccicheck' does not exist.
Must remake target 'coccicheck'.

--(stripped output: after a while it produces some patches in drivers/ but not
   drivers/staging/. And then the same error:)

coccicheck failed
Makefile:1740: recipe for target 'coccicheck' failed
make: *** [coccicheck] Error 255

====

$ make coccicheck MODE=patch V=1 J=8 --debug

(it works, but doesn't descend into drivers/staging/ before giving this error:)

coccicheck failed
Makefile:1740: recipe for target 'coccicheck' failed
make: *** [coccicheck] Error 255

====

$ make coccicheck MODE=patch V=1 J=8 --debug
(with variable KBUILD_EXTMOD set to drivers/staging/ in scripts/coccicheck)

--(stripped output)
File 'coccicheck' does not exist.
Must remake target 'coccicheck'.
bash ./scripts/coccicheck
--(stripped output)

Processing alloc_cast.cocci
with option(s) " --no-includes --include-headers"

--(stripped output)

Running (8 in parallel): /usr/local/bin/spatch -D patch --very-quiet
--cocci-file ./scripts/coccinelle/api/alloc/alloc_cast.cocci --no-includes
--include-headers --patch . --dir ./drivers/staging/. -I ./arch/x86/include
-I ./arch/x86/include/generated -I ./include -I ./arch/x86/include/uapi
-I ./arch/x86/include/generated/uapi -I ./include/uapi
-I ./include/generated/uapi --include ./include/linux/kconfig.h --jobs 8
--chunksize 1
Processing pool_zalloc-simple.cocci
with option(s) " --no-includes --include-headers"

--(stripped output)

Running (8 in parallel): /usr/local/bin/spatch -D patch --very-quiet
--cocci-file ./scripts/coccinelle/api/alloc/pool_zalloc-simple.cocci
--no-includes --include-headers --patch . --dir ./drivers/staging/.
-I ./arch/x86/include -I ./arch/x86/include/generated -I ./include
-I ./arch/x86/include/uapi -I ./arch/x86/include/generated/uapi
-I ./include/uapi -I ./include/generated/uapi
--include ./include/linux/kconfig.h --jobs 8 --chunksize 1
Processing zalloc-simple.cocci
with option(s) " --no-includes --include-headers

--(stripped output)

Running (8 in parallel): /usr/local/bin/spatch -D patch --very-quiet
--cocci-file ./scripts/coccinelle/api/alloc/zalloc-simple.cocci
--no-includes --include-headers --patch . --dir ./drivers/staging/.
-I ./arch/x86/include -I ./arch/x86/include/generated -I ./include
-I ./arch/x86/include/uapi -I ./arch/x86/include/generated/uapi
-I ./include/uapi -I ./include/generated/uapi
--include ./include/linux/kconfig.h --jobs 8 --chunksize 1
Processing atomic_as_refcounter.cocci
with option(s) " --include-headers --very-quiet"

--(stripped output)

Running (8 in parallel): /usr/local/bin/spatch -D patch --very-quiet
--cocci-file ./scripts/coccinelle/api/atomic_as_refcounter.cocci
--include-headers --very-quiet --patch . --dir ./drivers/staging/.
-I ./arch/x86/include -I ./arch/x86/include/generated -I ./include
-I ./arch/x86/include/uapi -I ./arch/x86/include/generated/uapi
-I ./include/uapi -I ./include/generated/uapi
--include ./include/linux/kconfig.h --jobs 8 --chunksize 1
coccicheck failed
Makefile:1740: recipe for target 'coccicheck' failed
make: *** [coccicheck] Error 255