Re: [Outreachy kernel] Trying to use Coccinelle

From: Lourdes Pedrajas <lu@pplo.net>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: Stefano Brivio <sbrivio@redhat.com>, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] Trying to use Coccinelle
Date: Thu, 19 Mar 2020 23:06:05 +0100	[thread overview]
Message-ID: <20200319220605.GD10911@supernova> (raw)
In-Reply-To: <alpine.DEB.2.21.2003192249420.9011@hadrien>

On Thu, Mar 19, 2020 at 10:50:15PM +0100, Julia Lawall wrote:
> 
> 
> On Thu, 19 Mar 2020, Lourdes Pedrajas wrote:
> 
> > On Thu, Mar 19, 2020 at 10:38:59PM +0100, Julia Lawall wrote:
> > >
> > >
> > > On Thu, 19 Mar 2020, Lourdes Pedrajas wrote:
> > >
> > > > On Thu, Mar 19, 2020 at 09:43:21PM +0100, Stefano Brivio wrote:
> > > > > On Thu, 19 Mar 2020 21:15:53 +0100
> > > > > Lourdes Pedrajas <lu@pplo.net> wrote:
> > > > >
> > > > > Can you just run this spatch command:
> > > > >
> > > > > > Running (8 in parallel): /usr/local/bin/spatch -D patch --very-quiet
> > > > > > --cocci-file ./scripts/coccinelle/api/atomic_as_refcounter.cocci
> > > > > > --include-headers --very-quiet --patch . --dir ./drivers/staging/.
> > > > > > -I ./arch/x86/include -I ./arch/x86/include/generated -I ./include
> > > > > > -I ./arch/x86/include/uapi -I ./arch/x86/include/generated/uapi
> > > > > > -I ./include/uapi -I ./include/generated/uapi
> > > > > > --include ./include/linux/kconfig.h --jobs 8 --chunksize 1
> > > > > > coccicheck failed
> > > > > > Makefile:1740: recipe for target 'coccicheck' failed
> > > > > > make: *** [coccicheck] Error 255
> > > > >
> > > > > alone, from the same directory? The issue (okay, I'll send a patch) is
> > > > > that the coccicheck script suppresses stderr for it.
> > > > >
> > > > > --
> > > > > Stefano
> > > > >
> > > >
> > > > It says "274 files match" and if I suppress the "--very-quiet" part of
> > > > the command, it outputs many files preceded with the word "HANDLING:".
> > > >
> > > > After that, If I try, by example, this command:
> > > >
> > > > /usr/local/bin/spatch -D patch
> > > > --cocci-file ./scripts/coccinelle/api/alloc/alloc_cast.cocci
> > > > --no-includes --include-headers -I ./arch/x86/include
> > > > -I ./arch/x86/include/generated -I ./include -I ./arch/x86/include/uapi
> > > > -I ./arch/x86/include/generated/uapi -I ./include/uapi
> > > > -I ./include/generated/uapi --include ./include/linux/kconfig.h --jobs 8
> > > > --chunksize 1 drivers/staging/qlge/qlge_mpi.c
> > > >
> > > > It says:
> > > >
> > > > HANDLING: drivers/staging/qlge/qlge_mpi.c
> > > >
> > > > But nothing more.
> > > >
> > > > The command Julia suggest has similar results.
> > > >
> > > > Is this correct? I thought it outputs reports or patches.
> > >
> > > Yes, that is correct.  Maybe it has nothing to do on that file.
> > >
> > > Could you try the following file:
> > >
> > > drivers/net/ethernet/qlogic/qed/qed_roce.c
> > >
> > > with the semantic patch
> > >
> > > scripts/coccinelle/api/alloc/alloc_cast.cocci
> > >
> > > julia
> >
> > Yes, now it worked! :)
> 
> Um, now what worked?  I guess you got a message for this file, but is make
> coccicheck now working too?
> 
> julia

Oh, sorry I was not clear, this command worked:

/usr/local/bin/spatch -D report
--cocci-file ./scripts/coccinelle/api/alloc/alloc_cast.cocci --no-includes
--include-headers -I ./arch/x86/include -I ./arch/x86/include/generated
-I ./include -I ./arch/x86/include/uapi -I ./arch/x86/include/generated/uapi
-I ./include/uapi -I ./include/generated/uapi
--include ./include/linux/kconfig.h --jobs 8
--chunksize 1 drivers/net/ethernet/qlogic/qed/qed_roce.c

You were right, it had nothing to do in the file I tried (and some others too)
but in this file worked:

drivers/net/ethernet/qlogic/qed/qed_roce.c

> but is make coccicheck now working too?

No, it is not working, sorry :(

For the record, I'm using linux mint, installed the dependencies the
official site says for ubuntu/debian, but got some compilation errors
and eventually solved them. 

Thank you for your patience,

Lourdes