All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Saeed Mahameed <saeedm@mellanox.com>,
	linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] {IB,net}/mlx5: Remove unused variable
Date: Fri, 20 Mar 2020 16:32:02 +0200	[thread overview]
Message-ID: <20200320143202.GG514123@unreal> (raw)
In-Reply-To: <20200320132525.GE95012@mwanda>

On Fri, Mar 20, 2020 at 04:25:25PM +0300, Dan Carpenter wrote:
> The "key" variable is never initialized or used except to print out a
> debug message.
>
> Fixes: fc6a9f86f08a ("{IB,net}/mlx5: Assign mkey variant in mlx5_ib only")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/mr.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>

Thanks, for the patch, but Saeed already fixed it and it is in linux-next.
https://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git/commit/?h=mlx5-next&id=826096d84f509d95ee8f72728fe19c44fbb9df6b

Thanks

WARNING: multiple messages have this Message-ID (diff)
From: Leon Romanovsky <leon@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Saeed Mahameed <saeedm@mellanox.com>,
	linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] {IB,net}/mlx5: Remove unused variable
Date: Fri, 20 Mar 2020 14:32:02 +0000	[thread overview]
Message-ID: <20200320143202.GG514123@unreal> (raw)
In-Reply-To: <20200320132525.GE95012@mwanda>

On Fri, Mar 20, 2020 at 04:25:25PM +0300, Dan Carpenter wrote:
> The "key" variable is never initialized or used except to print out a
> debug message.
>
> Fixes: fc6a9f86f08a ("{IB,net}/mlx5: Assign mkey variant in mlx5_ib only")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/mr.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>

Thanks, for the patch, but Saeed already fixed it and it is in linux-next.
https://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git/commit/?h=mlx5-next&id‚6096d84f509d95ee8f72728fe19c44fbb9df6b

Thanks

  reply	other threads:[~2020-03-20 14:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-20 13:25 [PATCH] {IB,net}/mlx5: Remove unused variable Dan Carpenter
2020-03-20 13:25 ` Dan Carpenter
2020-03-20 14:32 ` Leon Romanovsky [this message]
2020-03-20 14:32   ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200320143202.GG514123@unreal \
    --to=leon@kernel.org \
    --cc=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=saeedm@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.