All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/radvd: drop dependency on flex runtime library
@ 2020-03-20 10:07 Alexander Mukhin
  2020-03-20 21:11 ` Yann E. MORIN
  2020-03-28  7:35 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Alexander Mukhin @ 2020-03-20 10:07 UTC (permalink / raw)
  To: buildroot

Radvd has its own main(), and does not use yywrap() from libfl.so,
because scanner.l module contains noyywrap option. So, none of the
functions exported by libfl.so are used, and there's no need to have
the flex runtime on target.

Signed-off-by: Alexander Mukhin <alexander.i.mukhin@gmail.com>
---
 package/radvd/Config.in | 1 -
 package/radvd/radvd.mk  | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/package/radvd/Config.in b/package/radvd/Config.in
index fa5a20c4c1..f1df0c3cb8 100644
--- a/package/radvd/Config.in
+++ b/package/radvd/Config.in
@@ -1,7 +1,6 @@
 config BR2_PACKAGE_RADVD
 	bool "radvd"
 	depends on BR2_USE_MMU # fork()
-	select BR2_PACKAGE_FLEX
 	help
 	  IPv6 Router Advertisement Daemon.
 
diff --git a/package/radvd/radvd.mk b/package/radvd/radvd.mk
index 3358264f18..ba0c78bd1e 100644
--- a/package/radvd/radvd.mk
+++ b/package/radvd/radvd.mk
@@ -6,7 +6,7 @@
 
 RADVD_VERSION = 2.18
 RADVD_SITE = http://www.litech.org/radvd/dist
-RADVD_DEPENDENCIES = host-bison flex host-flex host-pkgconf
+RADVD_DEPENDENCIES = host-bison host-flex host-pkgconf
 # We need to ignore <linux/if_arp.h>, because radvd already includes
 # <net/if_arp.h>, which conflicts with <linux/if_arp.h>.
 RADVD_CONF_ENV = \
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] package/radvd: drop dependency on flex runtime library
  2020-03-20 10:07 [Buildroot] [PATCH] package/radvd: drop dependency on flex runtime library Alexander Mukhin
@ 2020-03-20 21:11 ` Yann E. MORIN
  2020-03-28  7:35 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2020-03-20 21:11 UTC (permalink / raw)
  To: buildroot

Alexander, All,

On 2020-03-20 13:07 +0300, Alexander Mukhin spake thusly:
> Radvd has its own main(), and does not use yywrap() from libfl.so,
> because scanner.l module contains noyywrap option. So, none of the
> functions exported by libfl.so are used, and there's no need to have
> the flex runtime on target.
> 
> Signed-off-by: Alexander Mukhin <alexander.i.mukhin@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/radvd/Config.in | 1 -
>  package/radvd/radvd.mk  | 2 +-
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/package/radvd/Config.in b/package/radvd/Config.in
> index fa5a20c4c1..f1df0c3cb8 100644
> --- a/package/radvd/Config.in
> +++ b/package/radvd/Config.in
> @@ -1,7 +1,6 @@
>  config BR2_PACKAGE_RADVD
>  	bool "radvd"
>  	depends on BR2_USE_MMU # fork()
> -	select BR2_PACKAGE_FLEX
>  	help
>  	  IPv6 Router Advertisement Daemon.
>  
> diff --git a/package/radvd/radvd.mk b/package/radvd/radvd.mk
> index 3358264f18..ba0c78bd1e 100644
> --- a/package/radvd/radvd.mk
> +++ b/package/radvd/radvd.mk
> @@ -6,7 +6,7 @@
>  
>  RADVD_VERSION = 2.18
>  RADVD_SITE = http://www.litech.org/radvd/dist
> -RADVD_DEPENDENCIES = host-bison flex host-flex host-pkgconf
> +RADVD_DEPENDENCIES = host-bison host-flex host-pkgconf
>  # We need to ignore <linux/if_arp.h>, because radvd already includes
>  # <net/if_arp.h>, which conflicts with <linux/if_arp.h>.
>  RADVD_CONF_ENV = \
> -- 
> 2.20.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] package/radvd: drop dependency on flex runtime library
  2020-03-20 10:07 [Buildroot] [PATCH] package/radvd: drop dependency on flex runtime library Alexander Mukhin
  2020-03-20 21:11 ` Yann E. MORIN
@ 2020-03-28  7:35 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2020-03-28  7:35 UTC (permalink / raw)
  To: buildroot

>>>>> "Alexander" == Alexander Mukhin <alexander.i.mukhin@gmail.com> writes:

 > Radvd has its own main(), and does not use yywrap() from libfl.so,
 > because scanner.l module contains noyywrap option. So, none of the
 > functions exported by libfl.so are used, and there's no need to have
 > the flex runtime on target.

 > Signed-off-by: Alexander Mukhin <alexander.i.mukhin@gmail.com>

Committed to 2020.02.x and 2019.11.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-03-28  7:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-20 10:07 [Buildroot] [PATCH] package/radvd: drop dependency on flex runtime library Alexander Mukhin
2020-03-20 21:11 ` Yann E. MORIN
2020-03-28  7:35 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.