* [PULL 0/1] DTC queue for 5.0
@ 2020-03-20 21:59 Alistair Francis
2020-03-20 21:59 ` [PULL 1/1] device_tree: Add info message when dumping dtb to file Alistair Francis
2020-03-21 20:38 ` [PULL 0/1] DTC queue for 5.0 Peter Maydell
0 siblings, 2 replies; 3+ messages in thread
From: Alistair Francis @ 2020-03-20 21:59 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell, Alistair Francis, alistair23
The following changes since commit 3d0ac346032a1fa9afafcaedc979a99f670e077e:
Merge remote-tracking branch 'remotes/ehabkost/tags/python-next-pull-request' into staging (2020-03-20 13:54:23 +0000)
are available in the Git repository at:
git@github.com:alistair23/qemu.git tags/pull-dtc-next-20200320-1
for you to fetch changes up to 9f252c7c88eacbf21dadcfe117b0d08f2e88ceeb:
device_tree: Add info message when dumping dtb to file (2020-03-20 14:55:44 -0700)
----------------------------------------------------------------
DTC patches for 5.0
----------------------------------------------------------------
Leonardo Bras (1):
device_tree: Add info message when dumping dtb to file
device_tree.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PULL 1/1] device_tree: Add info message when dumping dtb to file
2020-03-20 21:59 [PULL 0/1] DTC queue for 5.0 Alistair Francis
@ 2020-03-20 21:59 ` Alistair Francis
2020-03-21 20:38 ` [PULL 0/1] DTC queue for 5.0 Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Alistair Francis @ 2020-03-20 21:59 UTC (permalink / raw)
To: qemu-devel
Cc: peter.maydell, David Gibson, Alistair Francis, Leonardo Bras, alistair23
From: Leonardo Bras <leonardo@linux.ibm.com>
When dumping dtb to a file, qemu exits silently before starting the VM.
Add info message so user can easily track why the proccess exits.
Add error message if dtb dump failed.
Signed-off-by: Leonardo Bras <leonardo@linux.ibm.com>
Message-Id: <20200319040326.391090-1-leonardo@linux.ibm.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---
device_tree.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/device_tree.c b/device_tree.c
index f8b46b3c73..bba6cc2164 100644
--- a/device_tree.c
+++ b/device_tree.c
@@ -530,7 +530,12 @@ void qemu_fdt_dumpdtb(void *fdt, int size)
if (dumpdtb) {
/* Dump the dtb to a file and quit */
- exit(g_file_set_contents(dumpdtb, fdt, size, NULL) ? 0 : 1);
+ if (g_file_set_contents(dumpdtb, fdt, size, NULL)) {
+ info_report("dtb dumped to %s. Exiting.", dumpdtb);
+ exit(0);
+ }
+ error_report("%s: Failed dumping dtb to %s", __func__, dumpdtb);
+ exit(1);
}
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PULL 0/1] DTC queue for 5.0
2020-03-20 21:59 [PULL 0/1] DTC queue for 5.0 Alistair Francis
2020-03-20 21:59 ` [PULL 1/1] device_tree: Add info message when dumping dtb to file Alistair Francis
@ 2020-03-21 20:38 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2020-03-21 20:38 UTC (permalink / raw)
To: Alistair Francis; +Cc: Alistair Francis, QEMU Developers
On Fri, 20 Mar 2020 at 22:06, Alistair Francis <alistair.francis@wdc.com> wrote:
>
> The following changes since commit 3d0ac346032a1fa9afafcaedc979a99f670e077e:
>
> Merge remote-tracking branch 'remotes/ehabkost/tags/python-next-pull-request' into staging (2020-03-20 13:54:23 +0000)
>
> are available in the Git repository at:
>
> git@github.com:alistair23/qemu.git tags/pull-dtc-next-20200320-1
>
> for you to fetch changes up to 9f252c7c88eacbf21dadcfe117b0d08f2e88ceeb:
>
> device_tree: Add info message when dumping dtb to file (2020-03-20 14:55:44 -0700)
>
> ----------------------------------------------------------------
> DTC patches for 5.0
>
> ----------------------------------------------------------------
> Leonardo Bras (1):
> device_tree: Add info message when dumping dtb to file
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/5.0
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-21 20:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-20 21:59 [PULL 0/1] DTC queue for 5.0 Alistair Francis
2020-03-20 21:59 ` [PULL 1/1] device_tree: Add info message when dumping dtb to file Alistair Francis
2020-03-21 20:38 ` [PULL 0/1] DTC queue for 5.0 Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.