[tglx-devel:x86/entry 29/35] kernel/rcu/tree.c:656 rcu_nmi_exit_common() warn: inconsistent indenting

[tglx-devel:x86/entry 29/35] kernel/rcu/tree.c:656 rcu_nmi_exit_common() warn: inconsistent indenting

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 2581 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git x86/entry
head:   7096e812c49531b01ba861ed9b7d895b292d0d1d
commit: 156e79d9bbb302a2b9c1bffcb813f6164f805464 [29/35] rcu/tree: Mark the idle relevant functions noinstr

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

smatch warnings:
kernel/rcu/tree.c:656 rcu_nmi_exit_common() warn: inconsistent indenting

vim +656 kernel/rcu/tree.c

   620	
   621	/*
   622	 * If we are returning from the outermost NMI handler that interrupted an
   623	 * RCU-idle period, update rdp->dynticks and rdp->dynticks_nmi_nesting
   624	 * to let the RCU grace-period handling know that the CPU is back to
   625	 * being RCU-idle.
   626	 *
   627	 * If you add or remove a call to rcu_nmi_exit_common(), be sure to test
   628	 * with CONFIG_RCU_EQS_DEBUG=y.
   629	 */
   630	static __always_inline void rcu_nmi_exit_common(bool irq)
   631	{
   632		struct rcu_data *rdp = this_cpu_ptr(&rcu_data);
   633	
   634		/*
   635		 * Check for ->dynticks_nmi_nesting underflow and bad ->dynticks.
   636		 * (We are exiting an NMI handler, so RCU better be paying attention
   637		 * to us!)
   638		 */
   639		WARN_ON_ONCE(rdp->dynticks_nmi_nesting <= 0);
   640		WARN_ON_ONCE(rcu_dynticks_curr_cpu_in_eqs());
   641	
   642		/*
   643		 * If the nesting level is not 1, the CPU wasn't RCU-idle, so
   644		 * leave it in non-RCU-idle state.
   645		 */
   646		if (rdp->dynticks_nmi_nesting != 1) {
   647			instr_begin();
   648			trace_rcu_dyntick(TPS("--="), rdp->dynticks_nmi_nesting, rdp->dynticks_nmi_nesting - 2,
   649					  atomic_read(&rdp->dynticks));
   650			WRITE_ONCE(rdp->dynticks_nmi_nesting, /* No store tearing. */
   651				   rdp->dynticks_nmi_nesting - 2);
   652			instr_end();
   653			return;
   654		}
   655	
 > 656			instr_begin();
   657		/* This NMI interrupted an RCU-idle CPU, restore RCU-idleness. */
   658		trace_rcu_dyntick(TPS("Startirq"), rdp->dynticks_nmi_nesting, 0, atomic_read(&rdp->dynticks));
   659		WRITE_ONCE(rdp->dynticks_nmi_nesting, 0); /* Avoid store tearing. */
   660	
   661		if (irq)
   662			rcu_prepare_for_idle();
   663		instr_end();
   664	
   665		// RCU is watching here ...
   666		rcu_dynticks_eqs_enter();
   667		// ... but is no longer watching here.
   668	
   669		if (irq)
   670			rcu_dynticks_task_enter();
   671	}
   672	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org