[android-common:android-trusty-4.19 6/8] drivers/trusty/trusty-test.c:382:1: sparse: sparse: symbol 'dev_attr_trusty_test_run' was not declared. Should it be static?

[android-common:android-trusty-4.19 6/8] drivers/trusty/trusty-test.c:382:1: sparse: sparse: symbol 'dev_attr_trusty_test_run' was not declared. Should it be static?

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1440 bytes --]

tree:   https://android.googlesource.com/kernel/common android-trusty-4.19
head:   412267edb42b79403e8597c913039154dfdd5d0a
commit: 3b73c0e90d449bbb4c49297238c24badc3ed7aa5 [6/8] trusty: Add stdcalltest
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-181-g83789bbc-dirty
        git checkout 3b73c0e90d449bbb4c49297238c24badc3ed7aa5
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> drivers/trusty/trusty-test.c:382:1: sparse: sparse: symbol 'dev_attr_trusty_test_run' was not declared. Should it be static?
   In file included from include/linux/platform_device.h:14:0,
                    from drivers/trusty/trusty-test.c:8:
   drivers/trusty/trusty-test.c: In function 'trusty_test_run':
   include/linux/device.h:1442:2: warning: 'obj' may be used uninitialized in this function [-Wmaybe-uninitialized]
     _dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
     ^~~~~~~~
   drivers/trusty/trusty-test.c:287:32: note: 'obj' was declared here
     struct trusty_test_shmem_obj *obj;
                                   ^~~

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[RFC PATCH android-common] trusty: dev_attr_trusty_test_run can be static

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 604 bytes --]


Fixes: 3b73c0e90d44 ("trusty: Add stdcalltest")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 trusty-test.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/trusty/trusty-test.c b/drivers/trusty/trusty-test.c
index 117958c8bd4e3..ab16e06453cbc 100644
--- a/drivers/trusty/trusty-test.c
+++ b/drivers/trusty/trusty-test.c
@@ -379,7 +379,7 @@ static ssize_t trusty_test_run_store(struct device *dev,
 	}
 }
 
-DEVICE_ATTR_WO(trusty_test_run);
+static DEVICE_ATTR_WO(trusty_test_run);
 
 static int trusty_test_probe(struct platform_device *pdev)
 {