[PATCH] rtc: max8907: add missing select REGMAP_IRQ

[PATCH] rtc: max8907: add missing select REGMAP_IRQ

[Corentin Labbe]

I have hit the following build error:
armv7a-hardfloat-linux-gnueabi-ld: drivers/rtc/rtc-max8907.o: in function `max8907_rtc_probe':
rtc-max8907.c:(.text+0x400): undefined reference to `regmap_irq_get_virq'

max8907 should select REGMAP_IRQ

Fixes: 94c01ab6d7544 ("rtc: add MAX8907 RTC driver")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
 drivers/rtc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index 7d6cb60ee010..6c99156cbe57 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -327,6 +327,7 @@ config RTC_DRV_MAX6900
 config RTC_DRV_MAX8907
 	tristate "Maxim MAX8907"
 	depends on MFD_MAX8907 || COMPILE_TEST
+	select REGMAP_IRQ
 	help
 	  If you say yes here you will get support for the
 	  RTC of Maxim MAX8907 PMIC.
-- 
2.24.1

Re: [PATCH] rtc: max8907: add missing select REGMAP_IRQ

[Sasha Levin]

Hi

[This is an automated email]

This commit has been processed because it contains a "Fixes:" tag
fixing commit: 94c01ab6d754 ("rtc: add MAX8907 RTC driver").

The bot has tested the following trees: v5.5.10, v5.4.26, v4.19.111, v4.14.173, v4.9.216, v4.4.216.

v5.5.10: Build OK!
v5.4.26: Build OK!
v4.19.111: Build OK!
v4.14.173: Build OK!
v4.9.216: Failed to apply! Possible dependencies:
    959df7778bbd ("rtc: Enable compile testing for Maxim and Samsung drivers")

v4.4.216: Failed to apply! Possible dependencies:
    01ea01b35120 ("rtc: max77686: Use a driver data struct instead hard-coded values")
    0b4f8b085b5d ("rtc: max77686: fix checkpatch error")
    5981804b8365 ("rtc: max77686: Use usleep_range() instead of msleep()")
    69be249ab4bc ("rtc: max77686: use rtc regmap to access RTC registers")
    726fe738bd5c ("rtc: max77686: Add support for MAX20024/MAX77620 RTC IP")
    862f9453bd14 ("rtc: max77686: Use ARRAY_SIZE() instead of current array length")
    90a5698a86ba ("rtc: max77686: Add an indirection level to access RTC registers")
    959df7778bbd ("rtc: Enable compile testing for Maxim and Samsung drivers")
    bf035f42344a ("rtc: max77686: Cleanup and reduce dmesg output")
    f3937549a975 ("rtc: max77686: move initialisation of rtc regmap, irq chip locally")
    f604c48849a5 ("rtc: max77686: avoid reference of parent device info multiple places")
    f903129b8607 ("rtc: max77686: Add max77802 support")


NOTE: The patch will not be queued to stable trees until it is upstream.

How should we proceed with this patch?

-- 
Thanks
Sasha

Re: [PATCH] rtc: max8907: add missing select REGMAP_IRQ

[Alexandre Belloni]

On 18/03/2020 15:26:49+0000, Corentin Labbe wrote:
> I have hit the following build error:
> armv7a-hardfloat-linux-gnueabi-ld: drivers/rtc/rtc-max8907.o: in function `max8907_rtc_probe':
> rtc-max8907.c:(.text+0x400): undefined reference to `regmap_irq_get_virq'
> 
> max8907 should select REGMAP_IRQ
> 
> Fixes: 94c01ab6d7544 ("rtc: add MAX8907 RTC driver")
> Cc: stable <stable@vger.kernel.org>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
>  drivers/rtc/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
Applied, thanks.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com