[Buildroot] [PATCH v2, 1/2] package/mediastreamer: portaudio needs speexdsp

[Buildroot] [PATCH v2, 1/2] package/mediastreamer: portaudio needs speexdsp

[Fabrice Fontaine]

Commit 8f5562ed7c227f29dbfa6897f54dccda0dfbf656 wrongly removed speexdsp
dependency from portaudio

Fixes:
 - http://autobuild.buildroot.org/results/e6adf151141ae56f5194165fd5b74b52164bfb17

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
Changes v1 -> v2 (after review of Thomas Petazzoni):
 - portaudio only needs speexdsp, not speex

 package/mediastreamer/mediastreamer.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/mediastreamer/mediastreamer.mk b/package/mediastreamer/mediastreamer.mk
index dcec66dfcd..691eaddb52 100644
--- a/package/mediastreamer/mediastreamer.mk
+++ b/package/mediastreamer/mediastreamer.mk
@@ -80,7 +80,8 @@ else
 MEDIASTREAMER_CONF_OPTS += -DENABLE_OPUS=OFF
 endif
 
-ifeq ($(BR2_PACKAGE_PORTAUDIO),y)
+# portaudio backend needs speexdsp as well
+ifeq ($(BR2_PACKAGE_PORTAUDIO)$(BR2_PACKAGE_SPEEXDSP),yy)
 MEDIASTREAMER_CONF_OPTS += \
 	-DENABLE_PORTAUDIO=ON \
 	-DENABLE_SOUND=ON
-- 
2.25.1

[Buildroot] [PATCH v2, 2/2] package/mediastreamer: resample needs speex and speexdsp

[Fabrice Fontaine]

resample needs speex and speexdsp as spotted by Thomas Petazzoni during
review of https://patchwork.ozlabs.org/patch/1252391/

Fixes:
 - http://autobuild.buildroot.org/results/32d06517a5470f71d9b7dc99139f6c3071e7d77d

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
Changes v1 -> v2 (after review of Thomas Petazzoni):
 - resample needs speex and speexdsp

 package/mediastreamer/mediastreamer.mk | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/package/mediastreamer/mediastreamer.mk b/package/mediastreamer/mediastreamer.mk
index 691eaddb52..982eadf099 100644
--- a/package/mediastreamer/mediastreamer.mk
+++ b/package/mediastreamer/mediastreamer.mk
@@ -113,6 +113,12 @@ else
 MEDIASTREAMER_CONF_OPTS += -DENABLE_SPEEX_DSP=OFF
 endif
 
+ifeq ($(BR2_PACKAGE_SPEEX)$(BR2_PACKAGE_SPEEXDSP),yy)
+MEDIASTREAMER_CONF_OPTS += -DENABLE_RESAMPLE=ON
+else
+MEDIASTREAMER_CONF_OPTS += -DENABLE_RESAMPLE=OFF
+endif
+
 ifeq ($(BR2_PACKAGE_FFMPEG_SWSCALE),y)
 MEDIASTREAMER_CONF_OPTS += -DENABLE_FFMPEG=ON
 MEDIASTREAMER_DEPENDENCIES += ffmpeg
-- 
2.25.1

[Buildroot] [PATCH v2, 1/2] package/mediastreamer: portaudio needs speexdsp

[Thomas Petazzoni]

On Mon, 23 Mar 2020 19:01:20 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Commit 8f5562ed7c227f29dbfa6897f54dccda0dfbf656 wrongly removed speexdsp
> dependency from portaudio
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/e6adf151141ae56f5194165fd5b74b52164bfb17
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2 (after review of Thomas Petazzoni):
>  - portaudio only needs speexdsp, not speex

Thanks, I've applied both. Could you report both bugs upstream? Indeed
these issues should not lead to compilation failure: it should be
handled in CMakeLists.txt, either by disabling the feature, or erroring
out at configure time.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com