* [PATCH] staging: vt6655: line over 80 characters
@ 2020-03-24 23:42 Gokce Kuler
0 siblings, 0 replies; 3+ messages in thread
From: Gokce Kuler @ 2020-03-24 23:42 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh
Moved to the bottom line after && operator for it exceeds 80 character
Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
---
drivers/staging/vt6655/rxtx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
index ac1eeb7..e91d320 100644
--- a/drivers/staging/vt6655/rxtx.c
+++ b/drivers/staging/vt6655/rxtx.c
@@ -838,7 +838,8 @@ s_vFillCTSHead(
}
if (byPktType == PK_TYPE_11GB || byPktType == PK_TYPE_11GA) {
- if (byFBOption != AUTO_FB_NONE && uDMAIdx != TYPE_ATIMDMA && uDMAIdx != TYPE_BEACONDMA) {
+ if (byFBOption != AUTO_FB_NONE &&
+ uDMAIdx != TYPE_ATIMDMA && uDMAIdx != TYPE_BEACONDMA) {
/* Auto Fall back */
struct vnt_cts_fb *buf = pvCTS;
/* Get SignalField, ServiceField & Length */
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: vt6655: line over 80 characters
2020-03-27 23:45 Gokce Kuler
@ 2020-03-30 15:38 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2020-03-30 15:38 UTC (permalink / raw)
To: Gokce Kuler; +Cc: outreachy-kernel, forest
On Sat, Mar 28, 2020 at 02:45:13AM +0300, Gokce Kuler wrote:
> Move to bottom lines from comma for 80 characers limit.
I'm sorry, but I can't really understand what you are trying to say
here. Perhaps word it differently?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] staging: vt6655: line over 80 characters
@ 2020-03-27 23:45 Gokce Kuler
2020-03-30 15:38 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Gokce Kuler @ 2020-03-27 23:45 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh, forest
Move to bottom lines from comma for 80 characers limit.
Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
---
drivers/staging/vt6655/rxtx.c | 85 ++++++++++++++++++++++++++++++++++---------
1 file changed, 68 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
index e91d320..dcc8fd9 100644
--- a/drivers/staging/vt6655/rxtx.c
+++ b/drivers/staging/vt6655/rxtx.c
@@ -968,50 +968,100 @@ s_vGenerateTxParameter(
/* Fill RsvTime */
struct vnt_rrv_time_rts *buf = pvRrvTime;
- buf->rts_rrv_time_aa = s_uGetRTSCTSRsvTime(pDevice, 2, byPktType, cbFrameSize, wCurrentRate);
- buf->rts_rrv_time_ba = s_uGetRTSCTSRsvTime(pDevice, 1, byPktType, cbFrameSize, wCurrentRate);
- buf->rts_rrv_time_bb = s_uGetRTSCTSRsvTime(pDevice, 0, byPktType, cbFrameSize, wCurrentRate);
- buf->rrv_time_a = vnt_rxtx_rsvtime_le16(pDevice, byPktType, cbFrameSize, wCurrentRate, bNeedACK);
+ buf->rts_rrv_time_aa = s_uGetRTSCTSRsvTime(pDevice, 2,
+ byPktType,
+ cbFrameSize,
+ wCurrentRate);
+ buf->rts_rrv_time_ba = s_uGetRTSCTSRsvTime(pDevice, 1,
+ byPktType,
+ cbFrameSize,
+ wCurrentRate);
+ buf->rts_rrv_time_bb = s_uGetRTSCTSRsvTime(pDevice, 0,
+ byPktType,
+ cbFrameSize,
+ wCurrentRate);
+ buf->rrv_time_a = vnt_rxtx_rsvtime_le16(pDevice,
+ byPktType,
+ cbFrameSize,
+ wCurrentRate,
+ bNeedACK);
buf->rrv_time_b = vnt_rxtx_rsvtime_le16(pDevice, PK_TYPE_11B, cbFrameSize, pDevice->byTopCCKBasicRate, bNeedACK);
- s_vFillRTSHead(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCRC, psEthHeader, wCurrentRate, byFBOption);
+ s_vFillRTSHead(pDevice, byPktType, pvRTS, cbFrameSize,
+ bNeedACK, bDisCRC, psEthHeader,
+ wCurrentRate, byFBOption);
} else {/* RTS_needless, PCF mode */
struct vnt_rrv_time_cts *buf = pvRrvTime;
- buf->rrv_time_a = vnt_rxtx_rsvtime_le16(pDevice, byPktType, cbFrameSize, wCurrentRate, bNeedACK);
+ buf->rrv_time_a = vnt_rxtx_rsvtime_le16(pDevice,
+ byPktType,
+ cbFrameSize,
+ wCurrentRate,
+ bNeedACK);
buf->rrv_time_b = vnt_rxtx_rsvtime_le16(pDevice, PK_TYPE_11B, cbFrameSize, pDevice->byTopCCKBasicRate, bNeedACK);
- buf->cts_rrv_time_ba = s_uGetRTSCTSRsvTime(pDevice, 3, byPktType, cbFrameSize, wCurrentRate);
+ buf->cts_rrv_time_ba = s_uGetRTSCTSRsvTime(pDevice, 3,
+ byPktType,
+ cbFrameSize,
+ wCurrentRate);
/* Fill CTS */
- s_vFillCTSHead(pDevice, uDMAIdx, byPktType, pvCTS, cbFrameSize, bNeedACK, bDisCRC, wCurrentRate, byFBOption);
+ s_vFillCTSHead(pDevice, uDMAIdx, byPktType, pvCTS,
+ cbFrameSize, bNeedACK, bDisCRC,
+ wCurrentRate, byFBOption);
}
} else if (byPktType == PK_TYPE_11A) {
if (pvRTS) {/* RTS_need, non PCF mode */
struct vnt_rrv_time_ab *buf = pvRrvTime;
- buf->rts_rrv_time = s_uGetRTSCTSRsvTime(pDevice, 2, byPktType, cbFrameSize, wCurrentRate);
- buf->rrv_time = vnt_rxtx_rsvtime_le16(pDevice, byPktType, cbFrameSize, wCurrentRate, bNeedACK);
+ buf->rts_rrv_time = s_uGetRTSCTSRsvTime(pDevice, 2,
+ byPktType,
+ cbFrameSize,
+ wCurrentRate);
+ buf->rrv_time = vnt_rxtx_rsvtime_le16(pDevice,
+ byPktType,
+ cbFrameSize,
+ wCurrentRate,
+ bNeedACK);
/* Fill RTS */
- s_vFillRTSHead(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCRC, psEthHeader, wCurrentRate, byFBOption);
+ s_vFillRTSHead(pDevice, byPktType, pvRTS, cbFrameSize,
+ bNeedACK, bDisCRC, psEthHeader,
+ wCurrentRate, byFBOption);
} else if (!pvRTS) {/* RTS_needless, non PCF mode */
struct vnt_rrv_time_ab *buf = pvRrvTime;
- buf->rrv_time = vnt_rxtx_rsvtime_le16(pDevice, PK_TYPE_11A, cbFrameSize, wCurrentRate, bNeedACK);
+ buf->rrv_time = vnt_rxtx_rsvtime_le16(pDevice,
+ PK_TYPE_11A,
+ cbFrameSize,
+ wCurrentRate,
+ bNeedACK);
}
} else if (byPktType == PK_TYPE_11B) {
if (pvRTS) {/* RTS_need, non PCF mode */
struct vnt_rrv_time_ab *buf = pvRrvTime;
- buf->rts_rrv_time = s_uGetRTSCTSRsvTime(pDevice, 0, byPktType, cbFrameSize, wCurrentRate);
- buf->rrv_time = vnt_rxtx_rsvtime_le16(pDevice, PK_TYPE_11B, cbFrameSize, wCurrentRate, bNeedACK);
+ buf->rts_rrv_time = s_uGetRTSCTSRsvTime(pDevice, 0,
+ byPktType,
+ cbFrameSize,
+ wCurrentRate);
+ buf->rrv_time = vnt_rxtx_rsvtime_le16(pDevice,
+ PK_TYPE_11B,
+ cbFrameSize,
+ wCurrentRate,
+ bNeedACK);
/* Fill RTS */
- s_vFillRTSHead(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCRC, psEthHeader, wCurrentRate, byFBOption);
+ s_vFillRTSHead(pDevice, byPktType, pvRTS, cbFrameSize,
+ bNeedACK, bDisCRC, psEthHeader,
+ wCurrentRate, byFBOption);
} else { /* RTS_needless, non PCF mode */
struct vnt_rrv_time_ab *buf = pvRrvTime;
- buf->rrv_time = vnt_rxtx_rsvtime_le16(pDevice, PK_TYPE_11B, cbFrameSize, wCurrentRate, bNeedACK);
+ buf->rrv_time = vnt_rxtx_rsvtime_le16(pDevice,
+ PK_TYPE_11B,
+ cbFrameSize,
+ wCurrentRate,
+ bNeedACK);
}
}
}
@@ -1183,7 +1233,8 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType,
uDuration = s_uFillDataHead(pDevice, byPktType, pvTxDataHd,
cbFrameSize, uDMAIdx,
bNeedACK, 0, 0, uMACfragNum,
- byFBOption, pDevice->wCurrentRate, is_pspoll);
+ byFBOption, pDevice->wCurrentRate,
+ is_pspoll);
hdr->duration_id = uDuration;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-30 15:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-24 23:42 [PATCH] staging: vt6655: line over 80 characters Gokce Kuler
2020-03-27 23:45 Gokce Kuler
2020-03-30 15:38 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.