* [PATCH v5 1/3] scsi/esp-pci: add g_assert() for fix clang analyzer warning in esp_pci_io_write()
2020-03-25 2:59 [PATCH v5 0/3] redundant code: Fix warnings reported by Clang static code analyzer Chen Qun
@ 2020-03-25 2:59 ` Chen Qun
2020-03-25 2:59 ` [PATCH v5 2/3] display/blizzard: use extract16() for fix clang analyzer warning in blizzard_draw_line16_32() Chen Qun
` (2 subsequent siblings)
3 siblings, 0 replies; 14+ messages in thread
From: Chen Qun @ 2020-03-25 2:59 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Cc: zhang.zhanghailiang, laurent, Paolo Bonzini, Euler Robot,
Chen Qun, philmd
Clang static code analyzer show warning:
hw/scsi/esp-pci.c:198:9: warning: Value stored to 'size' is never read
size = 4;
^ ~
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
---
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc:Fam Zheng <fam@euphon.net>
v1->v2:
keep ' size = 4' and add 'g_assert(size >= 4)' after if() statement.
(Base on Laurent's comments)
---
hw/scsi/esp-pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/scsi/esp-pci.c b/hw/scsi/esp-pci.c
index d5a1f9e017..497a8d5901 100644
--- a/hw/scsi/esp-pci.c
+++ b/hw/scsi/esp-pci.c
@@ -197,6 +197,7 @@ static void esp_pci_io_write(void *opaque, hwaddr addr,
addr &= ~3;
size = 4;
}
+ g_assert(size >= 4);
if (addr < 0x40) {
/* SCSI core reg */
--
2.23.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v5 2/3] display/blizzard: use extract16() for fix clang analyzer warning in blizzard_draw_line16_32()
2020-03-25 2:59 [PATCH v5 0/3] redundant code: Fix warnings reported by Clang static code analyzer Chen Qun
2020-03-25 2:59 ` [PATCH v5 1/3] scsi/esp-pci: add g_assert() for fix clang analyzer warning in esp_pci_io_write() Chen Qun
@ 2020-03-25 2:59 ` Chen Qun
2020-03-25 7:18 ` Laurent Vivier
2020-03-25 2:59 ` [PATCH v5 3/3] timer/exynos4210_mct: Remove redundant statement in exynos4210_mct_write() Chen Qun
2020-04-03 7:51 ` [PATCH v5 0/3] redundant code: Fix warnings reported by Clang static code analyzer Chenqun (kuhn)
3 siblings, 1 reply; 14+ messages in thread
From: Chen Qun @ 2020-03-25 2:59 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Cc: Peter Maydell, zhang.zhanghailiang, philmd, laurent, Euler Robot,
Chen Qun
Clang static code analyzer show warning:
hw/display/blizzard.c:940:9: warning: Value stored to 'data' is never read
data >>= 5;
^ ~
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
---
Cc: Andrzej Zaborowski <balrogg@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>
v1->v2: Use extract16() function instead of bit operation(Base on Laurent's comments).
---
hw/display/blizzard.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/hw/display/blizzard.c b/hw/display/blizzard.c
index 359e399c2a..105241577d 100644
--- a/hw/display/blizzard.c
+++ b/hw/display/blizzard.c
@@ -19,6 +19,7 @@
*/
#include "qemu/osdep.h"
+#include "qemu/bitops.h"
#include "ui/console.h"
#include "hw/display/blizzard.h"
#include "ui/pixel_ops.h"
@@ -932,12 +933,9 @@ static void blizzard_draw_line16_32(uint32_t *dest,
const uint16_t *end = (const void *) src + width;
while (src < end) {
data = *src ++;
- b = (data & 0x1f) << 3;
- data >>= 5;
- g = (data & 0x3f) << 2;
- data >>= 6;
- r = (data & 0x1f) << 3;
- data >>= 5;
+ b = extract16(data, 0, 5) << 3;
+ g = extract16(data, 5, 6) << 2;
+ r = extract16(data, 11, 5) << 3;
*dest++ = rgb_to_pixel32(r, g, b);
}
}
--
2.23.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v5 2/3] display/blizzard: use extract16() for fix clang analyzer warning in blizzard_draw_line16_32()
2020-03-25 2:59 ` [PATCH v5 2/3] display/blizzard: use extract16() for fix clang analyzer warning in blizzard_draw_line16_32() Chen Qun
@ 2020-03-25 7:18 ` Laurent Vivier
0 siblings, 0 replies; 14+ messages in thread
From: Laurent Vivier @ 2020-03-25 7:18 UTC (permalink / raw)
To: Chen Qun, qemu-devel, qemu-trivial
Cc: Peter Maydell, philmd, zhang.zhanghailiang, Euler Robot
Le 25/03/2020 à 03:59, Chen Qun a écrit :
> Clang static code analyzer show warning:
> hw/display/blizzard.c:940:9: warning: Value stored to 'data' is never read
> data >>= 5;
> ^ ~
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
> ---
> Cc: Andrzej Zaborowski <balrogg@gmail.com>
> Cc: Peter Maydell <peter.maydell@linaro.org>
>
> v1->v2: Use extract16() function instead of bit operation(Base on Laurent's comments).
> ---
> hw/display/blizzard.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/hw/display/blizzard.c b/hw/display/blizzard.c
> index 359e399c2a..105241577d 100644
> --- a/hw/display/blizzard.c
> +++ b/hw/display/blizzard.c
> @@ -19,6 +19,7 @@
> */
>
> #include "qemu/osdep.h"
> +#include "qemu/bitops.h"
> #include "ui/console.h"
> #include "hw/display/blizzard.h"
> #include "ui/pixel_ops.h"
> @@ -932,12 +933,9 @@ static void blizzard_draw_line16_32(uint32_t *dest,
> const uint16_t *end = (const void *) src + width;
> while (src < end) {
> data = *src ++;
> - b = (data & 0x1f) << 3;
> - data >>= 5;
> - g = (data & 0x3f) << 2;
> - data >>= 6;
> - r = (data & 0x1f) << 3;
> - data >>= 5;
> + b = extract16(data, 0, 5) << 3;
> + g = extract16(data, 5, 6) << 2;
> + r = extract16(data, 11, 5) << 3;
> *dest++ = rgb_to_pixel32(r, g, b);
> }
> }
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v5 3/3] timer/exynos4210_mct: Remove redundant statement in exynos4210_mct_write()
2020-03-25 2:59 [PATCH v5 0/3] redundant code: Fix warnings reported by Clang static code analyzer Chen Qun
2020-03-25 2:59 ` [PATCH v5 1/3] scsi/esp-pci: add g_assert() for fix clang analyzer warning in esp_pci_io_write() Chen Qun
2020-03-25 2:59 ` [PATCH v5 2/3] display/blizzard: use extract16() for fix clang analyzer warning in blizzard_draw_line16_32() Chen Qun
@ 2020-03-25 2:59 ` Chen Qun
2020-03-25 12:16 ` Philippe Mathieu-Daudé
2020-04-03 7:51 ` [PATCH v5 0/3] redundant code: Fix warnings reported by Clang static code analyzer Chenqun (kuhn)
3 siblings, 1 reply; 14+ messages in thread
From: Chen Qun @ 2020-03-25 2:59 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Cc: Peter Maydell, zhang.zhanghailiang, Igor Mitsyanko, laurent,
Euler Robot, Chen Qun, philmd
Clang static code analyzer show warning:
hw/timer/exynos4210_mct.c:1370:9: warning: Value stored to 'index' is never read
index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
hw/timer/exynos4210_mct.c:1399:9: warning: Value stored to 'index' is never read
index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
hw/timer/exynos4210_mct.c:1441:9: warning: Value stored to 'index' is never read
index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
---
Cc: Igor Mitsyanko <i.mitsyanko@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>
---
hw/timer/exynos4210_mct.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/hw/timer/exynos4210_mct.c b/hw/timer/exynos4210_mct.c
index 944120aea5..570cf7075b 100644
--- a/hw/timer/exynos4210_mct.c
+++ b/hw/timer/exynos4210_mct.c
@@ -1367,7 +1367,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr offset,
case L0_TCNTB: case L1_TCNTB:
lt_i = GET_L_TIMER_IDX(offset);
- index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
/*
* TCNTB is updated to internal register only after CNT expired.
@@ -1396,7 +1395,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr offset,
case L0_ICNTB: case L1_ICNTB:
lt_i = GET_L_TIMER_IDX(offset);
- index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
s->l_timer[lt_i].reg.wstat |= L_WSTAT_ICNTB_WRITE;
s->l_timer[lt_i].reg.cnt[L_REG_CNT_ICNTB] = value &
@@ -1438,8 +1436,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr offset,
case L0_FRCNTB: case L1_FRCNTB:
lt_i = GET_L_TIMER_IDX(offset);
- index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
-
DPRINTF("local timer[%d] FRCNTB write %llx\n", lt_i, value);
s->l_timer[lt_i].reg.wstat |= L_WSTAT_FRCCNTB_WRITE;
--
2.23.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v5 3/3] timer/exynos4210_mct: Remove redundant statement in exynos4210_mct_write()
2020-03-25 2:59 ` [PATCH v5 3/3] timer/exynos4210_mct: Remove redundant statement in exynos4210_mct_write() Chen Qun
@ 2020-03-25 12:16 ` Philippe Mathieu-Daudé
2020-03-25 12:20 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 14+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-03-25 12:16 UTC (permalink / raw)
To: Chen Qun, qemu-devel, qemu-trivial
Cc: Igor Mitsyanko, Peter Maydell, Euler Robot, zhang.zhanghailiang, laurent
On 3/25/20 3:59 AM, Chen Qun wrote:
> Clang static code analyzer show warning:
> hw/timer/exynos4210_mct.c:1370:9: warning: Value stored to 'index' is never read
> index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> hw/timer/exynos4210_mct.c:1399:9: warning: Value stored to 'index' is never read
> index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> hw/timer/exynos4210_mct.c:1441:9: warning: Value stored to 'index' is never read
> index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Cc: Igor Mitsyanko <i.mitsyanko@gmail.com>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/timer/exynos4210_mct.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/hw/timer/exynos4210_mct.c b/hw/timer/exynos4210_mct.c
> index 944120aea5..570cf7075b 100644
> --- a/hw/timer/exynos4210_mct.c
> +++ b/hw/timer/exynos4210_mct.c
> @@ -1367,7 +1367,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr offset,
>
> case L0_TCNTB: case L1_TCNTB:
> lt_i = GET_L_TIMER_IDX(offset);
> - index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
>
> /*
> * TCNTB is updated to internal register only after CNT expired.
> @@ -1396,7 +1395,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr offset,
>
> case L0_ICNTB: case L1_ICNTB:
> lt_i = GET_L_TIMER_IDX(offset);
> - index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
>
> s->l_timer[lt_i].reg.wstat |= L_WSTAT_ICNTB_WRITE;
> s->l_timer[lt_i].reg.cnt[L_REG_CNT_ICNTB] = value &
> @@ -1438,8 +1436,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr offset,
>
> case L0_FRCNTB: case L1_FRCNTB:
> lt_i = GET_L_TIMER_IDX(offset);
> - index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
> -
> DPRINTF("local timer[%d] FRCNTB write %llx\n", lt_i, value);
>
> s->l_timer[lt_i].reg.wstat |= L_WSTAT_FRCCNTB_WRITE;
>
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH v5 3/3] timer/exynos4210_mct: Remove redundant statement in exynos4210_mct_write()
2020-03-25 12:16 ` Philippe Mathieu-Daudé
@ 2020-03-25 12:20 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 14+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-03-25 12:20 UTC (permalink / raw)
To: Chen Qun, qemu-devel, qemu-trivial
Cc: Igor Mitsyanko, Peter Maydell, Euler Robot, zhang.zhanghailiang, laurent
On 3/25/20 1:16 PM, Philippe Mathieu-Daudé wrote:
> On 3/25/20 3:59 AM, Chen Qun wrote:
>> Clang static code analyzer show warning:
>> hw/timer/exynos4210_mct.c:1370:9: warning: Value stored to 'index' is
>> never read
>> index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
>> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> hw/timer/exynos4210_mct.c:1399:9: warning: Value stored to 'index' is
>> never read
>> index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
>> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> hw/timer/exynos4210_mct.c:1441:9: warning: Value stored to 'index' is
>> never read
>> index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
>> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> Reported-by: Euler Robot <euler.robot@huawei.com>
>> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
>> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Oh and per
https://www.mail-archive.com/qemu-devel@nongnu.org/msg691384.html:
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
>
>> ---
>> Cc: Igor Mitsyanko <i.mitsyanko@gmail.com>
>> Cc: Peter Maydell <peter.maydell@linaro.org>
>> ---
>> hw/timer/exynos4210_mct.c | 4 ----
>> 1 file changed, 4 deletions(-)
>>
>> diff --git a/hw/timer/exynos4210_mct.c b/hw/timer/exynos4210_mct.c
>> index 944120aea5..570cf7075b 100644
>> --- a/hw/timer/exynos4210_mct.c
>> +++ b/hw/timer/exynos4210_mct.c
>> @@ -1367,7 +1367,6 @@ static void exynos4210_mct_write(void *opaque,
>> hwaddr offset,
>> case L0_TCNTB: case L1_TCNTB:
>> lt_i = GET_L_TIMER_IDX(offset);
>> - index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
>> /*
>> * TCNTB is updated to internal register only after CNT
>> expired.
>> @@ -1396,7 +1395,6 @@ static void exynos4210_mct_write(void *opaque,
>> hwaddr offset,
>> case L0_ICNTB: case L1_ICNTB:
>> lt_i = GET_L_TIMER_IDX(offset);
>> - index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
>> s->l_timer[lt_i].reg.wstat |= L_WSTAT_ICNTB_WRITE;
>> s->l_timer[lt_i].reg.cnt[L_REG_CNT_ICNTB] = value &
>> @@ -1438,8 +1436,6 @@ static void exynos4210_mct_write(void *opaque,
>> hwaddr offset,
>> case L0_FRCNTB: case L1_FRCNTB:
>> lt_i = GET_L_TIMER_IDX(offset);
>> - index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
>> -
>> DPRINTF("local timer[%d] FRCNTB write %llx\n", lt_i, value);
>> s->l_timer[lt_i].reg.wstat |= L_WSTAT_FRCCNTB_WRITE;
>>
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH v5 0/3] redundant code: Fix warnings reported by Clang static code analyzer
2020-03-25 2:59 [PATCH v5 0/3] redundant code: Fix warnings reported by Clang static code analyzer Chen Qun
` (2 preceding siblings ...)
2020-03-25 2:59 ` [PATCH v5 3/3] timer/exynos4210_mct: Remove redundant statement in exynos4210_mct_write() Chen Qun
@ 2020-04-03 7:51 ` Chenqun (kuhn)
2020-04-03 8:04 ` Laurent Vivier
3 siblings, 1 reply; 14+ messages in thread
From: Chenqun (kuhn) @ 2020-04-03 7:51 UTC (permalink / raw)
To: qemu-devel, qemu-trivial; +Cc: philmd, Zhanghailiang, laurent
Ping!
This series has been reviewed. Could someone please pick this up (e.g. qemu-trivial?)?
>-----Original Message-----
>From: Chenqun (kuhn)
>Sent: Wednesday, March 25, 2020 10:59 AM
>To: qemu-devel@nongnu.org; qemu-trivial@nongnu.org
>Cc: Zhanghailiang <zhang.zhanghailiang@huawei.com>; laurent@vivier.eu;
>philmd@redhat.com; Chenqun (kuhn) <kuhn.chenqun@huawei.com>
>Subject: [PATCH v5 0/3] redundant code: Fix warnings reported by Clang static
>code analyzer
>
>v1->v2:
>- Patch1: Add John Snow review comment.
>- Patch9: Move the 'dst_type' declaration to while() statement.
>- Patch12: Add Philippe Mathieu-Daud茅 review comment.
>- Patch13: Move the 'set' declaration to the for() statement.
>
>v2->v3:
>- Patch1: Add Kevin Wolf review comment.
>- Patch2: Keep the 'flags' then use it(Base on Kevin's comments).
>- Patch3: Add Kevin Wolf review comment.
>- Patch9: Add Francisco Iglesias and Alistair Francis review comment.
>- Patch10: Juan Quintela has added it to the queue and delete it.
>- Patch12->Patch11: Add Philippe Mathieu-Daud茅 review comment.
>- Patch13->Patch12: Add Philippe Mathieu-Daud茅 review comment.
>
>v3->v4:
>- Deleted the patches that have been merged in the v3.
>- Modify "scsi/esp-pci" Patch, use g_assert with variable size.
>
>v4->v5:
>- Patch1: Add Laurent Vivier review comment and change the subject.
>- Patch2: Use extract16() instead of delete bit operation statement.
>- Patch3: Add Laurent Vivier review comment.
>
>Chen Qun (3):
> scsi/esp-pci: add g_assert() for fix clang analyzer warning in
> esp_pci_io_write()
> display/blizzard: use extract16() for fix clang analyzer warning in
> blizzard_draw_line16_32()
> timer/exynos4210_mct: Remove redundant statement in
> exynos4210_mct_write()
>
> hw/display/blizzard.c | 10 ++++------
> hw/scsi/esp-pci.c | 1 +
> hw/timer/exynos4210_mct.c | 4 ----
> 3 files changed, 5 insertions(+), 10 deletions(-)
>
>--
>2.23.0
>
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH v5 0/3] redundant code: Fix warnings reported by Clang static code analyzer
2020-04-03 7:51 ` [PATCH v5 0/3] redundant code: Fix warnings reported by Clang static code analyzer Chenqun (kuhn)
@ 2020-04-03 8:04 ` Laurent Vivier
2020-04-03 8:10 ` Chenqun (kuhn)
0 siblings, 1 reply; 14+ messages in thread
From: Laurent Vivier @ 2020-04-03 8:04 UTC (permalink / raw)
To: Chenqun (kuhn), qemu-devel, qemu-trivial; +Cc: philmd, Zhanghailiang
Le 03/04/2020 à 09:51, Chenqun (kuhn) a écrit :
> Ping!
>
> This series has been reviewed. Could someone please pick this up (e.g. qemu-trivial?)?
As we are in hard feature freeze now and this is not critical bug fixes
I'm going to queue them for 5.1 except if you have good arguments to
have them in 5.0.
Thanks,
Laurent
>> -----Original Message-----
>> From: Chenqun (kuhn)
>> Sent: Wednesday, March 25, 2020 10:59 AM
>> To: qemu-devel@nongnu.org; qemu-trivial@nongnu.org
>> Cc: Zhanghailiang <zhang.zhanghailiang@huawei.com>; laurent@vivier.eu;
>> philmd@redhat.com; Chenqun (kuhn) <kuhn.chenqun@huawei.com>
>> Subject: [PATCH v5 0/3] redundant code: Fix warnings reported by Clang static
>> code analyzer
>>
>> v1->v2:
>> - Patch1: Add John Snow review comment.
>> - Patch9: Move the 'dst_type' declaration to while() statement.
>> - Patch12: Add Philippe Mathieu-Daud茅 review comment.
>> - Patch13: Move the 'set' declaration to the for() statement.
>>
>> v2->v3:
>> - Patch1: Add Kevin Wolf review comment.
>> - Patch2: Keep the 'flags' then use it(Base on Kevin's comments).
>> - Patch3: Add Kevin Wolf review comment.
>> - Patch9: Add Francisco Iglesias and Alistair Francis review comment.
>> - Patch10: Juan Quintela has added it to the queue and delete it.
>> - Patch12->Patch11: Add Philippe Mathieu-Daud茅 review comment.
>> - Patch13->Patch12: Add Philippe Mathieu-Daud茅 review comment.
>>
>> v3->v4:
>> - Deleted the patches that have been merged in the v3.
>> - Modify "scsi/esp-pci" Patch, use g_assert with variable size.
>>
>> v4->v5:
>> - Patch1: Add Laurent Vivier review comment and change the subject.
>> - Patch2: Use extract16() instead of delete bit operation statement.
>> - Patch3: Add Laurent Vivier review comment.
>>
>> Chen Qun (3):
>> scsi/esp-pci: add g_assert() for fix clang analyzer warning in
>> esp_pci_io_write()
>> display/blizzard: use extract16() for fix clang analyzer warning in
>> blizzard_draw_line16_32()
>> timer/exynos4210_mct: Remove redundant statement in
>> exynos4210_mct_write()
>>
>> hw/display/blizzard.c | 10 ++++------
>> hw/scsi/esp-pci.c | 1 +
>> hw/timer/exynos4210_mct.c | 4 ----
>> 3 files changed, 5 insertions(+), 10 deletions(-)
>>
>> --
>> 2.23.0
>>
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH v5 0/3] redundant code: Fix warnings reported by Clang static code analyzer
2020-04-03 8:04 ` Laurent Vivier
@ 2020-04-03 8:10 ` Chenqun (kuhn)
2020-04-03 8:22 ` Laurent Vivier
0 siblings, 1 reply; 14+ messages in thread
From: Chenqun (kuhn) @ 2020-04-03 8:10 UTC (permalink / raw)
To: Laurent Vivier, qemu-devel, qemu-trivial; +Cc: philmd, Zhanghailiang
>-----Original Message-----
>From: Laurent Vivier [mailto:laurent@vivier.eu]
>Sent: Friday, April 3, 2020 4:04 PM
>To: Chenqun (kuhn) <kuhn.chenqun@huawei.com>; qemu-devel@nongnu.org;
>qemu-trivial@nongnu.org
>Cc: Zhanghailiang <zhang.zhanghailiang@huawei.com>; philmd@redhat.com
>Subject: Re: [PATCH v5 0/3] redundant code: Fix warnings reported by Clang
>static code analyzer
>
>Le 03/04/2020 à 09:51, Chenqun (kuhn) a écrit :
>> Ping!
>>
>> This series has been reviewed. Could someone please pick this up (e.g. qemu-
>trivial?)?
>
>As we are in hard feature freeze now and this is not critical bug fixes I'm going
>to queue them for 5.1 except if you have good arguments to have them in 5.0.
>
OK, I get it.
It is important to ensure a stable version!
Thanks.
>>> -----Original Message-----
>>> From: Chenqun (kuhn)
>>> Sent: Wednesday, March 25, 2020 10:59 AM
>>> To: qemu-devel@nongnu.org; qemu-trivial@nongnu.org
>>> Cc: Zhanghailiang <zhang.zhanghailiang@huawei.com>;
>>> laurent@vivier.eu; philmd@redhat.com; Chenqun (kuhn)
>>> <kuhn.chenqun@huawei.com>
>>> Subject: [PATCH v5 0/3] redundant code: Fix warnings reported by
>>> Clang static code analyzer
>>>
>>> v1->v2:
>>> - Patch1: Add John Snow review comment.
>>> - Patch9: Move the 'dst_type' declaration to while() statement.
>>> - Patch12: Add Philippe Mathieu-Daud茅 review comment.
>>> - Patch13: Move the 'set' declaration to the for() statement.
>>>
>>> v2->v3:
>>> - Patch1: Add Kevin Wolf review comment.
>>> - Patch2: Keep the 'flags' then use it(Base on Kevin's comments).
>>> - Patch3: Add Kevin Wolf review comment.
>>> - Patch9: Add Francisco Iglesias and Alistair Francis review comment.
>>> - Patch10: Juan Quintela has added it to the queue and delete it.
>>> - Patch12->Patch11: Add Philippe Mathieu-Daud茅 review comment.
>>> - Patch13->Patch12: Add Philippe Mathieu-Daud茅 review comment.
>>>
>>> v3->v4:
>>> - Deleted the patches that have been merged in the v3.
>>> - Modify "scsi/esp-pci" Patch, use g_assert with variable size.
>>>
>>> v4->v5:
>>> - Patch1: Add Laurent Vivier review comment and change the subject.
>>> - Patch2: Use extract16() instead of delete bit operation statement.
>>> - Patch3: Add Laurent Vivier review comment.
>>>
>>> Chen Qun (3):
>>> scsi/esp-pci: add g_assert() for fix clang analyzer warning in
>>> esp_pci_io_write()
>>> display/blizzard: use extract16() for fix clang analyzer warning in
>>> blizzard_draw_line16_32()
>>> timer/exynos4210_mct: Remove redundant statement in
>>> exynos4210_mct_write()
>>>
>>> hw/display/blizzard.c | 10 ++++------
>>> hw/scsi/esp-pci.c | 1 +
>>> hw/timer/exynos4210_mct.c | 4 ----
>>> 3 files changed, 5 insertions(+), 10 deletions(-)
>>>
>>> --
>>> 2.23.0
>>>
>>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v5 0/3] redundant code: Fix warnings reported by Clang static code analyzer
2020-04-03 8:10 ` Chenqun (kuhn)
@ 2020-04-03 8:22 ` Laurent Vivier
2020-04-03 8:27 ` Laurent Vivier
0 siblings, 1 reply; 14+ messages in thread
From: Laurent Vivier @ 2020-04-03 8:22 UTC (permalink / raw)
To: Chenqun (kuhn), qemu-devel, qemu-trivial; +Cc: philmd, Zhanghailiang
Le 03/04/2020 à 10:10, Chenqun (kuhn) a écrit :
>> -----Original Message-----
>> From: Laurent Vivier [mailto:laurent@vivier.eu]
>> Sent: Friday, April 3, 2020 4:04 PM
>> To: Chenqun (kuhn) <kuhn.chenqun@huawei.com>; qemu-devel@nongnu.org;
>> qemu-trivial@nongnu.org
>> Cc: Zhanghailiang <zhang.zhanghailiang@huawei.com>; philmd@redhat.com
>> Subject: Re: [PATCH v5 0/3] redundant code: Fix warnings reported by Clang
>> static code analyzer
>>
>> Le 03/04/2020 à 09:51, Chenqun (kuhn) a écrit :
>>> Ping!
>>>
>>> This series has been reviewed. Could someone please pick this up (e.g. qemu-
>> trivial?)?
>>
>> As we are in hard feature freeze now and this is not critical bug fixes I'm going
>> to queue them for 5.1 except if you have good arguments to have them in 5.0.
>>
> OK, I get it.
> It is important to ensure a stable version!
Queued to my linux-user-for-5.1 queue.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v5 0/3] redundant code: Fix warnings reported by Clang static code analyzer
2020-04-03 8:22 ` Laurent Vivier
@ 2020-04-03 8:27 ` Laurent Vivier
2020-04-03 8:41 ` Chenqun (kuhn)
0 siblings, 1 reply; 14+ messages in thread
From: Laurent Vivier @ 2020-04-03 8:27 UTC (permalink / raw)
To: Chenqun (kuhn), qemu-devel, qemu-trivial; +Cc: philmd, Zhanghailiang
Le 03/04/2020 à 10:22, Laurent Vivier a écrit :
> Le 03/04/2020 à 10:10, Chenqun (kuhn) a écrit :
>>> -----Original Message-----
>>> From: Laurent Vivier [mailto:laurent@vivier.eu]
>>> Sent: Friday, April 3, 2020 4:04 PM
>>> To: Chenqun (kuhn) <kuhn.chenqun@huawei.com>; qemu-devel@nongnu.org;
>>> qemu-trivial@nongnu.org
>>> Cc: Zhanghailiang <zhang.zhanghailiang@huawei.com>; philmd@redhat.com
>>> Subject: Re: [PATCH v5 0/3] redundant code: Fix warnings reported by Clang
>>> static code analyzer
>>>
>>> Le 03/04/2020 à 09:51, Chenqun (kuhn) a écrit :
>>>> Ping!
>>>>
>>>> This series has been reviewed. Could someone please pick this up (e.g. qemu-
>>> trivial?)?
>>>
>>> As we are in hard feature freeze now and this is not critical bug fixes I'm going
>>> to queue them for 5.1 except if you have good arguments to have them in 5.0.
>>>
>> OK, I get it.
>> It is important to ensure a stable version!
>
> Queued to my linux-user-for-5.1 queue.
I meant trivial-patches-for-5.1
Thanks,
Laurent
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH v5 0/3] redundant code: Fix warnings reported by Clang static code analyzer
2020-04-03 8:27 ` Laurent Vivier
@ 2020-04-03 8:41 ` Chenqun (kuhn)
2020-04-03 8:48 ` Laurent Vivier
0 siblings, 1 reply; 14+ messages in thread
From: Chenqun (kuhn) @ 2020-04-03 8:41 UTC (permalink / raw)
To: Laurent Vivier, qemu-devel, qemu-trivial; +Cc: philmd, Zhanghailiang
>-----Original Message-----
>From: Laurent Vivier [mailto:laurent@vivier.eu]
>Sent: Friday, April 3, 2020 4:28 PM
>To: Chenqun (kuhn) <kuhn.chenqun@huawei.com>; qemu-devel@nongnu.org;
>qemu-trivial@nongnu.org
>Cc: Zhanghailiang <zhang.zhanghailiang@huawei.com>; philmd@redhat.com
>Subject: Re: [PATCH v5 0/3] redundant code: Fix warnings reported by Clang
>static code analyzer
>
>Le 03/04/2020 à 10:22, Laurent Vivier a écrit :
>> Le 03/04/2020 à 10:10, Chenqun (kuhn) a écrit :
>>>> -----Original Message-----
>>>> From: Laurent Vivier [mailto:laurent@vivier.eu]
>>>> Sent: Friday, April 3, 2020 4:04 PM
>>>> To: Chenqun (kuhn) <kuhn.chenqun@huawei.com>; qemu-
>devel@nongnu.org;
>>>> qemu-trivial@nongnu.org
>>>> Cc: Zhanghailiang <zhang.zhanghailiang@huawei.com>;
>>>> philmd@redhat.com
>>>> Subject: Re: [PATCH v5 0/3] redundant code: Fix warnings reported by
>>>> Clang static code analyzer
>>>>
>>>> Le 03/04/2020 à 09:51, Chenqun (kuhn) a écrit :
>>>>> Ping!
>>>>>
>>>>> This series has been reviewed. Could someone please pick this up
>>>>> (e.g. qemu-
>>>> trivial?)?
>>>>
>>>> As we are in hard feature freeze now and this is not critical bug
>>>> fixes I'm going to queue them for 5.1 except if you have good arguments to
>have them in 5.0.
>>>>
>>> OK, I get it.
>>> It is important to ensure a stable version!
>>
>> Queued to my linux-user-for-5.1 queue.
>
>I meant trivial-patches-for-5.1
>
Thanks. Could you add another trivial patch to the queue by the way?
https://lists.gnu.org/archive/html/qemu-devel/2020-03/msg07534.html
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v5 0/3] redundant code: Fix warnings reported by Clang static code analyzer
2020-04-03 8:41 ` Chenqun (kuhn)
@ 2020-04-03 8:48 ` Laurent Vivier
0 siblings, 0 replies; 14+ messages in thread
From: Laurent Vivier @ 2020-04-03 8:48 UTC (permalink / raw)
To: Chenqun (kuhn), qemu-devel, qemu-trivial; +Cc: philmd, Zhanghailiang
Le 03/04/2020 à 10:41, Chenqun (kuhn) a écrit :
>> -----Original Message-----
>> From: Laurent Vivier [mailto:laurent@vivier.eu]
>> Sent: Friday, April 3, 2020 4:28 PM
>> To: Chenqun (kuhn) <kuhn.chenqun@huawei.com>; qemu-devel@nongnu.org;
>> qemu-trivial@nongnu.org
>> Cc: Zhanghailiang <zhang.zhanghailiang@huawei.com>; philmd@redhat.com
>> Subject: Re: [PATCH v5 0/3] redundant code: Fix warnings reported by Clang
>> static code analyzer
>>
>> Le 03/04/2020 à 10:22, Laurent Vivier a écrit :
>>> Le 03/04/2020 à 10:10, Chenqun (kuhn) a écrit :
>>>>> -----Original Message-----
>>>>> From: Laurent Vivier [mailto:laurent@vivier.eu]
>>>>> Sent: Friday, April 3, 2020 4:04 PM
>>>>> To: Chenqun (kuhn) <kuhn.chenqun@huawei.com>; qemu-
>> devel@nongnu.org;
>>>>> qemu-trivial@nongnu.org
>>>>> Cc: Zhanghailiang <zhang.zhanghailiang@huawei.com>;
>>>>> philmd@redhat.com
>>>>> Subject: Re: [PATCH v5 0/3] redundant code: Fix warnings reported by
>>>>> Clang static code analyzer
>>>>>
>>>>> Le 03/04/2020 à 09:51, Chenqun (kuhn) a écrit :
>>>>>> Ping!
>>>>>>
>>>>>> This series has been reviewed. Could someone please pick this up
>>>>>> (e.g. qemu-
>>>>> trivial?)?
>>>>>
>>>>> As we are in hard feature freeze now and this is not critical bug
>>>>> fixes I'm going to queue them for 5.1 except if you have good arguments to
>> have them in 5.0.
>>>>>
>>>> OK, I get it.
>>>> It is important to ensure a stable version!
>>>
>>> Queued to my linux-user-for-5.1 queue.
>>
>> I meant trivial-patches-for-5.1
>>
> Thanks. Could you add another trivial patch to the queue by the way?
> https://lists.gnu.org/archive/html/qemu-devel/2020-03/msg07534.html
Yes, done.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 14+ messages in thread