[PATCH] media: staging/intel-ipu3: Remove extra blank lines

[PATCH] media: staging/intel-ipu3: Remove extra blank lines

[Deepak R Varma]

Remove extra blank lines from the code blocks.

Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
---
 drivers/staging/media/ipu3/ipu3-v4l2.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/media/ipu3/ipu3-v4l2.c b/drivers/staging/media/ipu3/ipu3-v4l2.c
index 097c10d9da2a..e8f33539a217 100644
--- a/drivers/staging/media/ipu3/ipu3-v4l2.c
+++ b/drivers/staging/media/ipu3/ipu3-v4l2.c
@@ -152,7 +152,6 @@ static int imgu_subdev_set_fmt(struct v4l2_subdev *sd,
 	struct imgu_v4l2_subdev *imgu_sd = container_of(sd,
 							struct imgu_v4l2_subdev,
 							subdev);
-
 	struct v4l2_mbus_framefmt *mf;
 	u32 pad = fmt->pad;
 	unsigned int pipe = imgu_sd->pipe;
@@ -485,7 +484,6 @@ static int imgu_vb2_start_streaming(struct vb2_queue *vq, unsigned int count)
 	if (r < 0)
 		goto fail_return_bufs;
 
-
 	if (!imgu_all_nodes_streaming(imgu, node))
 		return 0;
 
-- 
2.17.1

Re: [Outreachy kernel] [PATCH] media: staging/intel-ipu3: Remove extra blank lines

[Stefano Brivio]

On Mon, 23 Mar 2020 02:30:10 +0530
Deepak R Varma <mh12gx2825@gmail.com> wrote:

> Remove extra blank lines from the code blocks.
> 
> Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>

Reviewed-by: Stefano Brivio <sbrivio@redhat.com>

-- 
Stefano

Re: [PATCH] media: staging/intel-ipu3: Remove extra blank lines

[Sakari Ailus]

Hi Deepak,

On Mon, Mar 23, 2020 at 02:30:10AM +0530, Deepak R Varma wrote:
> Remove extra blank lines from the code blocks.
> 
> Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>

Thanks for the patches. They seem fine to me, but could you send them to
the linux-media list, please? That's where the media patches are reviewed,
including the staging tree.

-- 
Kind regards,

Sakari Ailus

Re: [PATCH] media: staging/intel-ipu3: Remove extra blank lines

[DEEPAK VARMA]

On Mon, Mar 23, 2020 at 09:10:25AM +0200, Sakari Ailus wrote:
> Hi Deepak,
> 
> On Mon, Mar 23, 2020 at 02:30:10AM +0530, Deepak R Varma wrote:
> > Remove extra blank lines from the code blocks.
> > 
> > Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
> 
> Thanks for the patches. They seem fine to me, but could you send them to
> the linux-media list, please? That's where the media patches are reviewed,
> including the staging tree.
> 
Hello Sakari,
Thank you for your comments. There are 2 patches for ipu3 that are
reviewed, but yet to be accepted by Greg. A couple of them have already
been accepted in the recent past.

Do you want me to forward the current open patches list OR all the past 
patches as well OR just the future ones?

Thank you,
Deepak.

> -- 
> Kind regards,
> 
> Sakari Ailus

Re: [PATCH] media: staging/intel-ipu3: Remove extra blank lines

[Sakari Ailus]

Deepak,

On Wed, Mar 25, 2020 at 01:08:05AM +0530, DEEPAK VARMA wrote:
> On Mon, Mar 23, 2020 at 09:10:25AM +0200, Sakari Ailus wrote:
> > Hi Deepak,
> > 
> > On Mon, Mar 23, 2020 at 02:30:10AM +0530, Deepak R Varma wrote:
> > > Remove extra blank lines from the code blocks.
> > > 
> > > Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
> > 
> > Thanks for the patches. They seem fine to me, but could you send them to
> > the linux-media list, please? That's where the media patches are reviewed,
> > including the staging tree.
> > 
> Hello Sakari,
> Thank you for your comments. There are 2 patches for ipu3 that are
> reviewed, but yet to be accepted by Greg. A couple of them have already
> been accepted in the recent past.
> 
> Do you want me to forward the current open patches list OR all the past 
> patches as well OR just the future ones?

Unmerged patches and future ones, please.

-- 
Kind regards,

Sakari Ailus

Re: [PATCH] media: staging/intel-ipu3: Remove extra blank lines

[DEEPAK VARMA]

On Wed, Mar 25, 2020 at 09:28:39AM +0200, Sakari Ailus wrote:
> Deepak,
> 
> On Wed, Mar 25, 2020 at 01:08:05AM +0530, DEEPAK VARMA wrote:
> > On Mon, Mar 23, 2020 at 09:10:25AM +0200, Sakari Ailus wrote:
> > > Hi Deepak,
> > > 
> > > On Mon, Mar 23, 2020 at 02:30:10AM +0530, Deepak R Varma wrote:
> > > > Remove extra blank lines from the code blocks.
> > > > 
> > > > Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
> > > 
> > > Thanks for the patches. They seem fine to me, but could you send them to
> > > the linux-media list, please? That's where the media patches are reviewed,
> > > including the staging tree.
> > > 
> > Hello Sakari,
> > Thank you for your comments. There are 2 patches for ipu3 that are
> > reviewed, but yet to be accepted by Greg. A couple of them have already
> > been accepted in the recent past.
> > 
> > Do you want me to forward the current open patches list OR all the past 
> > patches as well OR just the future ones?
> 
> Unmerged patches and future ones, please.

Sure, I will do. Thank you.

Deepak.
> 
> -- 
> Kind regards,
> 
> Sakari Ailus

[PATCH] media: staging/intel-ipu3: Remove extra blank lines

[Deepak R Varma]

Remove extra blank lines from the code blocks.

Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>

---
NOTE: Resending patch to linux-media list as suggested by Sakari Ailus.
No changes since last version.

 drivers/staging/media/ipu3/ipu3-v4l2.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/media/ipu3/ipu3-v4l2.c b/drivers/staging/media/ipu3/ipu3-v4l2.c
index 097c10d9da2a..e8f33539a217 100644
--- a/drivers/staging/media/ipu3/ipu3-v4l2.c
+++ b/drivers/staging/media/ipu3/ipu3-v4l2.c
@@ -152,7 +152,6 @@ static int imgu_subdev_set_fmt(struct v4l2_subdev *sd,
 	struct imgu_v4l2_subdev *imgu_sd = container_of(sd,
 							struct imgu_v4l2_subdev,
 							subdev);
-
 	struct v4l2_mbus_framefmt *mf;
 	u32 pad = fmt->pad;
 	unsigned int pipe = imgu_sd->pipe;
@@ -485,7 +484,6 @@ static int imgu_vb2_start_streaming(struct vb2_queue *vq, unsigned int count)
 	if (r < 0)
 		goto fail_return_bufs;
 
-
 	if (!imgu_all_nodes_streaming(imgu, node))
 		return 0;
 
-- 
2.17.1