* [PATCH] staging: octeon-usb: line over 80 characters
@ 2020-03-25 20:27 Gokce Kuler
2020-03-25 20:38 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 3+ messages in thread
From: Gokce Kuler @ 2020-03-25 20:27 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh
Moved from the comma character to the bottom line after
for it exceeds 80 characters.
Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
---
drivers/staging/octeon-usb/octeon-hcd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
index a73289ba..dbafd46 100644
--- a/drivers/staging/octeon-usb/octeon-hcd.c
+++ b/drivers/staging/octeon-usb/octeon-hcd.c
@@ -2641,7 +2641,8 @@ static int cvmx_usb_poll_channel(struct octeon_hcd *usb, int channel)
hcintmsk.u32);
usbc_hcchar.s.chdis = 1;
cvmx_usb_write_csr32(usb,
- CVMX_USBCX_HCCHARX(channel, usb->index),
+ CVMX_USBCX_HCCHARX(
+ channel, usb->index),
usbc_hcchar.u32);
return 0;
} else if (usbc_hcint.s.xfercompl) {
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: octeon-usb: line over 80 characters
2020-03-25 20:27 [PATCH] staging: octeon-usb: line over 80 characters Gokce Kuler
@ 2020-03-25 20:38 ` Julia Lawall
2020-03-25 21:39 ` Lakshmi Ramasubramanian
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2020-03-25 20:38 UTC (permalink / raw)
To: Gokce Kuler; +Cc: outreachy-kernel, gregkh
On Wed, 25 Mar 2020, Gokce Kuler wrote:
> Moved from the comma character to the bottom line after
> for it exceeds 80 characters.
>
> Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
> ---
> drivers/staging/octeon-usb/octeon-hcd.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
> index a73289ba..dbafd46 100644
> --- a/drivers/staging/octeon-usb/octeon-hcd.c
> +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> @@ -2641,7 +2641,8 @@ static int cvmx_usb_poll_channel(struct octeon_hcd *usb, int channel)
> hcintmsk.u32);
> usbc_hcchar.s.chdis = 1;
> cvmx_usb_write_csr32(usb,
> - CVMX_USBCX_HCCHARX(channel, usb->index),
> + CVMX_USBCX_HCCHARX(
> + channel, usb->index),
> usbc_hcchar.u32);
This is confusing, It is had to see which arguments go with which
function. I don't know if it would be acceptable to add a few spaces in
front of channel.
julia
> return 0;
> } else if (usbc_hcint.s.xfercompl) {
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200325202714.GA14306%40siyah2.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: octeon-usb: line over 80 characters
2020-03-25 20:38 ` [Outreachy kernel] " Julia Lawall
@ 2020-03-25 21:39 ` Lakshmi Ramasubramanian
0 siblings, 0 replies; 3+ messages in thread
From: Lakshmi Ramasubramanian @ 2020-03-25 21:39 UTC (permalink / raw)
To: Julia Lawall, Gokce Kuler; +Cc: outreachy-kernel, gregkh
On 3/25/20 1:38 PM, Julia Lawall wrote:
>> cvmx_usb_write_csr32(usb,
>> - CVMX_USBCX_HCCHARX(channel, usb->index),
>> + CVMX_USBCX_HCCHARX(
>> + channel, usb->index),
>> usbc_hcchar.u32);
>
> This is confusing, It is had to see which arguments go with which
> function. I don't know if it would be acceptable to add a few spaces in
> front of channel.
I agree with Julia. Can we do the following and still be within the 80
character per line?
cvmx_usb_write_csr32(usb,
CVMX_USBCX_HCCHARX(channel,
usb->index),
usbc_hcchar.u32);
thanks,
-lakshmi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-25 21:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-25 20:27 [PATCH] staging: octeon-usb: line over 80 characters Gokce Kuler
2020-03-25 20:38 ` [Outreachy kernel] " Julia Lawall
2020-03-25 21:39 ` Lakshmi Ramasubramanian
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.