From: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> To: linux-media@vger.kernel.org, dafna.hirschfeld@collabora.com, helen.koike@collabora.com, ezequiel@collabora.com, hverkuil@xs4all.nl, kernel@collabora.com, dafna3@gmail.com, sakari.ailus@linux.intel.com, linux-rockchip@lists.infradead.org, mchehab@kernel.org, laurent.pinchart@ideasonboard.com Subject: [PATCH 0/2] media: staging: rkisp1: Fix formats for metadata pads Date: Wed, 25 Mar 2020 22:27:02 +0100 [thread overview] Message-ID: <20200325212704.29862-1-dafna.hirschfeld@collabora.com> (raw) There are 4 pads between the entities rkisp1_isp, rkisp1_params, rkisp1_stats that transmit metadata. Since metadata has no dimensions, it makes sense to set the width and height of these pads to 0. The problem is that it makes the v4l-compliance tests fail. Currently, in order to silent the tests, the width and height are set to RKISP1_DEFAULT_* This patchset sets the dimensions to 0 and solves the compliance error by introducing a new flag MEDIA_PAD_FL_METADATA in media.h and setting this flag to those pads. Then the v4l2-compliance tests can skip the dimensions test if this flag is set. This is just a suggested implementation from Laurent, a better documentation is probably needed. Another possible solution suggested by Verkuil is to add a new media bus format: MEDIA_BUS_FMT_FIXED_METADATA. - patch 1: introduces the the flag - patch 2: set the flag to the pads and removes a related TODO item A corresponding patch to v4l-utils will be sent. Dafna Hirschfeld (2): media: media.h: Add a pad flag MEDIA_PAD_FL_METADATA media: staging: rkisp1: add the flag MEDIA_PAD_FL_METADATA to the metadata pads Documentation/media/uapi/mediactl/media-types.rst | 4 ++++ drivers/staging/media/rkisp1/TODO | 1 - drivers/staging/media/rkisp1/rkisp1-isp.c | 10 ++++++---- drivers/staging/media/rkisp1/rkisp1-params.c | 2 +- drivers/staging/media/rkisp1/rkisp1-stats.c | 2 +- include/uapi/linux/media.h | 1 + 6 files changed, 13 insertions(+), 7 deletions(-) -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Dafna Hirschfeld <dafna.hirschfeld-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org> To: linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dafna.hirschfeld-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org, helen.koike-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org, ezequiel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org, hverkuil-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org, kernel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org, dafna3-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, mchehab-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org Subject: [PATCH 0/2] media: staging: rkisp1: Fix formats for metadata pads Date: Wed, 25 Mar 2020 22:27:02 +0100 [thread overview] Message-ID: <20200325212704.29862-1-dafna.hirschfeld@collabora.com> (raw) There are 4 pads between the entities rkisp1_isp, rkisp1_params, rkisp1_stats that transmit metadata. Since metadata has no dimensions, it makes sense to set the width and height of these pads to 0. The problem is that it makes the v4l-compliance tests fail. Currently, in order to silent the tests, the width and height are set to RKISP1_DEFAULT_* This patchset sets the dimensions to 0 and solves the compliance error by introducing a new flag MEDIA_PAD_FL_METADATA in media.h and setting this flag to those pads. Then the v4l2-compliance tests can skip the dimensions test if this flag is set. This is just a suggested implementation from Laurent, a better documentation is probably needed. Another possible solution suggested by Verkuil is to add a new media bus format: MEDIA_BUS_FMT_FIXED_METADATA. - patch 1: introduces the the flag - patch 2: set the flag to the pads and removes a related TODO item A corresponding patch to v4l-utils will be sent. Dafna Hirschfeld (2): media: media.h: Add a pad flag MEDIA_PAD_FL_METADATA media: staging: rkisp1: add the flag MEDIA_PAD_FL_METADATA to the metadata pads Documentation/media/uapi/mediactl/media-types.rst | 4 ++++ drivers/staging/media/rkisp1/TODO | 1 - drivers/staging/media/rkisp1/rkisp1-isp.c | 10 ++++++---- drivers/staging/media/rkisp1/rkisp1-params.c | 2 +- drivers/staging/media/rkisp1/rkisp1-stats.c | 2 +- include/uapi/linux/media.h | 1 + 6 files changed, 13 insertions(+), 7 deletions(-) -- 2.17.1
next reply other threads:[~2020-03-25 21:27 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-25 21:27 Dafna Hirschfeld [this message] 2020-03-25 21:27 ` [PATCH 0/2] media: staging: rkisp1: Fix formats for metadata pads Dafna Hirschfeld 2020-03-25 21:27 ` [PATCH 1/2] media: media.h: Add a pad flag MEDIA_PAD_FL_METADATA Dafna Hirschfeld 2020-03-25 22:26 ` Laurent Pinchart 2020-03-26 7:59 ` Dafna Hirschfeld 2020-03-27 8:08 ` Sakari Ailus 2020-03-30 12:42 ` Dafna Hirschfeld 2020-10-30 4:56 ` Helen Koike 2020-10-30 4:56 ` Helen Koike 2020-10-30 10:07 ` Dafna Hirschfeld 2020-10-30 10:07 ` Dafna Hirschfeld 2020-03-25 21:27 ` [PATCH 2/2] media: staging: rkisp1: add the flag MEDIA_PAD_FL_METADATA to the metadata pads Dafna Hirschfeld
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200325212704.29862-1-dafna.hirschfeld@collabora.com \ --to=dafna.hirschfeld@collabora.com \ --cc=dafna3@gmail.com \ --cc=ezequiel@collabora.com \ --cc=helen.koike@collabora.com \ --cc=hverkuil@xs4all.nl \ --cc=kernel@collabora.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-media@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=mchehab@kernel.org \ --cc=sakari.ailus@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.